Received-SPF: pass (google.com: domain of linux-kernel+bounces-185847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Huang, Ying" <ying.huang@intel.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org,  hughd@google.com,  <willy@infradead.org>,
  <david@redhat.com>,  <ioworker0@gmail.com>,  <hrisl@kernel.org>,
  <p.raghav@samsung.com>,  <da.gomez@samsung.com>,
  <wangkefeng.wang@huawei.com>,  <21cnbao@gmail.com>,
  <ryan.roberts@arm.com>,  <shy828301@gmail.com>,  <ziy@nvidia.com>,
  <linux-mm@kvack.org>,  <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/8] mm: fix shmem swapout statistic
In-Reply-To: <f467d0e9a021f4bd95588b9d888f1740fab3e3bc.1716285099.git.baolin.wang@linux.alibaba.com>
	(Baolin Wang's message of "Tue, 21 May 2024 19:03:11 +0800")
References: <cover.1716285099.git.baolin.wang@linux.alibaba.com>
	<f467d0e9a021f4bd95588b9d888f1740fab3e3bc.1716285099.git.baolin.wang@linux.alibaba.com>
Date: Wed, 22 May 2024 15:16:05 +0800
Message-ID: <87le42b9l6.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii

Baolin Wang <baolin.wang@linux.alibaba.com> writes:

> As we know, shmem not only supports the sharing of anonymous pages, but also
> the RAM-based temporary filesystem. Therefore, shmem swapouts should not be
> marked as anonymous swapout statistics. Fix it by adding folio_test_anon().
>
> Fixes: d0f048ac39f6 ("mm: add per-order mTHP anon_swpout and anon_swpout_fallback counters")
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/page_io.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/page_io.c b/mm/page_io.c
> index 46c603dddf04..b181b81f39e3 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -217,7 +217,9 @@ static inline void count_swpout_vm_event(struct folio *folio)
>  		count_memcg_folio_events(folio, THP_SWPOUT, 1);
>  		count_vm_event(THP_SWPOUT);
>  	}
> -	count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPOUT);
> +
> +	if (folio_test_anon(folio))
> +		count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPOUT);

Do we need to distinguish anonymous swapout and non-anonymous swapout?
IMHO, we don't.  Just like we have done for small folio and THP.

If so, how about fix this in another direction?  That is, remove "ANON"
from mTHP swapout statistics?

>  #endif
>  	count_vm_events(PSWPOUT, folio_nr_pages(folio));
>  }

--
Best Regards,
Huang, Ying