Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp173885lqp; Wed, 22 May 2024 00:27:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVZxwM2vJtbocAOfHEFTvQU8r5W9L9fZLHWmeK9TOFyklzxsYceL+K+b77n4auQWBw9ZdelyqgQSXrYmHVd48qxsUwAVxal7+SlKybyYQ== X-Google-Smtp-Source: AGHT+IFJelaP9gDXEk9Z6IeLwqv5MEgNDjRIS1G1FxTCLKYJFvKepW16VGeaFCM8q+v2bqT29Z2U X-Received: by 2002:a05:6a20:9483:b0:1af:a512:2777 with SMTP id adf61e73a8af0-1b1f882e181mr1608188637.36.1716362869894; Wed, 22 May 2024 00:27:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716362869; cv=pass; d=google.com; s=arc-20160816; b=B6bz4zcd7AediOL6JWuuRtjw86FOcMeFozIHd3wmR6lUIx+zVOB9xXbQ6OFyn3WyUy iAo3dmnJSDUnSHpBogyfsWfdV8TIHG3U4Vgc1JFWQvfX86ZjLP67HkIPefMgght2Veur 5P6TW53CuCpNRpRIn84izzsm74FWrIoyB4MQk+I+R8NETFXBg+6hYDWu6pmjxatk5WMv vMC+qsC+sWbaqpgQ8t/Am0xnPZ3vFDdTVa3Ees+LI/R5ksefXqWuFkK9ClJ2CAMy0yE4 5hws1N+DeGAVf2DGHaclsrZgw+BjDwjatr57NzBst4anTesC1TiB4YHPNmJ2Qsg3mX4a 1qFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=xv45SAlhiZf2ZsL6evENIkICY0SDpBu3Jz4yPmFHg1U=; fh=gwIyIsr/r3998e0YLO0RiS9w2LkankwsLZGbTB28S6A=; b=xmeew4xYEXMPfv/v/dhWXlcBpRbyuPEbPJPzDjfrqQkY7p4NHGnqqleDDNsvOntYr5 Iwj2ZuvTqrYpb58c2+ld5R63tuRERF7cQdtVKGvmQRxy9WiIrH8U+SaTx8/41YFLy18L 8mK8QV9ewHL1v8KS3EERJIRpkW4Tx+zfvR30lhSJeqxBbFuzUESunhM/vTErosF5bs17 JsUj3EmcR7+jtVP1zBUWofxkZq/rAzw+Ny/DrPOiSB/wCAfnpHbmigD7djEBnNTFkdlr M1OJWsBOr1y5D2peuyyjIhHUUcg4o0ObEgLX4x/697UD/fBL2ta/5G4Vjd1rIXlHTCP0 J0Fw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iSnaWPeG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-185855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185855-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-64a10cc994fsi16078175a12.344.2024.05.22.00.27.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 00:27:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iSnaWPeG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-185855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185855-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8853028263E for ; Wed, 22 May 2024 07:27:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 27A157D088; Wed, 22 May 2024 07:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iSnaWPeG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3151D79B84; Wed, 22 May 2024 07:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716362858; cv=none; b=APWHu269APQs8mhYLtVT2/uviuiXYfwSBT0rg3A0EslmJ1kmSkjSwAislT4UCD/JXQMZsW8K06ESTnIMmdNXMndB0KzdDqu42uUZ9mI1eTvIGOhffZFv9OCPhewqobzM/iv58mwdo2gynM+T84/JarTfkov/DwxyCMyjAnwqOFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716362858; c=relaxed/simple; bh=Cj4rOccV5n4WWzyX8ZvH5KCQ+t6e8DjdPRMFd1Z3Wpc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QGPk9y/+HtOcDPoLKsi4HZXZ0erKuah4I9SHAnj0kBZOaEXa4lfsL70lsAGPxaJDb7Rj0y2tFbhuvbVGpry5V+ADBcaulhX1LhSqYMM4YBqnTZV9Echzehkwo6KC6bpPU2LcYyTe1xwskFi9Ecti+LYBIyTYwuR1nJOAN3UNitw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iSnaWPeG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E0C7C2BD11; Wed, 22 May 2024 07:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716362857; bh=Cj4rOccV5n4WWzyX8ZvH5KCQ+t6e8DjdPRMFd1Z3Wpc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iSnaWPeGfdlpKVyRlSkCnqcfgpIN8POcITDHdw+KjcoGvX+fwgPNx16i24H0ZtRFp nO7W0YJLJcPiIOckngG7aYPLqQD39qETSmP7WJlB+AWpSj2FvPtl/WzLWY8IRFlye/ zD1pnbi1eQ0HoBSnOsJ2dGW9idTJZGayGe5TiA3+Co7lYlaYW9+SDfecNFzCyGIRth pwEQIdxXZfgd04iedflMAYjl8rjapUo9u0vXKuK8GKeWVj7EG18wEt+52TZK8DwJE1 R7y+kCiqAIxiiVFsJpfUaGbq8TOC3ZfzYjUnMZpqb7RoVuGt6xwlWoeA0S7W31cPM7 qfynx4AIzwRMw== Message-ID: Date: Wed, 22 May 2024 09:27:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8650: Add hwlock to remoteproc To: Chris Lew , Bjorn Andersson , Baolin Wang , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Jonathan Corbet , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240516-hwspinlock-bust-v1-0-47a90a859238@quicinc.com> <20240516-hwspinlock-bust-v1-7-47a90a859238@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240516-hwspinlock-bust-v1-7-47a90a859238@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2024 00:58, Chris Lew wrote: > Add the hwlock property to remoteproc. This enables the remoteproc to > try and bust the smem hwspinlock if the remoteproc has crashed while > holding the hwspinlock. > > Signed-off-by: Chris Lew > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi > index 62a6e77730bc..a65a1679f003 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -2878,6 +2878,7 @@ remoteproc_mpss: remoteproc@4080000 { > > qcom,smem-states = <&smp2p_modem_out 0>; > qcom,smem-state-names = "stop"; > + hwlocks = <&tcsr_mutex 3>; lock #3 is used by smem, so this proves you are taking someone else's lock. I commented on this in the binding, but let's be specific: NAK, please carry: Nacked-by: Krzysztof Kozlowski Best regards, Krzysztof