Received-SPF: pass (google.com: domain of linux-kernel+bounces-185889-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f77b9385-5934-4afd-b255-adb5c9c5cef0@axis.com>
Date: Wed, 22 May 2024 09:57:47 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/3] net: phy: bcm54811: New link mode for BroadR-Reach
To: Andrew Lunn <andrew@lunn.ch>
Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
 hkallweit1@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240506144015.2409715-1-kamilh@axis.com>
 <20240506144015.2409715-2-kamilh@axis.com>
 <25798e60-d1cc-40ce-b081-80afdb182dd6@lunn.ch>
Content-Language: en-US
From: =?UTF-8?Q?Kamil_Hor=C3=A1k=2C_2N?= <kamilh@axis.com>
In-Reply-To: <25798e60-d1cc-40ce-b081-80afdb182dd6@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V1Z5SG1xcWRlazVXeTFmN3dYTG4wcE4xYWhCdDlrMmUrN3hsR2FUTUppOW1a?=
 =?utf-8?B?SVN2Y001eklUOS8ydjJ4QW9RMmhNU2tOWTdJdUdoZzEvVFhqR3JjOXlmY0Ux?=
 =?utf-8?B?S3BmS20wOHE3OWNhMTJLamNrVGpCUkszY2VnY254UUtUa2oxSDVRZXRlandB?=
 =?utf-8?B?dm1ITmdCeVJtd25ZZndxQ1QyYU0vUVoyQkJXNTNQcXZxYWFQS1B6bHR2K1Rm?=
 =?utf-8?B?Mk9jcHhhMVhDR0RlTGlrU2s4YVBvWlZvYkFPZWRMYWRkWDJQSlVOMnp0RkJD?=
 =?utf-8?B?bGY5OWpXY3pqVm5hOW9aMXlsQ0tqeVpYMExSVTlXeXB4Zzh4aEVqVDFhSVRi?=
 =?utf-8?B?ZXhrRWlZMXJ6K1VuZFFLNXY0d0FTMm9WN2Rta0tVdUZydDZQM3dKdnkrbHVV?=
 =?utf-8?B?VVZWMkdHcWczZ2doVUlTN0NFSlZWaVpUakpLM3JpQWJJUnVDT2ZOREdvREFO?=
 =?utf-8?B?bSs0bCt4RkVnRGZKbHVpRHBPZllqZlBxTk1ndnE5ZHJhcEhUbE1DallvRWhI?=
 =?utf-8?B?UDJlVk1LcVNkTXJCT3hiMG8zNWZYaG4vd1JyUkhGcGJLRzFTSjRMK3ByVmNx?=
 =?utf-8?B?THZubFYxNnk3QUdVVGtDZjZHanhQRlBjOGY1NmJTdTQxN1V4TjcrS3g5bGdJ?=
 =?utf-8?B?VjNzSVFPWjJLTExTNGoyMXVEbUQwTnhpNjV2S0JHUmNvMmJHWjZnNlNQT3Rm?=
 =?utf-8?B?UDFEWGRUZ1VuM0ZKQWpFaTdWWEJ5U2ZreFZLRS9WTW54MEgrOFZFcGxlcUJV?=
 =?utf-8?B?TkttTmd5NHQ1Tk1JRUlnSEczTDlBaDdOSks3OXdLVGJ4SEVUZ1MrMWFIckRT?=
 =?utf-8?B?UjlrejZSeUFaWStrZmE1T0ZCN3czZ3FFdzIxNWdRV250YVhxeEtDRW5NRSs4?=
 =?utf-8?B?bis0SHd1T2RNM2xkRlBaSnpaQXFnNUpOY3hOU1FLcEoyTWRUQTA1d1pDdktu?=
 =?utf-8?B?eHBlUHM4ZFVaaUpodEsrK0laZ2VHTG1keENKU2dvMm52ajk5bFFsV2lXYkg1?=
 =?utf-8?B?OGVwam5SS21qUyt0bVhkOXpaWkFXZVUyRk1zWDV3Q05BWFdwWnUwUFFoZUpN?=
 =?utf-8?B?RVNTTlN6aVFvTlBONlFIdXFKQ2JHNlpaOU40TEVIZzNnVUlGNG11UjNFV2R5?=
 =?utf-8?B?UUEvcGF1djNBaWNUZXBJcW5CQm1NWWpsSER5emtqa3JFVVhpc3Fpdkhoc3JD?=
 =?utf-8?B?U29hc211SlM1aUphOWlvUWxvSGlGRmw1elpqZ2NMaVhiUXRPUU9USkRYUktD?=
 =?utf-8?B?bjNKWVE4Mm1XU2NBTkVXcnNnaXhhbVQ4TlBqc1NhZUl3c1E4NUhjeWhWL21h?=
 =?utf-8?B?TWZ5MEJzbjJDbGNLN29UV1BRS1FqQnNMYk10TDJZbkdoRHh6WTk4aGJaN1dt?=
 =?utf-8?B?YkV1Wkh1ZXMwSWx0aldMSC9KNUxMZk0yUExLL21kaFhSdUNBeXA2NllpMmkr?=
 =?utf-8?B?TFhFb1h2WkNVY1pIZnUwUndldDZBOW4xRTJOek41dzZ2aEJXdmswdi9GamRt?=
 =?utf-8?B?ckY0WG03cERkOFN2YjRRaCtXS29xYWxBVWNqVlF1dW1DSlZ1RDFSTnUyMkNP?=
 =?utf-8?B?dk5YM3VkbXJMTlI4UVV5ZFYveEJFbDRBRjlNbEszS1lqbk9IZmsvT1RxUUlw?=
 =?utf-8?B?NEw2TEtGcTZNTzBJMG93WjhRSlV4VlJLOW1tMEtGeHNKSEJsWlVBWDVqYXZh?=
 =?utf-8?B?eDBiRi9DT3VkVUlMVW5Da1dQeXZTM1ZzL3RDdFVVQzRkUmpGOXNGeWVXWnVm?=
 =?utf-8?B?RFpnQ291Ly95QkpNQ1h2b0VNUlhuRmxiUUhKaHlpNmphNlZxRTJaSldVVXhF?=
 =?utf-8?B?K1pkakJubGd2RnhPdmY5VkR0N1J3MlJMQnRXRmR4ekN5VXlwS2J5cHNiOUVS?=
 =?utf-8?B?V0xmTkRoMURHcW9oY0tickRPWCtqSzJsY2l0dWxlbWNXYWhSU2hTeXdkSTFX?=
 =?utf-8?B?T1ZiY1lpN1gzcEcvb21RQ3RwRERQS0Q0c1YyVXlBUEQ5eUhsN2lLUFF6Q3FX?=
 =?utf-8?B?Q2dWL0ZFa1VCcDJrMWl0d3AzbC9KYjdhOUNFWFZCQTl5WmZ4T3Y5eE0yMGIx?=
 =?utf-8?B?Rlp6M3BXZkR1QS84eW1Jdm11MzZ3ZFZ1Tm93R1Vnem9HU09VQjNaTlgyRDRP?=
 =?utf-8?Q?Xm6S2wqTs3aoYKPWI8XUHW5nF?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c49924c-df95-476d-f64d-08dc7a34ed18
X-MS-Exchange-CrossTenant-AuthSource: VI1PR02MB10074.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 07:58:11.5456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gXdpieTtcXyI481bs6dMNu2CvEDmJo+xpU4oFHHVvESbLBHxDh0ACg/QCeiof0Ma
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR02MB11110


On 5/6/24 21:14, Andrew Lunn wrote:
> On Mon, May 06, 2024 at 04:40:13PM +0200, Kamil Horák - 2N wrote:
>> Introduce new link modes necessary for the BroadR-Reach mode on
>> bcm5481x PHY by Broadcom and new PHY tunable to choose between
>> normal (IEEE) ethernet and BroadR-Reach modes of the PHY.
> I would of split this into two patches. The reason being, we need the
> new link mode. But do we need the tunable? Why don't i just use the
> link mode to select it?
>
> ethtool -s eth42 advertise 1BR10

Tried to find a way to do the link mode selection this way but the 
advertised modes are only applicable when there is auto-negotiation, 
which is only partially the case of BCM54811: it only has 
auto-negotiation in IEEE mode.
Thus, to avoid choosing between BroadR-Reach and IEEE mode using the PHY 
Tunable, we would need something else and I am already running out of 
ideas...
Is there any other possibility?

In addition, we would have to check for incompatible link modes selected 
to advertise (cannot choose one BRR and one IEEE mode to advertise), or 
perhaps the BRR modes would take precedence, if there is any BRR mode 
selected to advertise, IEEE modes would be ignored.

>
> Once you have split this up, you can explain the link mode patch in a
> bit more detail. That because the name does not fit 802.3, the normal
> macros cannot be used, so everything needs to be hand crafted.
>
>      Andrew
>
> ---
> pw-bot: cr


Kamil