Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp189266lqp; Wed, 22 May 2024 01:08:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWEOzHlgv+cwkAZdXvLRbK8siUwrlpDZMZlKJFTIZxW6aC7/AwjwG2AssuFaKZVDnK0iq5HLkddS/GWBqYlHX69easvTcnvlbl1rtWsTA== X-Google-Smtp-Source: AGHT+IETuvDv/PFp/xNuuBYPWeKtwFQByqcGxLsvoXsE6qLmIEdr16gCyLeD1gDQRkGeAa/pNjHn X-Received: by 2002:a2e:b1c7:0:b0:2e0:3ad2:b371 with SMTP id 38308e7fff4ca-2e949490864mr8730181fa.25.1716365302351; Wed, 22 May 2024 01:08:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716365302; cv=pass; d=google.com; s=arc-20160816; b=Baqz6z6HOcgoDdyd88R5ab4Pmo8BMRDJF+8GZoIbBsz2GJIv2LZJI5xCDFjoLXrNxZ H8e4St0nGp1neC+hzOyPbIAlG+uaRKgQMPzJ8mTbe1IMP6cgKO+p3nIaiF3GjjQMtCIW GgI+Z+9jWT44lE04Abgngt5go1PsqAcbUxAgvc92918MSw/BmPQ1AN2KiqhasYmw9cby pxxXkcJff98GaPUTknuY4a9a44qp1Zyz6KQmjBh0unsSKPbR962X0kEwjOemrsvp2Z8q oWpq/sKihzOQksQJA7G5y0z4H66Sz+sI6ac9U8Rgo3EgNR91BLljHUnexv4X2293Z6wp Icxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:cc:to:from:date:dkim-signature:subject :dkim-signature; bh=09Rm6E2T3nXPkfUBf2UBfoCcjD58pN6xKwuBm2Gg+UQ=; fh=J4Rv3w0KKT920n5V7Tl0zQfA9CUn+g+QZ7FZSBi6ZOU=; b=kmfcWE43mN5lrMKWcviVPiePdltz9jZ2AOWuuVLaWYQGiVHFMGsREiRxJk6H65LxIQ bF3tXzoikAQdsI99SQGyb4PrTk2x4kIb/oHKne+saoDg/jeHO7OQk8aAFpBrJChazmOo 9RVXYYFB4LTtsmZwWWOVTt9Ld/yhvp7Mfmu+2X3sj5o22iLZJhthFkKjamskDefvnPfr h4iEQZ05g9do8IUX2AQvlj0ZHjJGv09BtW8sSHgnhlgObQgrCNMMNPjH1nqXkBMy5X1L OlZymkpqtmqx5FVJE5DuYoHaHLMGG43RISdBRHbrUWGGgstf3oxaQu67zS7MWQmDPZyM sfRw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=ClT7YY9+; dkim=temperror (no key for signature) header.i=@ew.tq-group.com header.s=dkim header.b=mSm9zJ5k; arc=pass (i=1 spf=pass spfdomain=ew.tq-group.com dkim=pass dkdomain=tq-group.com dmarc=pass fromdomain=ew.tq-group.com); spf=pass (google.com: domain of linux-kernel+bounces-185898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185898-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a1a0b2f77si1535681666b.256.2024.05.22.01.08.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 01:08:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=ClT7YY9+; dkim=temperror (no key for signature) header.i=@ew.tq-group.com header.s=dkim header.b=mSm9zJ5k; arc=pass (i=1 spf=pass spfdomain=ew.tq-group.com dkim=pass dkdomain=tq-group.com dmarc=pass fromdomain=ew.tq-group.com); spf=pass (google.com: domain of linux-kernel+bounces-185898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185898-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 11B9A1F214AF for ; Wed, 22 May 2024 08:08:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25E3B7F47F; Wed, 22 May 2024 08:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="ClT7YY9+"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="mSm9zJ5k" Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00FD770FB; Wed, 22 May 2024 08:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716365292; cv=none; b=IJ1K6+5NkY9N6erPaflo46lDhpPNMuAi/qNjzDSoWBqBBXf7soQ+8W0TQn4tdG5I/emJMYQ9rxi8JM8gptR/nIILZTuQd3MB/ptUcT26RiK3AUEIO9J3ZHN+nplt2Tv71VjFpmxBnwgNIzN3nkDUAIC/cGt8sKaBWIk7K352FqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716365292; c=relaxed/simple; bh=Kdse38lEoCzIDa5LclYD/dbJ1jVST51Gu79d5x8j6L8=; h=Subject:Date:From:To:Cc:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jmfTYzBxRzAnCFuu7k1rDh0nXr9oMFc2RY/1o8dqbK0I2MxyjEVUZ8RluaM3SuP2x8YeUPh0QFl4KjNey+JvbVggjC318j/QR9W6EhQ3xgvLZ4i7oKR+MBiwWmNHVbXo+8LLzvKjo6DAoNXVuzGkMFE+r2UFO/9qT1x56OUR1po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=ClT7YY9+; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=mSm9zJ5k reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1716365288; x=1747901288; h=date:from:to:cc:message-id:references:mime-version: content-transfer-encoding:in-reply-to:subject; bh=09Rm6E2T3nXPkfUBf2UBfoCcjD58pN6xKwuBm2Gg+UQ=; b=ClT7YY9+PpcQJOFEdOhAnluuMUrPEy/PnWkIocm6rmLF/p+fabSj68hW S6nSboTy/rmIZrOsXR5P/s7Q5ezdKgOvzQUwSFJrkrVN2T5ZBgn6gtV// WrKjt0d53IEaa0mbmnoLZt0cbTkMY8VR0ouyDG8/1tsCEghV5AYCxeDjz M0/A6vbJhNq176ss8MD/u0rKL7WvyynCrO2VGwKqEzKgD1wK2V5tHEKS7 gwf16cNlQVXg3DkRWZlt2TQWgnuFTcrr2Jgly9ISM7O2X7mUyyMOcA7Ka 85VgGWNdjJLUplz385FZTUr0QH0Fg+jCQRsHuCDWOTWHPgV0GjbYTlybQ w==; X-CSE-ConnectionGUID: gFwN2NN1Qu6aWgszxRa3eQ== X-CSE-MsgGUID: ECvYO5EFTpWPfIjRtpHF5A== X-IronPort-AV: E=Sophos;i="6.08,179,1712613600"; d="scan'208";a="37008058" Subject: Re: Re: [PATCH v3 7/8] can: mcp251xfd: add gpio functionality Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 22 May 2024 10:08:04 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4BB97161199; Wed, 22 May 2024 10:07:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1716365280; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=09Rm6E2T3nXPkfUBf2UBfoCcjD58pN6xKwuBm2Gg+UQ=; b=mSm9zJ5kHiPXGPpCpULTKHgD7+Ji00sP0rwSz7TsJQRWfz/uBhM5BC6s7YoDElISW6ONHo VljszIj7NUpTDWFNV1fEuuCAPvh/2KsOMOXY5OVh5t/GaPXkeVmtmBh7H0MHJeav51JW7H HN4JRTZcBab8aQ3mvsaLzuPx6yEGx1j7tcRGri7RUZyOflbBq2t3PiThpXW6D35dub/62c BT1ykPaIPSddqJsdzGVSEm80jcvStsKl1jdI8PovuAJn/cEpx7UF4vaDTmcEu7jm6NmS2p 940v2Pn8MrsM5vsbQkl5cnjUwNmm+giNBMOT/e7TsGkOJJNYRmBScroiyOcv5A== Date: Wed, 22 May 2024 10:07:52 +0200 From: Gregor Herburger To: Andrew Lunn Cc: Marc Kleine-Budde , Manivannan Sadhasivam , Thomas Kopp , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux@ew.tq-group.com Message-ID: References: <20240521-mcp251xfd-gpio-feature-v3-0-7f829fefefc2@ew.tq-group.com> <20240521-mcp251xfd-gpio-feature-v3-7-7f829fefefc2@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Tue, May 21, 2024 at 10:37:33PM +0200, Andrew Lunn wrote: > On Tue, May 21, 2024 at 03:04:57PM +0200, Gregor Herburger wrote: > > The mcp251xfd devices allow two pins to be configured as gpio. Add this > > functionality to driver. > > I have a basic understanding of GPIO drivers, which is probably more > than average for netdev reviewers. This code looks O.K. to me, but i > would prefer you run it by the GPIO maintainers, since that is there > domain of expertise. I don't think any are in Cc: Hi Andrew, ok i will resend with the GPIO maintainers in Cc. Best regards Gregor -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider https://www.tq-group.com/