Received-SPF: pass (google.com: domain of linux-kernel+bounces-185965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <12ccd0d3-e9a8-47b6-9564-7146d0a79f3a@intel.com>
Date: Wed, 22 May 2024 17:03:48 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 24/27] KVM: x86: Enable CET virtualization for VMX and
 advertise to userspace
To: Dave Hansen <dave.hansen@intel.com>
CC: Sean Christopherson <seanjc@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, <rick.p.edgecombe@intel.com>, <pbonzini@redhat.com>,
	<x86@kernel.org>, <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<peterz@infradead.org>, <chao.gao@intel.com>, <mlevitsk@redhat.com>,
	<john.allen@amd.com>
References: <20240219074733.122080-1-weijiang.yang@intel.com>
 <20240219074733.122080-25-weijiang.yang@intel.com>
 <ZjLNEPwXwPFJ5HJ3@google.com>
 <39b95ac6-f163-4461-93f3-eaa653ab1355@intel.com>
 <ZkYauRJBhaw9P1A_@google.com> <87r0e0ke8w.ffs@tglx>
 <ZkdpKiSyOwB3NwRD@google.com>
 <a170e420-efc3-47f9-b825-43229c999c0d@intel.com>
 <ZkuD1uglu5WFSoxR@google.com>
 <df5fa770-1f9b-4fa7-a20f-57f51b0d345b@intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <df5fa770-1f9b-4fa7-a20f-57f51b0d345b@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDgyYmNPNHZzeWlzVkVBTTk1ODUycUlhQ1Nxa0RiRTkrc01IYmkvTlh5RkRG?=
 =?utf-8?B?SU9QM1lmK0V3cHVoaksrMExvUkJUTWwrQWNPeHF3c2NzN3BITzRUeDNJZTh6?=
 =?utf-8?B?S3l0Y1c3ZzQ1YXp5UHM3YmVXeUd6Z2I5WFUxRVV2VnVLZ0NkZ1J4cDB3RVc5?=
 =?utf-8?B?R2QxRkdsbUpZbmIyQXdnV0pLTW5xK0Z2dVZpbFkzWjJKVG1zL3dDQW5MajhX?=
 =?utf-8?B?SlFKb05sTGFBWWNLVUhSVTE0bzBOeHpnRlkrVkI5NldsZ2pyNlVrcDdPLzhl?=
 =?utf-8?B?U2E4OHE2WWRoLzRLcWdjVEo5VFQ2WEpMV2tNN1QwQnRaaUR5S0hJdTIyTFRD?=
 =?utf-8?B?Ui9QMmJlR2g3cTdLNzlkalNkb1lyL0NsZmxjNGx5VXlCM1oxUlI2WUxNcnRN?=
 =?utf-8?B?UlQvVWhjbVh5RGtIa3lGTGxYOVhGRmIzQlREQUxuNGFiZk9kQ2FaSlkrTlZR?=
 =?utf-8?B?MXlsOGMwVnBwa1ZqcXFMenVEdGRoWkVGT2hxL3gzdjJ0MTlXYy95T1JIY25r?=
 =?utf-8?B?OHFxNkxYaForUWYycy9PWnpEbFAxcHNoN1hkc1FzWmVQNFIxQ1Nnd29UdnAz?=
 =?utf-8?B?QzArNmFBS3k1RWdmK1c3cjRlMzdmVS90bm5PWmJJbHIzWEQ1WVdFb256aFE2?=
 =?utf-8?B?US9mSGhobTVvYTV3WTdOVmxqeGVRRlFncVNoak02Z0pydkExZlBMaFJudDMr?=
 =?utf-8?B?UExSUE9QRFVuZFFSL0pZRFMrdGNMbVFibWFqNWlSUjNMQ3d1NG5rTUZLVnpt?=
 =?utf-8?B?ZUMvRnVPWjlnVlk3VjRUdHdaTEd0bkVlKytza1hLSS93cDhFL3NVdi9BUHRV?=
 =?utf-8?B?TDFsZEE2anFjdEs1SmN1UkMzZ1VwSG91UW82dGI5QlJ1R3JwRVNsYklKMFJv?=
 =?utf-8?B?amlVRXdSS2hBdUJFVzJKVzZmdXZ6VCsxemtqTW5pbXc1OEd4QytIbE1JQjRC?=
 =?utf-8?B?ZXovbDQrRE5DdVVlR0lKVHQ0UVhmMVlkUUpJeWhjSDhBc1RQTGVtWlR5VmE0?=
 =?utf-8?B?WVhFMEl0WmpUWmZ1RGpNcW9QWTFFZWErdmRQVVVjRWhOdEhURStWbnI1WDVN?=
 =?utf-8?B?YVlLRFVNWDdQZmFLbHFBUEIzWkI3TVRxcHdmOUZqU0JBYmc4d05vN2ZyVEtp?=
 =?utf-8?B?OHFpdm5BSW16ZGx3L0hzY2JUamE4YkhDam44M0ZENGNtUkJBOXlXWXBCS0FF?=
 =?utf-8?B?ZG1MS3czeGhObVZuS3lWcHByajJFQUdXRjk1aEMxeW1rZjYybGhENGVjb3JL?=
 =?utf-8?B?L3UzYmtWREc4U2xVQUdRMXhBRVdoZHNkLytNRnVjOWJkSDUrUWlrcm1DUXJq?=
 =?utf-8?B?ckdCaGVRdnV3amxwSGZrYXpVcVYwNWxJOUZONVhJWnYwWThVTkJqNS9JN3Uz?=
 =?utf-8?B?Q3h6REV1KzJnM3doOFpxbEVYSWtVQm1Rdkw3Z0wra0FuZ2tLb3hVUC96RWNh?=
 =?utf-8?B?UTh3SHJRYS9zY0ttdzNOYXRPZE1zN1ZZR21MOHhDVGNidTNmVCs5VHhGbi83?=
 =?utf-8?B?UXBKdjZodHU0MUZiaCtPZjg0Mk1IK2VHNUJLTjdlQlV5SlBlMUNoc0Q1andT?=
 =?utf-8?B?Y2JPNXg2eEp3MkZiT3lyUDNPN2lVVVFRcS9oRG8vK2V2bVhpWHgzTWhGL01E?=
 =?utf-8?B?UXFHeDR1anBFTkE4VmhHdSs5K3FJWkpibkphNnpZSkdNb3VwQ0gvdUhTYW5i?=
 =?utf-8?B?bDBVQ0p3dXVLcFBEVVBRaUZsaEoraDRTTGhadDZGRlJUZXV6OXpHV0lGZDAz?=
 =?utf-8?B?RzhsdmxHc2haeWZweTY1RE1CRkozd0Rlb0N3b3ZIZDdwRzJ0QlljRzVFM1Jv?=
 =?utf-8?B?RVB3UUN5enZVYTQ5MGw5ODhuMktWLzEyZzFsZVBxazBXWDA3akd6NDh0cEtn?=
 =?utf-8?B?S3lwbStSTWtYZmZBU290ZEFEYjUrRW01UmdiZlNjYUVoV2g0ck5SSzZ3NUJz?=
 =?utf-8?B?RFhLSmhWZ2pWcjlrZDd6R0owTGg4dHk1cUdlUW1MSHVDb2JHdGVSN0pKSkdL?=
 =?utf-8?B?NUxIYUp4RUlWYW1udE16UkQxS3YxMU1xdER5bGlQNXJSblFpL0tCNmxKTEZN?=
 =?utf-8?B?M29MTlpWclo3RDVuRFRNSVhtK2hvbFp2VjhZMzUvTCtvelFzaUhjbm9CaThU?=
 =?utf-8?B?NFJaZTlEN2dnUjlaUTBrNzRmMm9jSzd1M2huNzlKaTVnVzBFT3ZWSmQ4dHRS?=
 =?utf-8?B?NWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 04a4632e-1c7e-43e8-9bc1-08dc7a3e1dd9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 09:03:59.0582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yWuUHtdw9LzhPwvh9hGWdqJM+450sxCHu3QequbVLfuYWBjP2M3pTWk1N6B5sQ4LouILnYCwinpWjcTJpgzPzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5893
X-OriginatorOrg: intel.com

On 5/21/2024 1:15 AM, Dave Hansen wrote:
> On 5/20/24 10:09, Sean Christopherson wrote:
>>> IIUC, this series tries to tie IBT to SHSTK feature, i.e., IBT cannot be
>>> exposed as an independent feature to guest without exposing SHSTK at the same
>>> time. If it is, then below patch is not needed anymore:
>>> https://lore.kernel.org/all/20240219074733.122080-3-weijiang.yang@intel.com/
>> That's a question for the x86 maintainers.  Specifically, do they want to allow
>> enabling XFEATURE_CET_USER even if userspace shadow stack support is disabled.
> I like the sound of "below patch is not needed anymore".
>
> Unless removing the patch causes permanent issues or results in
> something that's not functional, I say: jettison it with glee. If it's
> that important, it can be considered on its own merits separately.
I guess the existing dependency there is due to the fact that only user SHSTK is landed and there's
possibly no such kind of odd bare metal platform.

Side topic:  would it be reasonable to enforce IBT dependency on XFEATURE_CET_USER when *user* IBT
enabling patches are landing in kernel? Then guest kernel can play with user IBT alone if VMM
userspace just wants to enable IBT for guest. Or when SHSTK is disabled for whatever reason.