Received-SPF: pass (google.com: domain of linux-kernel+bounces-185998-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com>
Date: Wed, 22 May 2024 17:38:46 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters
To: David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org
Cc: willy@infradead.org, ying.huang@intel.com, 21cnbao@gmail.com,
 ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
References: <0e2a6f232e7579a2e4407ecf075531980d97f286.1716367360.git.baolin.wang@linux.alibaba.com>
 <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com>
From: Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2024/5/22 16:58, David Hildenbrand wrote:
> On 22.05.24 10:51, Baolin Wang wrote:
>> The mTHP swap related counters: 'anon_swpout' and 
>> 'anon_swpout_fallback' are
>> confusing with an 'anon_' prefix, since the shmem can swap out 
>> non-anonymous
>> pages. So drop the 'anon_' prefix to keep consistent with the old swap 
>> counter
>> names.
>>
>> Suggested-by: "Huang, Ying" <ying.huang@intel.com>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> ---
> 
> Am I daydreaming or did we add the anon_ for a reason and discussed the 
> interaction with shmem? At least I remember some discussion around that.

Do you mean the shmem mTHP allocation counters in previous 
discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can 
not find previous discussions that provided a reason for adding the 
‘anon_’ prefix. Barry, any comments? Thanks.

[1] 
https://lore.kernel.org/all/05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@linux.alibaba.com/