Received-SPF: pass (google.com: domain of linux-kernel+bounces-186034-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240521211036.227674-1-zaidal@os.amperecomputing.com> <20240521211036.227674-2-zaidal@os.amperecomputing.com>
In-Reply-To: <20240521211036.227674-2-zaidal@os.amperecomputing.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 22 May 2024 12:10:07 +0200
Message-ID: <CAJZ5v0iEufuZugRT3ZPn=wk49E8_xACsOJX4OWPpiv0HybGKNA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 1/8] ACPICA: Update values to hex to follow ACPI specs
To: Zaid Alali <zaidal@os.amperecomputing.com>
Cc: rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, 
	tony.luck@intel.com, bp@alien8.de, robert.moore@intel.com, 
	Jonathan.Cameron@huawei.com, Benjamin.Cheatham@amd.com, 
	dan.j.williams@intel.com, arnd@arndb.de, Avadhut.Naik@amd.com, 
	u.kleine-koenig@pengutronix.de, john.allen@amd.com, 
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, 
	acpica-devel@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 21, 2024 at 11:11=E2=80=AFPM Zaid Alali
<zaidal@os.amperecomputing.com> wrote:
>
> ACPI specs(1) define Error Injection Actions in hex values.
> This commit intends to update values from decimal to hex to be
> consistent with ACPI specs. This commit and the following one are
> not to be merged and will come form ACPICA project(2).
>
> (1) https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html
> (2) https://lore.kernel.org/acpica-devel/20240514184150.6285-1-zaidal@os.=
amperecomputing.com/
>
> Signed-off-by: Zaid Alali <zaidal@os.amperecomputing.com>

In order to modify the ACPICA code in the Linux kernel, you need to
submit a corresponding pull request to the upstream ACPICA project on
GitHub.  Once that pull request has been merged, please send the Linux
patch with a Link: tag pointing to the upstream ACPICA pull request
corresponding to it.

Thanks!

> ---
>  include/acpi/actbl1.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index 841ef9f22795..b321d481b09a 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -1017,18 +1017,18 @@ struct acpi_einj_entry {
>  /* Values for Action field above */
>
>  enum acpi_einj_actions {
> -       ACPI_EINJ_BEGIN_OPERATION =3D 0,
> -       ACPI_EINJ_GET_TRIGGER_TABLE =3D 1,
> -       ACPI_EINJ_SET_ERROR_TYPE =3D 2,
> -       ACPI_EINJ_GET_ERROR_TYPE =3D 3,
> -       ACPI_EINJ_END_OPERATION =3D 4,
> -       ACPI_EINJ_EXECUTE_OPERATION =3D 5,
> -       ACPI_EINJ_CHECK_BUSY_STATUS =3D 6,
> -       ACPI_EINJ_GET_COMMAND_STATUS =3D 7,
> -       ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS =3D 8,
> -       ACPI_EINJ_GET_EXECUTE_TIMINGS =3D 9,
> -       ACPI_EINJ_ACTION_RESERVED =3D 10, /* 10 and greater are reserved =
*/
> -       ACPI_EINJ_TRIGGER_ERROR =3D 0xFF  /* Except for this value */
> +       ACPI_EINJ_BEGIN_OPERATION =3D             0x0,
> +       ACPI_EINJ_GET_TRIGGER_TABLE =3D           0x1,
> +       ACPI_EINJ_SET_ERROR_TYPE =3D              0x2,
> +       ACPI_EINJ_GET_ERROR_TYPE =3D              0x3,
> +       ACPI_EINJ_END_OPERATION =3D               0x4,
> +       ACPI_EINJ_EXECUTE_OPERATION =3D           0x5,
> +       ACPI_EINJ_CHECK_BUSY_STATUS =3D           0x6,
> +       ACPI_EINJ_GET_COMMAND_STATUS =3D          0x7,
> +       ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS =3D 0x8,
> +       ACPI_EINJ_GET_EXECUTE_TIMINGS =3D         0x9,
> +       ACPI_EINJ_ACTION_RESERVED =3D             0xA,    /* 0xA and grea=
ter are reserved */
> +       ACPI_EINJ_TRIGGER_ERROR =3D               0xFF    /* Except for t=
his value */
>  };
>
>  /* Values for Instruction field above */
> --
> 2.34.1
>