Received-SPF: pass (google.com: domain of linux-kernel+bounces-186090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <40594542-ac60-0ff7-8474-a93f678a99be@quicinc.com>
Date: Wed, 22 May 2024 16:26:41 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 2/7] ASoC: codecs: wcd937x-sdw: add SoundWire driver
Content-Language: en-US
To: Mark Brown <broonie@kernel.org>
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami
	<bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Rob Herring
	<robh@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Conor Dooley
	<conor+dt@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai
	<tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-sound@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_rohkumar@quicinc.com>, <quic_pkumpatl@quicinc.com>
References: <20240516044801.1061838-1-quic_mohs@quicinc.com>
 <20240516044801.1061838-3-quic_mohs@quicinc.com>
 <91f581ef-58ea-4b98-80e2-dd9b14a61c60@sirena.org.uk>
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
In-Reply-To: <91f581ef-58ea-4b98-80e2-dd9b14a61c60@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 5/16/2024 5:17 PM, Mark Brown wrote:
> On Thu, May 16, 2024 at 10:17:56AM +0530, Mohammad Rafi Shaik wrote:
> 
>> +static const struct reg_default wcd937x_defaults[] = {
> 
>> +	{ WCD937X_DIGITAL_EFUSE_REG_0,				0x00 },
>> +	{ WCD937X_DIGITAL_EFUSE_REG_1,				0xff },
>> +	{ WCD937X_DIGITAL_EFUSE_REG_2,				0xff },
>> +	{ WCD937X_DIGITAL_EFUSE_REG_3,				0xff },
> 
> Given the name I'd expect these to vary per device so not have default
> values.  In general ID, status or volatile registers probably shouldn't
> have defaults since they should be read from the device.
> 

Thanks for the review,

Will cleanup those.
>> +static bool wcd937x_readonly_register(struct device *dev, unsigned int reg)
>> +{
>> +	switch (reg) {
> 
>> +	case WCD937X_DIGITAL_CHIP_ID0:
>> +	case WCD937X_DIGITAL_CHIP_ID1:
>> +	case WCD937X_DIGITAL_CHIP_ID2:
>> +	case WCD937X_DIGITAL_CHIP_ID3:
> 
>> +	case WCD937X_DIGITAL_EFUSE_REG_0:
>> +	case WCD937X_DIGITAL_EFUSE_REG_1:
>> +	case WCD937X_DIGITAL_EFUSE_REG_2:
> 
>> +	.readable_reg = wcd937x_readable_register,
>> +	.writeable_reg = wcd937x_rdwr_register,
>> +	.volatile_reg = wcd937x_readonly_register,
> 
> It's not a bug per se since things will work but you should probably
> have separate volatile and read only checks, things like the ID and
> efuse registers are read only but they shouldn't vary at runtime so
> could be cached and not volatile.

ACK,

Will cleanup and improve.

Thanks & Regards,
Rafi.