Received-SPF: pass (google.com: domain of linux-kernel+bounces-186132-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 22 May 2024 13:23:45 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: huanglei814 <huanglei814@163.com>
Cc: jikos@kernel.org, bentiss@kernel.org, linux-usb@vger.kernel.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	huanglei <huanglei@kylinos.cn>
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse
Message-ID: <2024052218-hull-urology-9ec9@gregkh>
References: <20240522092257.19373-1-huanglei814@163.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240522092257.19373-1-huanglei814@163.com>

On Wed, May 22, 2024 at 05:22:57PM +0800, huanglei814 wrote:
> From: huanglei <huanglei@kylinos.cn>
> 
> This patch enables remote wakeup by default for USB mouse
> devices.

That is not a good idea.  Please see the mailing list archives for the
past 20+ years for why this is the way it is.

If you know your device can support this, please set it in userspace,
but we can not change the default value at this point in time, sorry.

> Mouse can used to be wakeup devices, but the correct
> place to enable it depends on the device's bus; no single
> approach will work for all mouse devices.  In particular, this
> covers only USB mouse (and then only those supporting the boot
> protocol).

And that is really not a wise choice, boot protocol mice have no
requirement that they support remote wakeup.  So restricting it like
this really will not help, sorry.

Again, do this in userspace, that's why the interface is there to do so.

greg k-h