Received-SPF: pass (google.com: domain of linux-kernel+bounces-186257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fc29f19a1ecbceef64bf219a9441eb5b9f09503a.camel@gmail.com>
Subject: Re: [PATCH 1/2] drivers: hwmon: max31827: Add PEC support
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Radu Sabau <radu.sabau@analog.com>, Jean Delvare <jdelvare@suse.com>, 
 Guenter Roeck <linux@roeck-us.net>, Jonathan Corbet <corbet@lwn.net>,
 linux-hwmon@vger.kernel.org,  linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org
Date: Wed, 22 May 2024 15:08:51 +0200
In-Reply-To: <20240522123923.22320-2-radu.sabau@analog.com>
References: <20240522123923.22320-1-radu.sabau@analog.com>
	 <20240522123923.22320-2-radu.sabau@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-05-22 at 15:39 +0300, Radu Sabau wrote:
> Add support for PEC by attaching PEC attribute to the i2c device.
> Add pec_store and pec_show function for accesing the "pec" file.
>=20
> Signed-off-by: Radu Sabau <radu.sabau@analog.com>
> ---
> =C2=A0Documentation/hwmon/max31827.rst | 13 ++++-
> =C2=A0drivers/hwmon/max31827.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 | 95 +++++++++++++++++++++++++++-----
> =C2=A02 files changed, 92 insertions(+), 16 deletions(-)
>=20
> diff --git a/Documentation/hwmon/max31827.rst b/Documentation/hwmon/max31=
827.rst
> index 44ab9dc064cb..9c11a9518c67 100644
> --- a/Documentation/hwmon/max31827.rst
> +++ b/Documentation/hwmon/max31827.rst
> @@ -131,7 +131,14 @@ The Fault Queue bits select how many consecutive tem=
perature
> faults must occur
> =C2=A0before overtemperature or undertemperature faults are indicated in =
the
> =C2=A0corresponding status bits.
> =C2=A0
> -Notes
> ------
> +PEC Support
> +-----------
> +
> +When reading a register value, the PEC byte is computed and sent by the =
chip.
> +
> +PEC on word data transaction respresents a signifcant increase in bandwi=
tdh
> +usage (+33% for both write and reads) in normal conditions.
> =C2=A0
> -PEC is not implemented.
> +Since this operation implies there will be an extra delay to each
> +transaction, PEC can be disabled or enabled through sysfs.
> +Just write 1=C2=A0 to the "pec" file for enabling PEC and 0 for disablin=
g it.
> diff --git a/drivers/hwmon/max31827.c b/drivers/hwmon/max31827.c
> index f8a13b30f100..16a1524413db 100644
> --- a/drivers/hwmon/max31827.c
> +++ b/drivers/hwmon/max31827.c
> @@ -11,19 +11,20 @@
> =C2=A0#include <linux/hwmon.h>
> =C2=A0#include <linux/i2c.h>
> =C2=A0#include <linux/mutex.h>
> -#include <linux/of_device.h>
> =C2=A0#include <linux/regmap.h>
> =C2=A0#include <linux/regulator/consumer.h>
> +#include <linux/of_device.h>
> =C2=A0

Looks like unrelated change...
> -#define MAX31827_T_REG			0x0
> +#define MAX31827_T_REG	0x0
> =C2=A0#define MAX31827_CONFIGURATION_REG	0x2
> -#define MAX31827_TH_REG			0x4
> -#define MAX31827_TL_REG			0x6
> -#define MAX31827_TH_HYST_REG		0x8
> -#define MAX31827_TL_HYST_REG		0xA
> +#define MAX31827_TH_REG	0x4
> +#define MAX31827_TL_REG 0x6
> +#define MAX31827_TH_HYST_REG	0x8
> +#define MAX31827_TL_HYST_REG	0xA

ditto for all the other places

..

> =C2=A0
> +static ssize_t pec_show(struct device *dev, struct device_attribute *dev=
attr,
> +			char *buf)
> +{
> +	struct i2c_client *client =3D to_i2c_client(dev);
> +
> +	return scnprintf(buf, PAGE_SIZE, "%d\n", !!(client->flags &
> I2C_CLIENT_PEC));

sysfs_emit()

> +}
> +
> +static ssize_t pec_store(struct device *dev, struct device_attribute *de=
vattr,
> +			 const char *buf, size_t count)
> +{
> +	struct max31827_state *st =3D dev_get_drvdata(dev);
> +	struct i2c_client *client =3D to_i2c_client(dev);
> +	unsigned int val, val2;
> +	int err;
> +
> +	err =3D kstrtouint(buf, 10, &val);
> +	if (err < 0)
> +		return err;
> +
> +	val2 =3D FIELD_PREP(MAX31827_CONFIGURATION_PEC_EN_MASK, !!val);
> +

Why not just val?

> +	switch (val) {
> +	case 0:
> +		err =3D regmap_update_bits(st->regmap, MAX31827_CONFIGURATION_REG,
> +					 MAX31827_CONFIGURATION_PEC_EN_MASK,
> +					 val2);
> +		if (err)
> +			return err;
> +
> +		client->flags &=3D ~I2C_CLIENT_PEC;
> +		break;
> +	case 1:
> +		err =3D regmap_update_bits(st->regmap, MAX31827_CONFIGURATION_REG,
> +					 MAX31827_CONFIGURATION_PEC_EN_MASK,
> +					 val2);
> +		if (err)
> +			return err;
> +
> +		client->flags |=3D I2C_CLIENT_PEC;
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return count;
> +}
> +static DEVICE_ATTR_RW(pec);
> +
> =C2=A0static struct attribute *max31827_attrs[] =3D {
> =C2=A0	&dev_attr_temp1_resolution.attr,
> +	&dev_attr_pec.attr,

Do we need it in here??


- Nuno S=C3=A1