Received-SPF: pass (google.com: domain of linux-kernel+bounces-186259-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240521065107.30371-1-wenst@chromium.org>
In-Reply-To: <20240521065107.30371-1-wenst@chromium.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Wed, 22 May 2024 22:08:47 +0900
Message-ID: <CAK7LNAQC+z51RcaDKqFWs7AmFJvwvpZJ2NO2eKTbPbP-BGuAkw@mail.gmail.com>
Subject: Re: [PATCH 0/2] scripts/make_fit fix and disabled compression for DTBs
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Simon Glass <sjg@chromium.org>, Nathan Chancellor <nathan@kernel.org>, 
	Nicolas Schier <nicolas@fjasle.eu>, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 21, 2024 at 3:51=E2=80=AFPM Chen-Yu Tsai <wenst@chromium.org> w=
rote:
>
> Hi folks,
>
> Here are a couple changes for the FIT image packing script. While
> unreleated, they are sent together because the change context overlaps.
>
> The first patch drops the compatible string property from the fdt image
> nodes. According to the FIT image spec, the compatible string in the
> (fdt/kernel) image node is used to specify special loading mechanisms,
> and is _not_ for identifying the DTB.

This makes sense.


> The second patch adds an option that disables compression for _just_ the
> included DTBs. This is needed for RK3399 and MT8173 based Chromebooks,
> whose firmware does not support decompressing DTBs, but does need kernel
> image compression to fit the image within their relatively small image
> size of 32 MiB.


Any platform that wants to use scripts/make_fit.py
must implement decompression of DTBs.
(or does not compress anything)

Otherwise, RK3399 and MT8173 cannot use this script.

I will not add any weird knob to it.


>
> Please take a look.
>
>
> Thanks
> ChenYu
>
>
> Chen-Yu Tsai (2):
>   scripts/make_fit: Drop fdt image entry compatible string
>   scripts/make_fit: Add option to disable compression for DTBs
>
>  scripts/Makefile.lib |  1 +
>  scripts/make_fit.py  | 14 +++++++++++---
>  2 files changed, 12 insertions(+), 3 deletions(-)
>
> --
> 2.45.0.215.g3402c0e53f-goog
>
>


--=20
Best Regards
Masahiro Yamada