Received-SPF: pass (google.com: domain of linux-kernel+bounces-186282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <9098d5912a87cbfaaf0de2fdd041d0c5ac1af1fa.camel@gmail.com>
Subject: Re: [PATCH 1/3] tpm: Disable TCG_TPM2_HMAC by default
From: Vitor Soares <ivitro@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, James Bottomley
	 <James.Bottomley@HansenPartnership.com>, linux-integrity@vger.kernel.org
Cc: keyrings@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>, Jason
 Gunthorpe <jgg@ziepe.ca>, Mimi Zohar <zohar@linux.ibm.com>, David Howells
 <dhowells@redhat.com>, Paul Moore <paul@paul-moore.com>, James Morris
 <jmorris@namei.org>, "Serge E. Hallyn" <serge@hallyn.com>, 
 linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Date: Wed, 22 May 2024 14:31:20 +0100
In-Reply-To: <56e52200bd9ede6bcdcc907d24bd4a3e0dddd24f.camel@gmail.com>
References: <20240519235122.3380-1-jarkko@kernel.org>
	 <20240519235122.3380-2-jarkko@kernel.org>
	 <850862655008f84ef0b6ecd99750e8dc395304d1.camel@gmail.com>
	 <D1F4V8NMSUNZ.2VCTEKHZZ0LB@kernel.org>
	 <17dc838120b56ce342c34611596c7b46dcd9ab5a.camel@HansenPartnership.com>
	 <2dd8d49516ec9c7cb8c1182b5b8537b1e82d7067.camel@gmail.com>
	 <D1G5O2Z86E4W.2DHG4QZE2W2JG@kernel.org>
	 <56e52200bd9ede6bcdcc907d24bd4a3e0dddd24f.camel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-05-22 at 14:17 +0100, Vitor Soares wrote:
> On Wed, 2024-05-22 at 15:01 +0300, Jarkko Sakkinen wrote:
> > On Wed May 22, 2024 at 11:18 AM EEST, Vitor Soares wrote:
> > > On Tue, 2024-05-21 at 08:33 -0400, James Bottomley wrote:
> > > > On Tue, 2024-05-21 at 10:10 +0300, Jarkko Sakkinen wrote:
> > > > > This benchmark could be done in user space using /dev/tpm0.
> > > >=20
> > > > Let's actually try that.=C2=A0 If you have the ibmtss installed, th=
e command
> > > > to time primary key generation from userspace on your tpm is
> > > >=20
> > > > time tsscreateprimary -hi n -ecc nistp256
> > > >=20
> > > >=20
> > > > And just for chuckles and grins, try it in the owner hierarchy as w=
ell
> > > > (sometimes slow TPMs cache this)
> > > >=20
> > > > time tsscreateprimary -hi o -ecc nistp256
> > > >=20
> > > > And if you have tpm2 tools, the above commands should be:
> > > >=20
> > > > time tpm2_createprimary -C n -G ecc256
> > > > time tpm2_createprimary -C o -G ecc256
> > > >=20
> > > > James
> > > >=20
> > > >=20
> > >=20
> > > Testing on an arm64 platform I get the following results.
> >=20
> > OK, appreciate these results. I try to get mine this week, if I can
> > allocate some bandwidth but latest early next week. The Intel CPU
> > I'll be testing is Intel Celeron J4025:
> >=20
> > https://www.intel.com/content/www/us/en/products/sku/197307/intel-celer=
on-processor-j4025-4m-cache-up-to-2-90-ghz/specifications.html
> >=20
> > So if things work reasonably fast with this, then I think we can
> > enable the feature at least on X86_64 by default, and make it
> > opt-in for other arch's.
> >=20
> > I sent already this patch but holding with PR up until rc1 is
> > out so that there is some window to act:
> >=20
> > https://lore.kernel.org/linux-integrity/20240521130921.15028-1-jarkko@k=
ernel.org/
> >=20
> > If I need to send an updated patch ("default X86_64") and rip
> > transcrip from below results.
> >=20
> > But to do that correctly I'd need to know at least:
> >=20
> > 1. What is the aarch64 platform you are using?
>=20
> I was testing this on the Toradex Verdin iMX8MM SoM.
>=20
> > 2. What kind of TPM you are using and how is it connect?
>=20
> TPM device is the ATTPM20P connect through the SPI at speed of 36 MHz.
> The bus is shared with a CAN controller (MCP251xFD), so both mues work
> together.
>=20
> The dts looks like:
> tpm1: tpm@1 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "atmel,attpm20p=
", "tcg,tpm_tis-spi";
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupts-extended =3D <&gpio=
1 7 IRQ_TYPE_LEVEL_LOW>;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-0 =3D <&pinctrl_can2_i=
nt>;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-names =3D "default";
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <1>;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spi-max-frequency =3D <3600000=
0>;
> };
>=20
> Regards,
> Vitor Soares

For the sake of clarity, the timing tests were done without CAN enabled.

>=20
> >=20
> > Obviously if I make this decision, I'll put you as "Reported-by".
> >=20
> >=20
>=20