Received-SPF: pass (google.com: domain of linux-kernel+bounces-186289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <666e36b7-5379-46ef-a16b-00ec499fb42c@amd.com>
Date: Wed, 22 May 2024 08:36:54 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs
To: =?UTF-8?Q?Rino_Andr=C3=A9_Johnsen?= <rinoandrejohnsen@gmail.com>,
 Simon Ser <contact@emersion.fr>
Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 alexander.deucher@amd.com, Harry Wentland <harry.wentland@amd.com>,
 Leo Li <sunpeng.li@amd.com>, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Aurabindo Pillai
 <aurabindo.pillai@amd.com>, Hersen Wu <hersenxs.wu@amd.com>,
 Hamza Mahfooz <hamza.mahfooz@amd.com>, Wayne Lin <wayne.lin@amd.com>,
 Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
 Fangzhi Zuo <jerry.zuo@amd.com>, Tom Chung <chiahsuan.chung@amd.com>,
 Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <fa885eca-d7e6-415a-8a08-9103b002c6bb@amd.com>
 <20240521051140.30509-1-rinoandrejohnsen@gmail.com>
 <17782a6e-db84-4c20-874a-342b9655ffc5@amd.com>
 <CAACkh=-B-jH6g7KY7Nn_7Y_+gHPQ7G5Z5AZ0=a=_ifjcmsorcw@mail.gmail.com>
 <86410711-9b88-448c-9148-109f81b1ca55@amd.com>
 <CAACkh=9hY7eg_uuH7Psm=XJfSzwQTvzs8bvOXQ=wwkMPrC44SA@mail.gmail.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <CAACkh=9hY7eg_uuH7Psm=XJfSzwQTvzs8bvOXQ=wwkMPrC44SA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dnhackFEenJLTmdvWE9kWEZzMHhERzd1VzhLdVVCazBCN21ZWlB1NldUTmZV?=
 =?utf-8?B?NUFVNm1LS0V6VEVNQlRsZjY2TlRtZVlpa3ZZZ0k5M0grTW9BZVp5b054RHN6?=
 =?utf-8?B?MEF1N1RNYlo0L1lQS0dXeFZTdlp2eGFsK2tKYXpIYlVzSmJVUHV6c0dkK3Zv?=
 =?utf-8?B?K2NEd05YRkJTZWhNUE5SRkFjLzZYVGpoK3UyVXFoOWY0eURyMGd6YTFkRFRr?=
 =?utf-8?B?SW53WWJsNG9sRXlCU28wSGx0dExRa0d5em9YcFBGWm1hQVJXd3c0MGlYM2k1?=
 =?utf-8?B?VUZzMDZ6WUgxd2RpMkFKT3BjSlRDZlkrbFVSMjBBekgvNFRMRkVuYng1Rjlu?=
 =?utf-8?B?Q2hna2NWUmJZVkJtM3I4RHl2RmpxVXlUNjNnYVJUbWgxMENWNG5Yd0NaZXVi?=
 =?utf-8?B?aFVaZ0FWbVRGampPejF5VTRxdkdCUWlhQ0JkNHVoZWl0dHJWbXRWYmJsd2h2?=
 =?utf-8?B?bDhaUWNxOTJlTVBNclFtSmNXTkUwM3kvWHJ2T3lmdzNrK2hxS1JEVDFjVWo1?=
 =?utf-8?B?U1grRTFRZjBaZGoyM3o2dEJrVnFGZ0VwWWllei9qUXoyeXJyUmxRZVFodFdl?=
 =?utf-8?B?RzdjbUhpNUNpdE5QTDVzdUUyOTcrWnhKZGVVZnBCU0ZCSE1NQ203Z2h0NUo1?=
 =?utf-8?B?OGtzQ2tWei9xYjVuTGhrY3o1azBaeHdHaHlKam8xVTBKQ3lXd3B2YndDWkRP?=
 =?utf-8?B?Nmd1Ri9weUNRNWc5L0hyTVNpVjluS2JBdlJUZGY2Q0dBOVRHUGtSZ1BvRStz?=
 =?utf-8?B?S29Ec25GY1RCd2IyYnVDUGMveHdxbWJRSlR4Mkl2V2s0dzNWTUJSNGVzbjFk?=
 =?utf-8?B?ZGZCVi9ualhNR3hzcnYwcUlRMWtndmlpZ0Zzc2dpQmR0OGZZZFp1K1VrWXFX?=
 =?utf-8?B?WURFcll6T29NWWxleGUvdTJIY2JnVTFnL2ZhSjlURGZsdWRzNDlGQWU2MzRN?=
 =?utf-8?B?eWhUSmJjSkxwUHd2akRjVGJHcjVVWG81T242bnFMeDZxakNvUU1VMk1rTHla?=
 =?utf-8?B?bStBM1JIeXgySzZKbGNna3lhTVF4Zmg1WEZsRXNLQWtHRGN0MENBMW8xaUUx?=
 =?utf-8?B?aUtHTGtCUHhmUWozYzRXTzNLMUFYK0szMUJXbnExSFVoVk1VVkl5NHZJMW5n?=
 =?utf-8?B?UVJzREdMYlVWUHE3S2U2cGhqT3dqOW91VzNPbEdZTGtTMHdHTWkwMHVzQjcy?=
 =?utf-8?B?clUvN0p6UjlaYTFZek9SVkJQT2NVUVdZaDNPWm5FRnBMK0xDMXdxMEVZWUpj?=
 =?utf-8?B?L0YrNHdyY0VjdHNrd2FxMnVkQkxlWWZ3cTVhVnpwVGJ6RTZmOFJGSG1lLzlV?=
 =?utf-8?B?YWloZUFkbHhPTk8vY3ZVOGErNVROWEV3eWNhaXV1aWNPM2tHVkxESWFhaU5v?=
 =?utf-8?B?UjhUN2NXMHBrdlpJSWxHZVdJcGVMVnJ1MyswR3V0ZkhtajhMbWtWM2xjT2FU?=
 =?utf-8?B?d2dYUXdNNmVJaWNlTWszczRieStKVGJNQ2hWT2xYYlkyd3JPNTNuR0p5OC92?=
 =?utf-8?B?THRFRVJqNXhYaTJWUVJ6dHcvbFAxUy9GUWlscGdUUHNUNlpzWERBdDJMSmMz?=
 =?utf-8?B?NWR1aGxoelhETVVRaWJNT0xFNk84b0c3aHpybzVaZGo2Q1JRK2p1SUM4Rlcv?=
 =?utf-8?B?Sk05RnMrcytNSG9OeGtrd1dQWExod2V0SzNFOWNwTVNCc1BOd3RHVlI4SVhL?=
 =?utf-8?B?cnVOaXNYZGtZTitSOUtMQ1IwV3ROaVpZbGdCZDZobWRUbnFFeENjVWQxODB4?=
 =?utf-8?B?c3RjWDJOQnpJQnh2UWp4R1NsQW13ajY4b2E1YnNkMzhuc2FwUFdCMk91MXdY?=
 =?utf-8?B?bCtxUzBST21ONkFWOTN6cGlQWWxxSGMwNHBmcU9rQXZxTU9FVktiNGltME41?=
 =?utf-8?B?K0dDV2xjSG1hVFVOWVk5bGdENWNURW51clpnbmsxN2hydWp0azlreHpRbEgr?=
 =?utf-8?B?NUMxSGhBZHdjV2t4RzhhR2FFM2s3R09nb1pPQlVPeVZRL2YraU9GQ3dEdnUw?=
 =?utf-8?B?QjBRb0wxVlFodFYybkZIN3dUWHRzSEs2U1EzSHBGQ3dJYnEybmpXS3AvQWxm?=
 =?utf-8?B?ZVR0WE5XK2hLY0ZTM28xWVB3Uzl5am1qOVo4ZkQwSWpIL3VDS0Q1MXhtdHlE?=
 =?utf-8?Q?U0CvN1oQHWK9Hbf4keP23NZwI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f179ef4-3b9d-476b-e08b-08dc7a643ff3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 13:36:57.0933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /m5wj/Bvk4nNw9EBT4elddWUaWBpNw2IzcBTc5GQE5sNjH7JzEIgXHnmX3wn2wrifuhLFFIftsV0CrgaEn+OfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5617

+ Simon

On 5/22/2024 05:07, Rino André Johnsen wrote:
> To be perfectly honest with you, I haven't given that much though. I
> used the 'bpc' and 'colorspace' property in debugfs, since I could not
> find that information anywhere else. And since I also needed to verify
> the pixel encoding being used, I added it where those other values
> were. That made for a simple and easy addition for this property.
> 
> If you want me to do this differently, let me know. And please point
> me to the standardized DRM property where I should expose the values.

Here's a pointer to where the colorspace property is created:

https://github.com/torvalds/linux/blob/v6.9/drivers/gpu/drm/drm_connector.c#L2147

I would expect you can make another property for the information you're 
looking for and then can get it from userspace using standard property
APIs.

> 
> Rino
> 
> On Tue, May 21, 2024 at 10:55 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>> On 5/21/2024 15:06, Rino André Johnsen wrote:
>>> What is already there in debugfs is 'bpc' and 'colorspace', but not
>>> the pixel encoding/format.
>>> I have searched high and low for that to be able to verify that my
>>> monitor and computer are using my preferred combination of all those
>>> three values.
>>>
>>> I do think it should be available as a standard DRM CRTC property, but
>>> for the time being, I figured that a simple debugfs property would be
>>> sufficient for time being.
>>>
>>
>> It's just about as much work either way to populate it though, why do it
>> twice instead of just doing it right the first time?
>>
>>> Rino
>>>
>>>
>>> On Tue, May 21, 2024 at 9:04 PM Christian König
>>> <christian.koenig@amd.com> wrote:
>>>>
>>>> Am 21.05.24 um 07:11 schrieb Rino Andre Johnsen:
>>>>> [Why]
>>>>> For debugging and testing purposes.
>>>>>
>>>>> [How]
>>>>> Create amdgpu_current_pixelencoding debugfs entry.
>>>>> Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding
>>>>
>>>> Why isn't that available as standard DRM CRTC property in either sysfs
>>>> or debugfs?
>>>>
>>>> I think the format specifiers should already be available somewhere there.
>>>>
>>>> Regards,
>>>> Christian.
>>>>
>>>>>
>>>>> Signed-off-by: Rino Andre Johnsen <rinoandrejohnsen@gmail.com>
>>>>> ---
>>>>>
>>>>> Changes in v2:
>>>>> 1. Do not initialize dm_crtc_state to NULL.
>>>>> ---
>>>>>     .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 47 +++++++++++++++++++
>>>>>     1 file changed, 47 insertions(+)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>>>>> index 27d5c6077630..4254d4a4b56b 100644
>>>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>>>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>>>>> @@ -1160,6 +1160,51 @@ static int amdgpu_current_colorspace_show(struct seq_file *m, void *data)
>>>>>     }
>>>>>     DEFINE_SHOW_ATTRIBUTE(amdgpu_current_colorspace);
>>>>>
>>>>> +/*
>>>>> + * Returns the current pixelencoding for the crtc.
>>>>> + * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/amdgpu_current_pixelencoding
>>>>> + */
>>>>> +static int amdgpu_current_pixelencoding_show(struct seq_file *m, void *data)
>>>>> +{
>>>>> +     struct drm_crtc *crtc = m->private;
>>>>> +     struct drm_device *dev = crtc->dev;
>>>>> +     struct dm_crtc_state *dm_crtc_state;
>>>>> +     int res = -ENODEV;
>>>>> +
>>>>> +     mutex_lock(&dev->mode_config.mutex);
>>>>> +     drm_modeset_lock(&crtc->mutex, NULL);
>>>>> +     if (crtc->state == NULL)
>>>>> +             goto unlock;
>>>>> +
>>>>> +     dm_crtc_state = to_dm_crtc_state(crtc->state);
>>>>> +     if (dm_crtc_state->stream == NULL)
>>>>> +             goto unlock;
>>>>> +
>>>>> +     switch (dm_crtc_state->stream->timing.pixel_encoding) {
>>>>> +     case PIXEL_ENCODING_RGB:
>>>>> +             seq_puts(m, "RGB");
>>>>> +             break;
>>>>> +     case PIXEL_ENCODING_YCBCR422:
>>>>> +             seq_puts(m, "YCBCR422");
>>>>> +             break;
>>>>> +     case PIXEL_ENCODING_YCBCR444:
>>>>> +             seq_puts(m, "YCBCR444");
>>>>> +             break;
>>>>> +     case PIXEL_ENCODING_YCBCR420:
>>>>> +             seq_puts(m, "YCBCR420");
>>>>> +             break;
>>>>> +     default:
>>>>> +             goto unlock;
>>>>> +     }
>>>>> +     res = 0;
>>>>> +
>>>>> +unlock:
>>>>> +     drm_modeset_unlock(&crtc->mutex);
>>>>> +     mutex_unlock(&dev->mode_config.mutex);
>>>>> +
>>>>> +     return res;
>>>>> +}
>>>>> +DEFINE_SHOW_ATTRIBUTE(amdgpu_current_pixelencoding);
>>>>>
>>>>>     /*
>>>>>      * Example usage:
>>>>> @@ -3688,6 +3733,8 @@ void crtc_debugfs_init(struct drm_crtc *crtc)
>>>>>                             crtc, &amdgpu_current_bpc_fops);
>>>>>         debugfs_create_file("amdgpu_current_colorspace", 0644, crtc->debugfs_entry,
>>>>>                             crtc, &amdgpu_current_colorspace_fops);
>>>>> +     debugfs_create_file("amdgpu_current_pixelencoding", 0644, crtc->debugfs_entry,
>>>>> +                         crtc, &amdgpu_current_pixelencoding_fops);
>>>>>     }
>>>>>
>>>>>     /*
>>>>
>>