Received-SPF: pass (google.com: domain of linux-kernel+bounces-186296-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 22 May 2024 08:57:31 -0400
From: Sasha Levin <sashal@kernel.org>
To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= <ast@fiberby.net>
Cc: Pavel Machek <pavel@denx.de>, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Simon Horman <horms@kernel.org>,
	"David S . Miller" <davem@davemloft.net>, manishc@marvell.com,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 5/9] net: qede: sanitize 'rc' in
 qede_add_tc_flower_fltr()
Message-ID: <Zk3ruzqbpMAzZr9q@sashalap>
References: <20240507231406.395123-1-sashal@kernel.org>
 <20240507231406.395123-5-sashal@kernel.org>
 <ZkHMvNFzwPfMeJL3@duo.ucw.cz>
 <ea7ae0c4-a582-42ce-9bc9-5f3df1915ca0@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ea7ae0c4-a582-42ce-9bc9-5f3df1915ca0@fiberby.net>

On Mon, May 13, 2024 at 09:46:02AM +0000, Asbj?rn Sloth T?nnesen wrote:
>Hi Pavel and Sasha,
>
>On 5/13/24 8:18 AM, Pavel Machek wrote:
>>>Explicitly set 'rc' (return code), before jumping to the
>>>unlock and return path.
>>>
>>>By not having any code depend on that 'rc' remains at
>>>it's initial value of -EINVAL, then we can re-use 'rc' for
>>>the return code of function calls in subsequent patches.
>>>
>>>Only compile tested.
>>
>>Only compile tested, and is a preparation for something we won't do in
>>stable. Does not fix a bug, please drop.
>
>Please see the original thread about this series[1], this patch is a requirement for
>two of the next patches, which does fix a few bugs with overruled error codes returned
>to user space.
>
>I was originally going to ignore these AUTOSEL mails, since the whole series was already
>added to the queued more than 24 hours earlier[2]. In the queue Sasha has also added "Stable-dep-of:'.
>
>So the weird thing is that AUTOSEL selected this patch, given that it was already in the queue.

Two different processes on my end, sorry for the noise!

-- 
Thanks,
Sasha