Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp358390lqp; Wed, 22 May 2024 06:50:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6m88qhFgRZXzoOVogisL9wgVOvFRv3OEdzSUNMZk1FZ0IKAWv14/j6VA5nD08CDSSeFqVhmWhkGPLX+OgzdAns9dNg0sdthxE6u1tHQ== X-Google-Smtp-Source: AGHT+IFI7PHIc/aiRWzqgvCqHVPvxaUp63F0fhsG2Cl0nxMPRhVcga/IYG2xo+R0MB5x7Nsq8Wya X-Received: by 2002:a17:90a:db90:b0:2b9:a45c:dcec with SMTP id 98e67ed59e1d1-2bd6047a9a3mr16418568a91.23.1716385824064; Wed, 22 May 2024 06:50:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716385824; cv=pass; d=google.com; s=arc-20160816; b=HYmpew3gGV5WoV3JlpCixNA3UDC/4TTlIHcXelRIwKlyhxNs2UfCQKjm6mBr8wr5DD qmifM4DjKyhtTVZ3/8rPfX3tj8yzjb/5JJ1GtSZtDV9/R/ARMdgeWKGKmWn302SREfwz 2Tc9Cyn+uO0MTXQipsk+V1M/m4QBB1qGH6ELKjQWWOpbJCaIrGp23Cn2p+P7cCL+K+bg 4mzpEACVOxXvFOKQM2uVzNy86Cj9axjtmSbt6EVRFQH1XFKwuDYcYrMswVpbmshwZhhy PX7j4G5lEdweT/xXqXrBTRd1i0qPxuj+kSfbVUAgAjc7+TU0sUge5ZmAQ6S2v1hebcTV ilNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date; bh=gLF3/0y5hYfaL39gpSa0sZcibPQfrACx0584zK5GADY=; fh=Mjv0vai6ZW3HvWzvbypqgbQDkHARXsmXfG4RTFUNFCI=; b=xdGjOnG8Tj1//VsGgJwLa4O2VBfQYH5xZm+PcavT64rAuFEmaNQ2/9zULy71yH/XeH M8FQkTKZ8NwtnPzngWrCdF+DxbY2vEIY0JuuCvge2p36aLenAjI8FuezaRTJ+f8ieF3V CdiVaJSJ+2dmCZyTIbTPRYFVzyyrtg0QKZSbO1B5ctBme2/B4OBe456eRSIpBSf30lFC EhC1JIW9ewnD666g020bM20MJGtwFtdqzHPjBu3NtFGYdXEtMNbnSlDkuA7ab4NZh7nd OGl1ph/sU4NDBkbclZHm8zuNqwH13IOjes5qaVimBhhY5sWXFi7tFCiYJZxuXFOdnmD3 9F4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=netrider.rowland.org); spf=pass (google.com: domain of linux-kernel+bounces-186301-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186301-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=harvard.edu Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bd9303437esi3393830a91.112.2024.05.22.06.50.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 06:50:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186301-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=netrider.rowland.org); spf=pass (google.com: domain of linux-kernel+bounces-186301-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186301-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=harvard.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 89A40B213EA for ; Wed, 22 May 2024 13:50:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18D07140E30; Wed, 22 May 2024 13:50:00 +0000 (UTC) Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by smtp.subspace.kernel.org (Postfix) with SMTP id 5BC8217FE for ; Wed, 22 May 2024 13:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.131.102.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716385799; cv=none; b=S/GB3DYz46+idAi9TzUD0wgh2kniEw+zQNN7FIlGwN9GSNtW1RvGpiKfM5qaoVvjijGWaONgAyQKzOJKJ0gevQ51uX85SDcnXGGB2sWGr0JNMUmBjiHLV1QlvrBdp2ZNrx6tBBrCrnLkSenkFLGSmNifwFmX9vJcCXrCKfRSkek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716385799; c=relaxed/simple; bh=78Q2CGlF7Kc7/HZA9H4BC5dum8xm9Ro2FY2sOfh2+Cg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cqjZ3sOyaBWIbtZmUTa1n41VjYt0ANjg6t35SxcKmsbAB8ijXYUEnz4f3wdbouCQudoxk6yDfmP7ZpHiuq77aRdIhq8/4J/IjC+KBk5WdImv7EAh1gd5jbGXJAaA1UY9Y53dmjqei9ACsyvdYASbz0+rg3ohuWfbdOOHTuSLElM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=rowland.harvard.edu; spf=pass smtp.mailfrom=netrider.rowland.org; arc=none smtp.client-ip=192.131.102.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netrider.rowland.org Received: (qmail 497823 invoked by uid 1000); 22 May 2024 09:49:55 -0400 Date: Wed, 22 May 2024 09:49:55 -0400 From: Alan Stern To: Shichao Lai Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com Subject: Re: divide error in alauda_transport Message-ID: References: <2024052224-motion-perish-82cd@gregkh> <2024052242-hunter-exception-930c@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, May 22, 2024 at 06:01:57PM +0800, Shichao Lai wrote: > Thanks for your patience. I am a beginner and initially attempted to report > errors to the community. > However, I have just discovered that the issue mentioned above has already > been proposed in the previous three months of the article, and there is an > ongoing discussion. To call the discussion "ongoing" is optimistic. There hasn't been any reply to my last post, which was made on March 17, more than two months ago. Maybe you can carry out the tests I described in that post. That would be a big help. Alan Stern > I think this post can be closed later. > > https://groups.google.com/g/syzkaller-bugs/c/m8CuxSpLKoQ/m/JfUy1xGnAwAJ > > Greg Kroah-Hartman 于2024年5月22日周三 16:59写道: > > > On Wed, May 22, 2024 at 04:22:18PM +0800, Shichao Lai wrote: > > > patch like this: > > > ```c > > > while (sectors > 0) { > > > if (!uzonesize) { > > > return USB_STOR_TRANSPORT_ERROR; > > > } > > > unsigned int zone = lba / uzonesize; /* integer division */ > > > unsigned int lba_offset = lba - (zone * uzonesize); > > > unsigned int pages; > > > ``` > > > > Please submit this properly and we will be glad to review it. > > > > thanks, > > > > greg k-h > >