Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp374304lqp; Wed, 22 May 2024 07:12:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW/kGvLwkbBNkng9WvBn9YnakPVEziSiCUWJ899/Vlt+biPYhJk5j235pNyXb9p9+HU+TltUFrjOmeuT6XUAecv3hhYWfuSjtsW2CVHXQ== X-Google-Smtp-Source: AGHT+IEgiOsbvcG1I11INsBhRoubuA9YHvb59AyQ++NG6HIAf14Dznkk8AJexGtrH4TWiijkUxX/ X-Received: by 2002:a17:906:8d3:b0:a59:29ea:ed1d with SMTP id a640c23a62f3a-a6228083969mr149378666b.22.1716387137549; Wed, 22 May 2024 07:12:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716387137; cv=pass; d=google.com; s=arc-20160816; b=z/VmtCv3KszctCM2qmBH4RmXu7gy+BEsCw9ywDL4e8GxSwxGomnfQ+paM6K8v3eL5z slUvOqghFAGicgolntSu1OxAuLE2pXLABf1o6xityvi5k4fAtlQ8R6KCq6WJe5P5dxzr xftcLYiYdUGJbZDqx+VbuvHROHzjher8yys04SP1BC6QojnC+S7TVUJy90I+JzJ7UOt4 RriKk9f1n4RhsSURfgTlvkrs6NXQMBEcP5z2tDY90OZA5gqBG6sFwAADYyCi1Oq+fjn1 6eTWUQAVMySQ91SlXFKOvQiuIZ52quG8/ph0rV8eqjIVQjJb0s1wYcFJZogedYJhgQ5C Dfug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DDbjOB44ewZWIRltYmOU003Ll0k98hPAJ99V/6Z7rjA=; fh=vx9s742SM0TNf+N5YfZmupmpNXDz5t5+q+ZYgVTtORM=; b=l43mAe3okRQexdEM1aRxp83+a8QZ1sJajf/qhm+B0tTv+whT8lLfcjabIXBjfsS+26 +I9z0xQ9uXQwLdMjkALW2wLfIuzY0phal5+jzcbUc6CFm9CLbkQa/NebkIo8lSbWIT/W GkGbqEu+qbcfVcdAr92ormGoFHb2pZrjo1kFl+HEba+Z56ppxSDEC9eo9oz8DQ1sOVwG GWj3h0R79RPbac6pCUsHiPoeOGYRBu/UvHve6yX82Ygr2LzCwOno7TavpIFbw9jsRnto C6gRrzV127AU6smKvX3jTgQTsVILwcJCdfWPFLssCepfLbSQLLPVNRmFKjaJ4VE145IH N0Gg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=uEqWCsrX; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-186336-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186336-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17ba28afsi1485557366b.525.2024.05.22.07.12.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 07:12:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186336-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=uEqWCsrX; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-186336-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186336-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4B2F11F22770 for ; Wed, 22 May 2024 14:12:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2910C1411C5; Wed, 22 May 2024 14:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uEqWCsrX" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80BF143AAB; Wed, 22 May 2024 14:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716387129; cv=none; b=agXqB6KSZ3i4SGZiCpPEuNmjE8UOVeyhBuTsbReiatQ6odt8FJk3mzEKpd1zkdFcYAAaGlIGGlD2eAQlRDlWrmqmqTzwLtXKexE/3fuSoQSJYCVfeGtjExynTnqQc22BbPvqfALz3BPLoQ8aVrgLTNjEEo9NalBs0SX6R52rq5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716387129; c=relaxed/simple; bh=DDbjOB44ewZWIRltYmOU003Ll0k98hPAJ99V/6Z7rjA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fFud3ziE6eA+pf20YxHIt/PKg/ot2r/RGEsTWvIlTaaZ1cXU756H6Zrv+RpBPp7P0mutUzPlhQnrTTy03XaaUsyooq/PHEVOuY5MaRkSHORgZiPp+Q+h8YvApejwWYMmFEzc/26dNAtPEgP1FYQ7Qd0227NzAcEPFMAGaFAqpyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=uEqWCsrX; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DDbjOB44ewZWIRltYmOU003Ll0k98hPAJ99V/6Z7rjA=; b=uEqWCsrXiGnYASDuZAU5ot6tQN XjK1e6Gll8ojSe+3yON3pJfsrV/kkCYvTRBFnNjTzHHovDzW76TQ9M7XXcZxJl+XUGSqoBlf16Z3/ ws/+xgLky5OQhAsn3kwnQvcJk+AupZuZZKMGcHUQ05G2fM4NbUT1MU27yCBL9e5yt9wzfYdeqEd7f 5SIqFwucxPtY6LnnqhJj2qtrW01//jNhVTzviw0Z1MPuZJaUsj5V0MODpVAWb0q6O41TT4558Mtr5 UpW6InBw16BU72NmZLAcfB3Yne9fkNbuFw5e8QnUXbXOmcXrCJHk0h3tgJGNj8infSgJrpr7NDIjU ASpsxliw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9mgx-00000000iS5-2uBa; Wed, 22 May 2024 14:11:43 +0000 Date: Wed, 22 May 2024 15:11:43 +0100 From: Matthew Wilcox To: Sukrit Bhatnagar Cc: Petr Mladek , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Masami Hiramatsu , Mathieu Desnoyers , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Improve dump_page() output for slab pages Message-ID: References: <20240522074629.2420423-1-Sukrit.Bhatnagar@sony.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522074629.2420423-1-Sukrit.Bhatnagar@sony.com> On Wed, May 22, 2024 at 04:46:27PM +0900, Sukrit Bhatnagar wrote: > On the other hand, the struct slab has kmem_cache which maintains another set > of flags. It would be nice to have these flags added as a part of the debug > output, and to have a convenient way to print them. I don't understand why the slab cache flags are the interesting thing. Seems to me it'd be more useful to print slab->slab_cache->name and then you'd be able to look up the flags from that, as well as get a lot more information.