Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp396017lqp; Wed, 22 May 2024 07:47:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWJb88sjfZ1Y5RS58WDPobgzbsGtgIHFY6HQAWvQJvTGLXI02206cUFdLVuWi8LXhxl48f+YpikZ6P9iIxAQJ3hwLhYZkcnllB0IE/Q6Q== X-Google-Smtp-Source: AGHT+IFUB3SIPgfj8iHuolnBcg4gLzGgseEyy0gcbjasjdOGCqqtWZxYod/X2mJiSZqTU50nuxgd X-Received: by 2002:a17:902:e9c4:b0:1ec:659c:95fb with SMTP id d9443c01a7336-1f31c983d39mr20238095ad.32.1716389243642; Wed, 22 May 2024 07:47:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716389243; cv=pass; d=google.com; s=arc-20160816; b=cRzlMzWK3NklRTIENrOUG9dYXwLHDvxiuopcvzrrfdslSLB/KOPu2k9/VDZy7kjxiF wSfupfCLOW2fTb9ZpA6AblQ7TBbU6R1EZWGXM15F3NNpcpnS+2k0tWDZ/to4f4PorSIu P/9pBnG46b6Q6ZGYqKxUWRf9WpcWiJtWlDMyLqETdVtt4lkJo2iG8412mOWX1dRG4aqH 02L7tELQqxRAz5lOPar3+wmuxqVXGcCGaw2DIfJQb0CHqFkHrrp1mHx1SE9mHJwUnOyd NNWo9iUcFilSqhfycs1DMen0BBRnuROh/VlgkUGPEjUDfZ9g7tXhu26xya89o2ht9jWV VDiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5j3a97GZYn8GtQc/vvZ0rSn8m3uqrmZSlXHqEKA7KqE=; fh=eebrRAeYcrRr/jO2NjMAxJ7oZtY5NDMAQFnPIB19SYU=; b=Quu6fFGutN33gHxSyfi2viVmMR50ycJuRulT7Yw0GkDzN2rg9xg5/ifD034UPCgE2H KL34Jcx/5jPEIm+DSy1pwZ8HW4ywpwi7BLuF6YgXfkSSNV97XkzOhTLZDhGurby5i/yd xeSGW97qZlRnppEXhEQii41xIBpOqJMm6SCybc4+mvvagseHUZxhtS2d1AWsxzF0cCOD MaCA5n0GeeDuLUEb6QgKJPLtER50928SQ8pjB16TcR95wt0/K8BvUuez7nBBtEmon1dh enlhLxhrflVGCJ8EJCC+pYs6VKFvsCLdPmauJ/ACQKEYo44a2qSskSRwC1Jef2hVJynS fzcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JvevakpV; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-186381-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186381-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f31ad37815si14979655ad.633.2024.05.22.07.47.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 07:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186381-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JvevakpV; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-186381-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186381-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3013F281AE8 for ; Wed, 22 May 2024 14:47:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A77C61CAA6; Wed, 22 May 2024 14:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JvevakpV" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61CD6AD7; Wed, 22 May 2024 14:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716389234; cv=none; b=BxB6eD2PxSYoNW9HJl7s0OYcj9SfO/PyupFP+j/e67Gl8cwbtZewYGzSg01VMLMZJ8SPS83AI+7TRR0sATz3HOmmxyt1sYH6r3XUC5Vwfzm0R59U3hG0W4fKbY7A7wI7St5V33oLKHMxVev+CWMs/sKOVq7UH+YDCaJDoT8WZks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716389234; c=relaxed/simple; bh=5j3a97GZYn8GtQc/vvZ0rSn8m3uqrmZSlXHqEKA7KqE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WLyNnJNl5lFhV02Lfjov+p31TUzOcDJL3haClLNUk2PSVUXl97fdYua9WVhoqghhS36nL2w+32C47fcJOv56N+C9z1t1qUzizendfDyzaKoQctVuVj0pWApFFhA3US7mKMEzj6EsOq4Lv5OQGSUMPhxgg7z8dKZc289cZcPUkA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JvevakpV; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F02CAC2BBFC; Wed, 22 May 2024 14:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716389234; bh=5j3a97GZYn8GtQc/vvZ0rSn8m3uqrmZSlXHqEKA7KqE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JvevakpVj33ueJIw6Hvj1R41NaRx/ciHI77LaJBPStAP1/m6aPoNPZLQN3i2Z5jRl Wl0W+TrkUMUXZHEHH57koACtpwhICr7etVIP8ErC0VzjtOxDWcf03dGT8xumMzbXVC KY5s6UfUgQW2s15iKAPUBydKcqtP9vaWOGRMVHcc= Date: Wed, 22 May 2024 16:47:11 +0200 From: Greg KH To: Roland Xu Cc: ojeda@kernel.org, boqun.feng@gmail.com, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: kernel: make impl_has_work compatible with more complex generics Message-ID: <2024052213-uninjured-stricken-cc20@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 22, 2024 at 09:16:33PM +0800, Roland Xu wrote: > Make the impl_has_work macro compatible with more complex generics such as lifetimes and const generic arguments. Can you wrap your lines at 72 columns like checkpatch asks for? > See more in https://github.com/Rust-for-Linux/linux/issues/1077 Please don't point to external sites for "more information", include it here in the changelog text as this is where it is going to live for "forever", random external sites hosted by others usually have short lifespans. thanks, greg k-h