Received-SPF: pass (google.com: domain of linux-kernel+bounces-186384-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 22 May 2024 09:48:46 -0500
From: Rob Herring <robh@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Michal Simek <michal.simek@amd.com>, linux-gpio@vger.kernel.org,
	Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: xilinx: Add support for
 function with pins
Message-ID: <20240522144846.GA3277292-robh@kernel.org>
References: <20240520150424.2531458-1-sean.anderson@linux.dev>
 <20240520150424.2531458-2-sean.anderson@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240520150424.2531458-2-sean.anderson@linux.dev>

On Mon, May 20, 2024 at 11:04:23AM -0400, Sean Anderson wrote:
> Support specifying the function per-pin. The driver doesn't care
> whethern you use pins or groups for this purpose.
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
> 
> (no changes since v1)
> 
>  .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 344 +++++++++---------
>  1 file changed, 176 insertions(+), 168 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> index f13d315b5d5e..d3b258245e28 100644
> --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> @@ -42,179 +42,187 @@ patternProperties:
>          $ref: pinmux-node.yaml#
>  
>          properties:
> +          pins:
> +            description:
> +              List of pins to select (either this or "groups" must be specified)

Express as a schema:

oneOf:
  - required: [pins]
  - required: [groups]


> +            items:
> +              pattern: '^MIO([0-9]|[1-6][0-9]|7[0-7])$'
> +
>            groups:
>              description:
>                List of groups to select (either this or "pins" must be
>                specified), available groups for this subnode.
>              items: