Received-SPF: pass (google.com: domain of linux-kernel+bounces-186406-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 22 May 2024 18:07:54 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Nechita, Ramona" <Ramona.Nechita@analog.com>
Cc: Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, "Sa, Nuno" <Nuno.Sa@analog.com>,
	Marius Cristea <marius.cristea@microchip.com>,
	"Schmitt, Marcelo" <Marcelo.Schmitt@analog.com>,
	Maksim Kiselev <bigunclemax@gmail.com>,
	Ivan Mikhaylov <fr0st61te@gmail.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Liam Beguin <liambeguin@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: iio: adc: add support for ad777x family
Message-ID: <Zk4KSlZ7NFgYx2Co@smile.fi.intel.com>
References: <20240522120005.18197-1-ramona.nechita@analog.com>
 <9c19faf6ee186f144a705f458da83ea25f7a3a34.camel@gmail.com>
 <SN6PR03MB4320549F56148C13C4BDBBA1F3EB2@SN6PR03MB4320.namprd03.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <SN6PR03MB4320549F56148C13C4BDBBA1F3EB2@SN6PR03MB4320.namprd03.prod.outlook.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, May 22, 2024 at 03:01:52PM +0000, Nechita, Ramona wrote:
> Hello Nuno,
> 
> I apologize, I accidentally submitted the updated version that I used for the
> project, instead of the one without axi. I will fix it and resend the patch
> asap.

First of all, do not top-post!

Second, don't do ASAP, take your time, read the comments given for this version
and address the same / similar issues in any code you are possessing before
sending.

> -----Original Message-----
> From: Nuno S? <noname.nuno@gmail.com> 
> Sent: Wednesday, May 22, 2024 5:36 PM
> On Wed, 2024-05-22 at 14:59 +0300, ranechita wrote:
> > Added support for ad7770,ad7771,ad7779 ADCs. The data is streamed only 
> > on the spi-mode, without using the data lines.

> Is this even compiling? This is definitely not code to be upstreamed since it
> relies on the our out-of-tree/legacy driver for the adi-axi-adc. You need to
> convert this to use the IIO backend framework (adding new interfaces if
> needed).

-- 
With Best Regards,
Andy Shevchenko