Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp440910lqp; Wed, 22 May 2024 08:57:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXskETDyzhGq1cQw2qiiVhkPl/V3A3irmuBcY78BDrRxyAYyP9J0Zmxbqo+6DWyXAvCr2aJfvcJ5KNJ7rqpBYZJjOvsctMZh0tor7DYEQ== X-Google-Smtp-Source: AGHT+IF67Ryo6nqlrpI/yxG3ygRHmuvvTf3PCS9X6tSsJuBy4llHzBD8m+i/7s3d+Z8K2oS8pwdM X-Received: by 2002:a05:6a20:96cf:b0:1af:ac96:f4bf with SMTP id adf61e73a8af0-1b1f88388a7mr2194098637.15.1716393460290; Wed, 22 May 2024 08:57:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716393460; cv=pass; d=google.com; s=arc-20160816; b=ouvmduo2tdZDPHyof5U+6pIP6iu54mDSnwFiJ/T1WVvTZvIBnru3AobzL2vph90L/v RSKyZ1GNQK7N2un4kKhHd6Sd6605IH2bpt9kYnWXw4ylKXicu4YwaTHw7kdoxf2zAHia 9eIv0wY8kFphPLLhTW+LxNA8T17TCNcnYrkMLcVGn4/0VLcyDypDKR+WVJgrqUuw0gMU MhPc/r1EsjPjC2XtuVmhjyBRuN/AIusayuXLvhwbCSzbSVUOqDRAcHYz4+vKUZh3qKeq ceDEAbpRmPfrbewWfmLXamqzS/4PQepW/sNx9RzUbve6KkHIU6567P6ShKRpAmp7piKM 0JVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=s7fLrqlLqrdwUt4HwOiHRqZ1aWTDKv1ZtetuvCqzHYc=; fh=eebrRAeYcrRr/jO2NjMAxJ7oZtY5NDMAQFnPIB19SYU=; b=Snfvfkj+iHaD/gIx3ZXZTFMN0jMCLDSRlQ+bLmQistUceWgaCcg1QDl5X5ErjcKnBP r/9vnISFvRYjB7HG8Z1NpHMk4q+Sdt3jYxAtnXNDgA9ZfMJsr0ukSCR2VrBhrnxpQRP+ h3FYTqeA0LStTzdq6K9iPrr3SkucecT7P2iMMeaVVAewluXmanxji6kZgW4eR/BPj3hm VIwJR28ItS1hxpeTEhkYQJ3pdJrwQjmGha7oWs8jcSgWY2MEOE4SLFZz/woflLxmJM04 mIrx8M0xu4SJafREMzvBBhwXyYP2GPkTWJDN68Mz94bFL9kw/mYcPSOPLaUbMwyZD+ub LZ1A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hHdVEMMT; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-186469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-65b2a66c914si6119861a12.242.2024.05.22.08.57.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 08:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hHdVEMMT; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-186469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E62D4283AAC for ; Wed, 22 May 2024 15:57:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A902913E888; Wed, 22 May 2024 15:57:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hHdVEMMT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE1B1210EC; Wed, 22 May 2024 15:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716393451; cv=none; b=fHnm1oNS5wC0yTo0ei1Zjo8kzZ2j7aePNqLGtZ5XYZ1oSezG5L3nJXxdv8WGcz6wusVVJVzQgwbfRVGiVAJvZbhSzjfZaeWTP6nXGa75+xjbB3g+wNpFRzzXWREKQ5Egyg4HGkmQTnv3fub0P1yqYVWcbU2DEY759/Dvhstb4zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716393451; c=relaxed/simple; bh=s7fLrqlLqrdwUt4HwOiHRqZ1aWTDKv1ZtetuvCqzHYc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nxaAQKjV6DVfYW5vEF4KZxgyqNA45rpWHOIBcUmJ+bLonP0ncfzSSbDbA8XTjJd2MBwZK2DXoYP/Hs71IQrmHtvZ/P8osE94mdlLJksgvXHK83PN2ilCDeZmjrUzdJqS4W5P4DLDe2RquKOEop60y2VRb3d/Ji8iVWHBQ9mjfjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hHdVEMMT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80D99C2BBFC; Wed, 22 May 2024 15:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716393450; bh=s7fLrqlLqrdwUt4HwOiHRqZ1aWTDKv1ZtetuvCqzHYc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hHdVEMMT7yEeHEjRb8AKs6PdTe0Jz5DckgqlVSGU2qDb7VPWIn129BstQFh8me2tl MVDouGgbq1ahnznEEuianDx6MpoStZKRn8SwW10V70H3t6nc5HNL8b/9clprSR3I/c TNHToQXWpk8ktl2vvl8V0wR3SqsKyYwjt9rb7bT8= Date: Wed, 22 May 2024 17:57:28 +0200 From: Greg KH To: Roland Xu Cc: ojeda@kernel.org, boqun.feng@gmail.com, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rust: kernel: make impl_has_work compatible with more generics Message-ID: <2024052258-trifocals-engaged-8d80@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 22, 2024 at 11:45:33PM +0800, Roland Xu wrote: > v2: apply comments, wrap lines at 72 columns > --- That goes below the --- line. > Make the impl_has_work macro compatible with more complex generics such as lifetimes and const generic arguments. Columns are still not wrapped :( Look at example submissions on the mailing list for how to structure this. thanks, greg k-h