Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp473753lqp; Wed, 22 May 2024 09:45:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXON3MkuObZkcRt0vibBY+AKHBmmlZjSfVkxs2MjRsTYBRiTO9+G+d3VFNVLdwG8/6BJiRYWPDAeWs/1eHwOmsvyjN0ZEsHVmxpFPY48w== X-Google-Smtp-Source: AGHT+IGPpsS/sP5nu4MbwovHVaySm6F893N/f2v4OoaGt2ASeLpukErg+8bDsR5UH009DexXLasQ X-Received: by 2002:a17:902:e852:b0:1f3:362d:923a with SMTP id d9443c01a7336-1f3362d9318mr3225645ad.39.1716396330468; Wed, 22 May 2024 09:45:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716396330; cv=pass; d=google.com; s=arc-20160816; b=wqokdweomH/JkDUWX2OWiwO98PpIB/xFltOtiXoAjY5gfTmnWkvlheeUvQ5wzp8gfU b+rbkILsNJBWT37LJpUFayE3EcQdBiE6xS83HiZ7EEbcKLE90HeYUzlBr6BKl5yUpHWa 6HXKpBb/Lnjq3Wy/i7GJiKtc7CLGBssnyIRREsXJfcr//Jv81ZQbuC5sUaZN8D3utuRF ElWzMslwVZWVHUwZL3CgcRisynRgHdi28L1oOCyql8FMHGMjE6aRBwBN/BNrOkbLUso/ huLCTKQd8RWD3pGAF7d11MsQtjyQtbrAuL0Cp0fAogV1s06Gm9wDbWKq3qW9UgLYs81j Wy5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8Tfw1C5OBMTMu+sGe3XwcpMYANF6JY3ZkgMDDdPK8dI=; fh=Prk+IlbHJw7SpKiVjbAC3lwelii+UU35ev9ooE7gJR8=; b=zSZzKxAoEQoDPtvrQvOD7g1ewtPXRtR8md3bMy2067RKQUAM5WoRJ6uTBDhWDlRGSf J4ZmQ9GeGkVLXuXBafBjAcmUgqkUb7D/M8vbin+wLHGpOoAhDIthcYAT+BkOdgzilfF+ yk1Qg3cWf/zf9TtVng8ky4EDdAJC+w12ha8vtktcUxxvMFyoyR1kLSF1wCAt2JiSH6xo pOq1maZrGIlkiKo9G4lOWFy5xK5Hj0SaPZN+mQMIci2xpmlkP4EKBAa+jgOQclYTq4RN Fb+ruW7Ztsh57vAbXOAAH9/ZLIJ8QhGZK9tNKvpyIdhGnM46WiAW6EQgzSGkwtiPGBaN nvBg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=q4LFV16n; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-186506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186506-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c14d0b2si33721185ad.488.2024.05.22.09.45.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 09:45:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=q4LFV16n; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-186506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186506-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 70DABB212FE for ; Wed, 22 May 2024 16:44:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 809501420D0; Wed, 22 May 2024 16:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="q4LFV16n" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71761411E0; Wed, 22 May 2024 16:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716396276; cv=none; b=hc5cFsNwX9Gq4tJ07kWhn5YEr2RZq+qiiHzs2EcflDHG6m6UD/iwafdaxjGE+GCPn7ZKmlePQ1w7f4zlrEGN1Oz1jcN8cFdSyD0cBf8FeXMrP1Y9dPnN8RpTX5N3QGYC+YIrMSr5EnMGjvjf/6wxRwcYnriWjKiEIp47BAuuZHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716396276; c=relaxed/simple; bh=mRzXmGLEv1Sl8l3NlQK6F2G7/wyMGAx0/1jAxVbxsrE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=imJA4b+JlujEKhx8VzZUD/RV7s8F8i6FxCPTaInL7i8DxXc0q+udeB5P5ELWSvysL/gXydlPovJzQSaCIrLVAzxSD7QBzQrwJrGcP1LMbs4XWQl+DOY2c/k82xf1qGJasV+oNJ4UBfB9jeJZe842OjSPE+wSS0byLq+WbgCrNt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=q4LFV16n; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=8Tfw1C5OBMTMu+sGe3XwcpMYANF6JY3ZkgMDDdPK8dI=; b=q4LFV16nCNg0Rizqr8jyU8IGeF AjtVn6vUasE2rVcjVzpGjksb+mOa2kwZMbL6rNU7JJjcpLXBfMmDxfdHYK8aoo0cVuGwSRc+d5w0N epsyLBEy/O/26r6YIZoOrJF3Yw+//6cD8xyzgTBE+WTCQdIoCKLEvFocS7Yc1Y3oK29U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s9p4g-00Fppo-EO; Wed, 22 May 2024 18:44:22 +0200 Date: Wed, 22 May 2024 18:44:22 +0200 From: Andrew Lunn To: Parthiban Veerasooran Cc: steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: usb: smsc95xx: configure external LEDs function for EVB-LAN8670-USB Message-ID: <9c19e0a1-b65c-416a-833c-1a4c3b63fa2f@lunn.ch> References: <20240522140817.409936-1-Parthiban.Veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522140817.409936-1-Parthiban.Veerasooran@microchip.com> On Wed, May 22, 2024 at 07:38:17PM +0530, Parthiban Veerasooran wrote: > By default, LAN9500A configures the external LEDs to the below function. > nSPD_LED -> Speed Indicator > nLNKA_LED -> Link and Activity Indicator > nFDX_LED -> Full Duplex Link Indicator > > But, EVB-LAN8670-USB uses the below external LEDs function which can be > enabled by writing 1 to the LED Select (LED_SEL) bit in the LAN9500A. > nSPD_LED -> Speed Indicator > nLNKA_LED -> Link Indicator > nFDX_LED -> Activity Indicator What else can the LEDs indicate? > + /* Set LED Select (LED_SEL) bit for the external LED pins functionality > + * in the Microchip's EVB-LAN8670-USB 10BASE-T1S Ethernet device which Is this a function of the USB dongle? Or a function of the PHY? Andrew