Received-SPF: pass (google.com: domain of linux-kernel+bounces-186509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 22 May 2024 13:48:18 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>, "will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"vasant.hegde@amd.com" <vasant.hegde@amd.com>,
	"jon.grimm@amd.com" <jon.grimm@amd.com>,
	"santosh.shukla@amd.com" <santosh.shukla@amd.com>,
	"Dhaval.Giani@amd.com" <Dhaval.Giani@amd.com>,
	"shameerali.kolothum.thodi@huawei.com" <shameerali.kolothum.thodi@huawei.com>
Subject: Re: [PATCH RFCv1 00/14] Add Tegra241 (Grace) CMDQV Support (part 2/2)
Message-ID: <20240522164818.GB20229@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <BN9PR11MB527641C15DD88FB0C44323D08CEB2@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB527641C15DD88FB0C44323D08CEB2@BN9PR11MB5276.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?xpmic/1U6haKO26vPmwLJFgbnsxdG+dt247By8h2KPOgfimlr1Kkz0Q69Vk1?=
 =?us-ascii?Q?7r22YK4nzrqjMMTIZENBf53xCMTS0a45wuVmmQEoKAGjvpOGtXOgvZG+milO?=
 =?us-ascii?Q?5idUfqCzETYUaYcpYTE7SKSVgzG5ggXr3zsmh4B17KWfbVKVSVb6HEaSq3l3?=
 =?us-ascii?Q?hWtXnNI22+ggbChZ37kbgQS3Y4su19J4NvoVuvBQptbQvjLtqKIUDxYA/sln?=
 =?us-ascii?Q?sD67GwRSSvKmafGbTIy5py10LJTQfH8yytPanAI6hIDs2hr6isx0Fu1WO1vw?=
 =?us-ascii?Q?BD0J+5qPJjKC0kdRYVphiqpzgguKuXBKISoL0rb5SkhMKewZuw/f55DrWZaV?=
 =?us-ascii?Q?dsOTeRSplBCsMf9ovIHpCDVaqUfljmg1f7RdEP16tmxAKY5A3K415lCigyl/?=
 =?us-ascii?Q?K/WIPOuHVvk7HqoJMUuJugeGOg6mDXOhpz+mG+rwo9YEYuygng0ygSgtwDVL?=
 =?us-ascii?Q?8RUzwdeasHILopNjnD6UnW5qIwXzPft9b0+Vsqi4PZduqhfj+2ZIU+cenC5R?=
 =?us-ascii?Q?RAvZ4KvACd9PbpvR7BYSff9mLl2bStc4cNCmj/t/knbjhF+Bj4SydoSSERux?=
 =?us-ascii?Q?TA4IXpfkXyb/1c6MI8e60++ycRHAbn02/Ovjnza+FGBogilUhgyRDfsWDQ5+?=
 =?us-ascii?Q?k64gaJCT9NUbPCfoCmQmnTo2dVw3UMXPUNO5UHiKHzds8NOQP0lmlGdj2Pfp?=
 =?us-ascii?Q?4pcvnsovz9Ypy+qb9ehG39v7H5vdfu06Ikcwaz6+zQ8qOEAffZH8NsizYphO?=
 =?us-ascii?Q?C8SlTxiPc4RAhct9OV9oMr67zgOoszWMDjZUP2xNcAcJrXXS1BOLpS6XWTnt?=
 =?us-ascii?Q?ph2gK0WZcukjpIcm/8bqHzeWTHzwtPaTXyottiC8KRjgfOD9hirLeZyIqHiT?=
 =?us-ascii?Q?OEFMGfLvIu8FVZzQM3mg6d8gavEZevlHdxX0fCmDJjPV30HWRsSFE3aRsuVs?=
 =?us-ascii?Q?H7B8ghawLBrUoZWk6l+ZC0Q7Q3ieE4UbQqDiZWzId2e5pEpucWkPUsyzLvb/?=
 =?us-ascii?Q?jA1RRfOps4jW0lR7XYZ4XKFn5rGEtNm6Ik855aJ6mBeg+doC2RQZJMtUufTC?=
 =?us-ascii?Q?q2QEAS8HFKnI7oZ/yor4hcvd9If2+UcAs8+WbHfTdD7xmYNgk+3SSVvmMY+b?=
 =?us-ascii?Q?9AcUDUfQZtOGUrEbYKvxHfEhc+XqF7c1tlWU5MSpHdlyzypYssgIkp+unpbI?=
 =?us-ascii?Q?rfkgsoK1lJYUr3XAbX1V/kpe5JBlhSZnDbdOgwkq0xS0iINF7ZESrydaCBJz?=
 =?us-ascii?Q?vaIW0YfA/CzRhQfCt/vAmsohKxDLYLzi2WmWRoYO7nb/BK8GJdSo++WeA7wQ?=
 =?us-ascii?Q?0vYVgo3Jf7Ue1WiGkN8KFbvaa1GenJEfc0a3y8gmt6DIVDDgwDIM+wSdumCh?=
 =?us-ascii?Q?M8HU6ls5EkbxP+HaKuSEx00ksnjx9t5qwEmuEqLkGu2RkovHQ9S3IRURXpz0?=
 =?us-ascii?Q?bjfhMbU3zo73hASWEw4maxsJzRbejw7WJN99waAjSzjFcI0Y0oWfsS6rAeIz?=
 =?us-ascii?Q?80XhV9fJBSQfvq9Q8RHQ0RVmJKYo/9dxqFYwfZhShymmQlW7r2u78x5AUGkc?=
 =?us-ascii?Q?moZhCjwjmjUv4yYH4zo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b87ef55-fc5c-4afe-ab45-08dc7a7efcde
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 16:48:20.7954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cK5MTYaGRQ0eoiNmWgDXuPuoyapJasXqX9FAYO9ZgpNJrUWoL5v2Y0A6rQHTt7Eu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4307

On Wed, May 22, 2024 at 08:40:00AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Saturday, April 13, 2024 11:47 AM
> > 
> > This is an experimental RFC series for VIOMMU infrastructure, using NVIDIA
> > Tegra241 (Grace) CMDQV as a test instance.
> > 
> > VIOMMU obj is used to represent a virtual interface (iommu) backed by an
> > underlying IOMMU's HW-accelerated feature for virtualizaion: for example,
> > NVIDIA's VINTF (v-interface for CMDQV) and AMD"s vIOMMU.
> > 
> > VQUEUE obj is used to represent a virtual command queue (buffer) backed
> > by
> > an underlying IOMMU command queue to passthrough for VMs to use
> > directly:
> > for example, NVIDIA's Virtual Command Queue and AMD's Command Buffer.
> > 
> 
> is VCMDQ more accurate? AMD also supports fault queue passthrough
> then VQUEUE sounds broader than a cmd queue...

Is there a reason VQUEUE couldn't handle the fault/etc queues too? The
only difference is direction, there is still a doorbell/etc.

Jason