Received-SPF: pass (google.com: domain of linux-kernel+bounces-186519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3cf3bbaf-8bc5-4ea6-aa9a-926075a1ac86@amd.com>
Date: Wed, 22 May 2024 11:50:45 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v2 5/8] ACPI: APEI: EINJ: Add einjv2 extension struct
To: Zaid Alali <zaidal@os.amperecomputing.com>, rafael@kernel.org,
 lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com, bp@alien8.de,
 robert.moore@intel.com, Jonathan.Cameron@huawei.com,
 dan.j.williams@intel.com, arnd@arndb.de, Avadhut.Naik@amd.com,
 u.kleine-koenig@pengutronix.de, john.allen@amd.com,
 linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
 acpica-devel@lists.linux.dev
References: <20240521211036.227674-1-zaidal@os.amperecomputing.com>
 <20240521211036.227674-6-zaidal@os.amperecomputing.com>
Content-Language: en-US
From: Ben Cheatham <benjamin.cheatham@amd.com>
In-Reply-To: <20240521211036.227674-6-zaidal@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TlFYQi9tVGhEMGwvOFBlakpYQzFuOG02ZUtrUFg4ckU0RERKSDM4Y2l0czdl?=
 =?utf-8?B?L2JrZzdvTzJqNVp3QVNYandiT3hTdnAyVkJ0Q1Z2WjN3Y1grS1ZiaGtaeUlQ?=
 =?utf-8?B?VGJvQVBGRlhCTjA4bk8vMjJONGtDaWFuU3RXeTVUSGVMRktxLzRoR0pjbFNW?=
 =?utf-8?B?eTB2Umk0d3gzT0ZsSEpyNk4zVUYzaEQ1OTBKNm81OXRPc1B6LzluM2Q3dFNI?=
 =?utf-8?B?UGxFd1V3eXl4NTlDWnpZeEtjMjBJdTJINlZ2OUw5aW5rRExCdGx2OGhSbVMv?=
 =?utf-8?B?emxEYnNuL2pkZ25JTHkxUGFrZnVRbzZPdXVYVUFvbzRaNXNieEhEL2l1NGtl?=
 =?utf-8?B?Sm5CN3kwRnhYN1NMVkpsNWxMTTVjNGhXZ0F3UlZGbWlrR0lVQVZ1RThFL3Av?=
 =?utf-8?B?eFJNUXdSZmRBN2kvb241c2d6YjlEYXFia2hNUVFrK0pEanVMaThoR1FaOTRt?=
 =?utf-8?B?aGlkcE9SWGhlQTJGeTRaVDZZTlF5MnljTTF1WVp3aldxb2c4ZGltMFR2UGVD?=
 =?utf-8?B?Zll5TlF5aWFtMXBFVmZtUTJJNGJQRk45b21jbVdqZU03R244eEVuMU9zRFV5?=
 =?utf-8?B?RkUzMGQ2N1UwbFQyVFpVMzlPeVZqMXZBYjFKaGtwWVJLOW9LREhGNk9kWXFW?=
 =?utf-8?B?UGVHc3lHVWQvTVQ4TjVKQkxLNmJCR0RGL280cEhFb2oyaUFid3JyUkZnS0ov?=
 =?utf-8?B?QnpucDRjWTJIRDh5Um1lWHJ6bWtSS0ZLem9ObXF0bDRmb1IwU1dDL3cwWk13?=
 =?utf-8?B?cXdzVUVkY01VUVRSYnJwOHc5T0VSNVg4R0NmUUxpM0VWN3ZnZ3ZmcFJzc1Y4?=
 =?utf-8?B?TnRCUWZkN2dGTFhQVHhJMFlzTzVmSGkxRlc2ZHBsZ3VTWDNGUmFLd3NkUmdu?=
 =?utf-8?B?NjhsbmFBWGZsUExndHlnUFptTGpBTUFCVk5qM1FuUjhDaGQ2VFNha08xNi9u?=
 =?utf-8?B?bThJeVZpbWFyRHBZTExoUXo5eE9CVXdUWlhZb3VWUnhTY2VvNUszVk5FcmpM?=
 =?utf-8?B?cWhkTno5cnVjbktMb0s5TVZ1YmFmeXBUTUk4SmJUS2V5MDNkSmR5dTh4U1Fy?=
 =?utf-8?B?SFBhdk1UYmx2WG16Ymd1TEJtcHNMQXo0bmF4a2RBMlA0Z0h4WFJpTW04WUx4?=
 =?utf-8?B?eHRnKzZrRGJFSDJPWVBaT05CTk9NdHpLcHUrZXBUMm95UVRuTFE4b3YydFNG?=
 =?utf-8?B?K1FQRC8zRGdnUFNPcVA4dUREbVV2REZCeDYxajNUUXhCN0xuNnNKWlZVTkRx?=
 =?utf-8?B?SCtnRTdCRG85Q2VydkxtUTU5TnJrc2FOZ21EYmZubEVsbzNndTVHTlp6RkhP?=
 =?utf-8?B?a09Nbk8ycWV4L1lYUnFwdmJqMTVhN0tOc0NUaUFVZnZEaGNKT1NtVXBRTDdX?=
 =?utf-8?B?QWtBanhlZVk3VG9pcE1KQ20vSDhTM1IreVY3dXlqc0tjTUFtb1Z0cTNWYjZX?=
 =?utf-8?B?dkY1TSttYzRKMkxvcHNkOEk2WUtLaS9MelU3U2kxaUFrbTd6eXI3bTQrY1Fp?=
 =?utf-8?B?WmNNWW4xbnFERTdrVHRXTS9KSWlaNXVaRy9uY3BTWElOZFpnMkZIb3cvNHNa?=
 =?utf-8?B?bmYyL1E4M05HNy9WNmdDWlJoZTQxcE5XcDVocjk3b2xpM0pQajVhMzkvSUtT?=
 =?utf-8?B?Wm53Ym9TL2kxWENxcTBsTC9LeXg0L3pZa1B1NGk0WFZiNXNDMGVHTTZpek11?=
 =?utf-8?B?Mng2YUJjWmZYY3psMUh5cEN0L3BLT2VwQVB4LzJkck50WUc4bE5KeE9zdENQ?=
 =?utf-8?B?cEVDWjZUZjdTTVk1bW5jQzVqUko0MkJDK2pVcDFTaU0rZ1dRemQvS1dzVmRZ?=
 =?utf-8?B?dDlQN3J6M0l4cHdwTExPcXRaYnZqT251ekEzOG51aEM4U2JaN0lxQlNtMS85?=
 =?utf-8?B?OG9Iem5QZi9yM0o2dmZJNmdmQzVVVkZ2Y1JWZXZZd0hBRTI3Ry9DSmNWdzhL?=
 =?utf-8?B?RUp1blpHTWtXWnVZZzdNODJoQjRHTUlYcXBRMWdwcmZSZmgyc2lDdVBKTWJI?=
 =?utf-8?B?UkNlMi95bUthTXk1OC8vTW1HUVJLVVhib0lBL043T0JDUGh5YytYNWlabDdX?=
 =?utf-8?B?dmYvTU80U0hoVGhxa1ZSbkJ2bW1xUGprejFPMHdzdjRjWk1GKzdtRUZVRTdK?=
 =?utf-8?Q?8hHgX/yJFQX4ogHY4VOm22hcc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85706df6-2b34-4fd5-1b41-08dc7a7f549f
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8535.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 16:50:48.0092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t7ln/iUhgucWFmRcwr5anGWnqsmg42x7aSmwIidZcgN7T6oLn3+Y9vD3x+MMfOnUCB4vmWsm7KLyx/60fNzKYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6570

On 5/21/24 4:10 PM, Zaid Alali wrote:
> Add einjv2 extension struct and EINJv2 error types to prepare
> the driver for EINJv2 support. ACPI specifications(1) enables
> EINJv2 by extending set_error_type_with_address strcut.
> 
> Signed-off-by: Zaid Alali <zaidal@os.amperecomputing.com>
> ---
>  drivers/acpi/apei/einj-core.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> index cc5ad1f45ea4..2021bea02996 100644
> --- a/drivers/acpi/apei/einj-core.c
> +++ b/drivers/acpi/apei/einj-core.c
> @@ -50,6 +50,28 @@
>   */
>  static int acpi5;
>  
> +struct syndrome_array {
> +	union {
> +		u32	acpi_id;
> +		u32	device_id;
> +		u32	pcie_sbdf;
> +		u8	fru_id[16];

I would rename fru_id to vendor_id since this isn't necessarily a FRU id. It also has the
added benefit of matching the naming of the vendor field in comp_synd as well.

> +	} comp_id;
> +	union {
> +		u32	proc_synd;
> +		u32	mem_synd;
> +		u32	pcie_synd;
> +		u8	vendor_synd[16];
> +	} comp_synd;
> +};
> +
> +struct einjv2_extension_struct {
> +	u32 length;
> +	u16 revision;
> +	u16 component_arr_count;
> +	struct syndrome_array component_arr[];
> +};
> +
>  struct set_error_type_with_address {
>  	u32	type;
>  	u32	vendor_extension;
> @@ -58,6 +80,7 @@ struct set_error_type_with_address {
>  	u64	memory_address;
>  	u64	memory_address_range;
>  	u32	pcie_sbdf;
> +	struct einjv2_extension_struct einjv2_struct;
>  };
>  enum {
>  	SETWA_FLAGS_APICID = 1,