Received-SPF: pass (google.com: domain of linux-kernel+bounces-186523-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 22 May 2024 13:52:21 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"luto@kernel.org" <luto@kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>
Subject: Re: [PATCH 4/5] vfio/type1: Flush CPU caches on DMA pages in
 non-coherent domains
Message-ID: <20240522165221.GC20229@nvidia.com>
References: <20240517171117.GB20229@nvidia.com>
 <BN9PR11MB5276250B2CF376D15D16FF928CE92@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20240521160714.GJ20229@nvidia.com>
 <20240521102123.7baaf85a.alex.williamson@redhat.com>
 <20240521163400.GK20229@nvidia.com>
 <20240521121945.7f144230.alex.williamson@redhat.com>
 <20240521183745.GP20229@nvidia.com>
 <BN9PR11MB52769E209C5B978C7094A5C08CEB2@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20240522122939.GT20229@nvidia.com>
 <20240522084318.43e0dbb1.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240522084318.43e0dbb1.alex.williamson@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?t2swGWIkcAp+E9dcrR+KEVwsCEZq4iM1NhlRMoIw1npadt2/XpPETOyaf6Rt?=
 =?us-ascii?Q?XduOzZWRjHnFeUeqcjp9lDPe6VxuxQGlJmorIyWGReVI+3bVuu/a4chzM4xY?=
 =?us-ascii?Q?haif1K6RZRmvC43RMjOj1QzoQA2ikZcSwqeUQKgCpl+nheow2i5X6q3o8zWc?=
 =?us-ascii?Q?zDyTF6RaTsphYk7uNAo1Q0EsAr0sq0XO7x0f9uNf7+jOfwwVxa8uGSfVfbYt?=
 =?us-ascii?Q?e49a79zQ3d3fjgeFvi/0UdszUbBX4fP2dX+MaZnfqQ30YFNQhblPlgtr+NUq?=
 =?us-ascii?Q?Ira62MEQILaz8qind747Rj7Vl3pfUxI4azjy/IAZNv6fE0u11bJszhK5z35w?=
 =?us-ascii?Q?yOjpF8XUp+BfYgbBuxRF9y4eFCKhj+doInWSEywVd6SNCaDkV7yr64/phlJg?=
 =?us-ascii?Q?NU689rFGkPjz1v5J8mLjSYqv1xJrbiUA0LYNtuz6Z8pDsqVnEqZ9XZOf8A9T?=
 =?us-ascii?Q?S0gH5dtXjHFXSyE50vTu3UZk2AxewJDcbsCyWopR8GUTh1/uC4JM24RJNGeh?=
 =?us-ascii?Q?UT0ZA7uGINHhXdKI6cjtnC4bFsM9NLf3u9PCOK5Xq1ZFsLwzRrRjZK36Vhs+?=
 =?us-ascii?Q?7Cw8Nfzn7RwUAddzFxJFPZizbbZhiVxIs/qiKYDrkcXSQEM+8EU/sStfZzEi?=
 =?us-ascii?Q?I+2sJvO9i+tClv74lTi97N/iwUf9PdS3sMeSWg/kY/SixmEVScaGBq0wPQk+?=
 =?us-ascii?Q?+unYvASeUb4ANR7AMOpJ/V1f3QlyXDnd4+xD+SwxRgWGXN0UHbMLeAlq1UqR?=
 =?us-ascii?Q?SflDjRuSeJeCC4FBKhOM1kbDd5g3Qrpqa4kg9236cV8M9i2DfDXCMId2nivw?=
 =?us-ascii?Q?M8SG7zUHGzj1SXK5ITsCyqncYfufjpdtTgLt+ojCcUMod0r4BdSY24xntX8J?=
 =?us-ascii?Q?7LfKT5e/cGhNAwbeF1SlyAHhOc2C+ypJESzdqd1jWqCmFjrQKCiJv1Cp05iU?=
 =?us-ascii?Q?NYN9ybSHNERpCWLMMDSxnWWFMp6SP/2aajaJQQoKtIbGHjSDQKynDX3sPejM?=
 =?us-ascii?Q?iQjs6jDk66dSTvLqMmLO/7AY7WA76DV7jTl9GuC8BgDvPg4ENFnWkutVM1ay?=
 =?us-ascii?Q?jXzxfbudTe/YQvT4gKggZzRD3zJeDvKxOPnj3vT/FbDQ2rdMWMuTplSwdPiJ?=
 =?us-ascii?Q?W3jhTfkAmuDYda0QFZYxueKAlBqKFPb7mN2Oot8m48EnAiaZrG5GCrAYoWxF?=
 =?us-ascii?Q?KqJLwxxUhBYB7sk4V1b4Dgn9pjWyB4KsbnOlkKhgm+/raF9FBInjXKs8IPj5?=
 =?us-ascii?Q?46cO/dWDCDXuh6HZjW2ZZKty8JWSMXWvSJs+xW5UK6138gsl8Tfu43W9Ou98?=
 =?us-ascii?Q?Qq4LAfzrM+0XtQcPI5APuVMS41kIeowiCH6mZ2FUWmPdqscbv5oHY8U8lOmp?=
 =?us-ascii?Q?4XJdn0cDn19FTOy1oAg9GBbyBwy/nL/7n86Ba5sz4Pj+0vsaYGKlg3yUO3r2?=
 =?us-ascii?Q?MTB9KKDuwSNNpU62HfMQBbDEiGbFg+OgkgQRBiRUk0RgJFcV3PhWGHk3sAM3?=
 =?us-ascii?Q?nyff/xm7sxSQ9qW80YtVQq/M/DsFh+gSpfBpt8TNSQGPcpC/eeaooFDS/Yp4?=
 =?us-ascii?Q?VvUXSzuCE+hDRGFfa9o=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e634c2a-b1bd-4d0d-557f-08dc7a7f8dfe
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 16:52:24.2552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ccOMmMXrz1k3sfFWeLRVCmE5zfRRetM23O9G3QIuhLQOVMaLpJbvymhW21YUQlp8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7094

On Wed, May 22, 2024 at 08:43:18AM -0600, Alex Williamson wrote:

> But I think this also means that regardless of virtualizing
> PCI_EXP_DEVCTL_NOSNOOP_EN, there will be momentary gaps around device
> resets where a device could legitimately perform no-snoop
> transactions.

Isn't memory enable turned off after FLR? If not do we have to make it
off before doing FLR?

I'm not sure how a no-snoop could leak out around FLR?

Jason