Received-SPF: pass (google.com: domain of linux-kernel+bounces-186580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b199a7bb-6d59-43b1-9a7e-000c661b00a5@linaro.org>
Date: Wed, 22 May 2024 19:58:29 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] spmi: pmic-arb: Pass the correct of_node to
 irq_domain_add_tree
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>, Bjorn Andersson <andersson@kernel.org>,
 Abel Vesa <abel.vesa@linaro.org>, linux-kernel@vger.kernel.org
References: <20240522-topic-spmi_multi_master_irqfix-v1-1-f7098b9c8804@linaro.org>
 <CAA8EJprgXSF=x834=PRXrHhh7VRyynbApnO-iFoE=cLYFzM6iQ@mail.gmail.com>
Content-Language: en-US
From: Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <CAA8EJprgXSF=x834=PRXrHhh7VRyynbApnO-iFoE=cLYFzM6iQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 5/22/24 14:06, Dmitry Baryshkov wrote:
> On Wed, 22 May 2024 at 14:38, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> Currently, irqchips for all of the subnodes (which represent a given
>> bus master) point to the parent wrapper node. This is no bueno, as
>> no interrupts arrive, ever (because nothing references that node).
>>
>> Fix that by passing a reference to the respective master's of_node.
>>
>> Worth noting, this is a NOP for devices with only a single master
>> described.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   drivers/spmi/spmi-pmic-arb.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
>> index 791cdc160c51..46ea93f78dcd 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
>>
>>          dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index);
>>
>> -       bus->domain = irq_domain_add_tree(dev->of_node,
>> -                                         &pmic_arb_irq_domain_ops, bus);
>> +       bus->domain = irq_domain_add_tree(node, pmic_arb_irq_domain_ops, bus);
> 
> Shouldn't it be &pmic_arb_irq_domain_ops ?

Yes. Between testing and editing the patch to un-break the line I managed
to.. break the patch..

Konrad