Received-SPF: pass (google.com: domain of linux-kernel+bounces-186625-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <bcbe109d-5974-428d-b74e-c29bec9f68b0@gmail.com>
Date: Wed, 22 May 2024 21:49:41 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
To: Mithil <bavishimithil@gmail.com>, Krzysztof Kozlowski <krzk@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Lopez Cruz <misael.lopez@ti.com>,
 linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240522075245.388-1-bavishimithil@gmail.com>
 <0594944d-c158-4840-8724-b3f2edaab1ca@gmail.com>
 <4f722e53-011f-4176-b6af-080522165007@kernel.org>
 <bb44d588-9316-4509-b545-9bbaa2d240cb@gmail.com>
 <3c6c5be1-fb8e-4bf0-9f58-cfb09672e8c1@kernel.org>
 <d999bc26-9bb1-44a8-92a3-bcbe14c5a1c3@gmail.com>
 <58ada5ce-5c02-4ff5-8bdd-d6556c9d141f@kernel.org>
 <CAGzNGRm5i8zvnXiPzMg5=+tr9oyBcRA8LFvnmgGzE=MzSNTXug@mail.gmail.com>
 <e384272a-4dfe-4653-8983-6426f8803c84@kernel.org>
 <CAGzNGRnsmRWzimUX5tEC2-Y44aa4i9Lbdp8YJ+oneV4ujs4qBA@mail.gmail.com>
 <CAGzNGRmTR_nK0SoWG8uqDfRzDShs7sR+Mc+44__SBi0CR5LKEg@mail.gmail.com>
From: =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
Content-Language: en-US
In-Reply-To: <CAGzNGRmTR_nK0SoWG8uqDfRzDShs7sR+Mc+44__SBi0CR5LKEg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi,

On 22/05/2024 20:47, Mithil wrote:
> My apologies, misunderstood the error.
> Proposed changes for the next version,
> Add dma, dma-names, reg-names properties, and do the changes in
> example (rename node to mcpdm since it is different from generic pdm).
>   reg-names:
>     items:
>       - const: mpu
>       - const: dma
> 
>   dmas:
>     maxItems: 2
> 
>   dma-names:
>     items:
>       - const: up_link
>       - const: dn_link
> 
> examples:
>     - |
>     #include <dt-bindings/interrupt-controller/arm-gic.h>
>     mcpdm@0 {
>       compatible = "ti,omap4-mcpdm";
>       reg = <0x0 0x7f>, /* MPU private access */
>             <0x49032000 0x7f>; /* L3 Interconnect */
>       reg-names = "mpu", "dma";
>       interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>       interrupt-parent = <&gic>;
>       dmas = <&sdma 65>,
>              <&sdma 66>;
These can be in one line to make it nice and tidy

>       dma-names = "up_link", "dn_link";
>       ti,hwmods = "mcpdm";

The ti,hwmods no longer needed since the sysc conversion

>       clocks = <&twl6040>;
>       clock-names = "pdmclk";
>     };
> 
> Remove ti.hwmods from required since some dts like
> omap4-duovero-parlor, omap4-panda etc do not use it which causes
> dtbs_check to not pass.
> 

-- 
Péter