Received-SPF: pass (google.com: domain of linux-kernel+bounces-186681-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <97567de0-895d-4a23-907f-506551e86362@gmail.com>
Date: Wed, 22 May 2024 21:46:22 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] hwmon: (ltc2992) use
 fwnode_for_each_available_child_node_scoped()
To: Guenter Roeck <linux@roeck-us.net>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Daniel Scally <djrscally@gmail.com>,
 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
 Sakari Ailus <sakari.ailus@linux.intel.com>, Jean Delvare
 <jdelvare@suse.com>, Antoniu Miclaus <antoniu.miclaus@analog.com>,
 Jonathan Cameron <jic23@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-hwmon@vger.kernel.org
References: <20240522-fwnode_for_each_available_child_node_scoped-v1-0-1188b0da12dc@gmail.com>
 <20240522-fwnode_for_each_available_child_node_scoped-v1-2-1188b0da12dc@gmail.com>
 <57645247-fb14-4180-bef0-1638e9f522fe@roeck-us.net>
Content-Language: en-US, de-AT
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
In-Reply-To: <57645247-fb14-4180-bef0-1638e9f522fe@roeck-us.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 22/05/2024 21:08, Guenter Roeck wrote:
> On 5/22/24 02:18, Javier Carrasco wrote:
>> The error path from a zero value of the "shunt-resistor-micro-ohms"
>> property does not decrement the refcount of the child node.
>>
>> Instead of adding the missing fwnode_handle_put(), a safer fix for
>> future modifications is using the _scoped version of the macro,
>> which removes the need for fwnode_handle_put() in all error paths.
>>
>> The macro defines the child node internally, which removes the need for
>> the current child node declaration as well.
>>
>> Fixes: 10b029020487 ("hwmon: (ltc2992) Avoid division by zero")
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> 
> I really don't like fixes which depend on an API change.
> 
> Guenter
> 

We could split the fix into two steps as suggested by Andy, where the
fix would simply add the missing fwnode_handle_put(), adding the
corresponding tag to include it in the stable kernels (the bug was
introduced with v6.7). By doing that, the new macro would not need to be
backported, which is probably a safer approach.

The patch with the new macro would be left as it is, and another patch
would convert the the loop to use the new macro to avoid that a similar
bug arises again. That would be this 2/2 + dropping the additional
fwnode_handle_put().

Best regards,
Javier Carrasco