Received-SPF: pass (google.com: domain of linux-kernel+bounces-186685-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: <Woojung.Huh@microchip.com>
To: <Parthiban.Veerasooran@microchip.com>, <steve.glendinning@shawell.net>,
	<UNGLinuxDriver@microchip.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <Parthiban.Veerasooran@microchip.com>
Subject: RE: [PATCH] net: usb: smsc95xx: configure external LEDs function for
 EVB-LAN8670-USB
Thread-Topic: [PATCH] net: usb: smsc95xx: configure external LEDs function for
 EVB-LAN8670-USB
Thread-Index: AQHarFGdf9peQKRqvUiYmjubDYZguLGjqggw
Date: Wed, 22 May 2024 19:52:50 +0000
Message-ID: <BL0PR11MB2913394A02B696946324E830E7EB2@BL0PR11MB2913.namprd11.prod.outlook.com>
References: <20240522140817.409936-1-Parthiban.Veerasooran@microchip.com>
In-Reply-To: <20240522140817.409936-1-Parthiban.Veerasooran@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6IJXU+wqdDdoAd/ObB9/oAArBKVTSAalM5vbU9Wbjhb/y1J5m0zTJkCqmC5n?=
 =?us-ascii?Q?hyAOEaz7vbqab998CytNDACRxtDoSr2fpLb/2s6wFQvTha/TI2C49ndi9AOY?=
 =?us-ascii?Q?M4vmOGiNCzc7T8KEdVhOgmw2X5NKfarDT0TgaERa1qQkOdydm7iyAawfOl+S?=
 =?us-ascii?Q?UBjPrhaTUoTajc7j0DfLvKQyYwJPf26XlTCabvSkNz8Rk3Bu+C9sgQupfdp5?=
 =?us-ascii?Q?n8T30CAKZum3qLLHe7IVPwhxiwGDJ8QPqWHihVSgXo85elOjvOZT6sIVqD7N?=
 =?us-ascii?Q?O8lZGZjPHSw8LeIeL94VOlnm1lmEM6ZzXROfbjCzBTuy/s5Sbrge7iOlnDBw?=
 =?us-ascii?Q?RDWU0TjYGz6//uVCl3g2WABC7z90IkJuXNCLZPrNVkAEMyBojmCAc0UQ6OGh?=
 =?us-ascii?Q?ouGJhN14TBKeaUj2rnrDxLYtQctO3w5FZRHkMHxnxqajd6CPhh7/+Z4/xdZT?=
 =?us-ascii?Q?MkmH2jH34gWECwog3++KnI1oEgp3iNw4VdKwkrB71qHWej3VG7nRpHcu4PV+?=
 =?us-ascii?Q?89ahdM0ctfP1AW4TlnB8F6sjaOQmWzOXpzu02MP8Xfvv+ZJw2kWrPaMbijm6?=
 =?us-ascii?Q?wFQ4QXevPZTAV9IQt70JsWPC7FaQCD+Nun39JJ5e+7rX/HxjHZ6hZK9q6cz4?=
 =?us-ascii?Q?ruFrsx21B6J8BtPtXHVaFZ0ci98yb8kKpoykJoM8KTb/0gUng/F8W7gYJZyx?=
 =?us-ascii?Q?X2+h2SAW3/nhRRXgqZ0/49mrmTyeCCTtucYdIpMKmnBxKLdQeK17SqgjB0Xj?=
 =?us-ascii?Q?xMBXoO+pfDwDUdU4aMCdxWemEUOd9CXUpEB9fssPqx4q9QjMEiDQp8+hqh9Y?=
 =?us-ascii?Q?WMc5PwuaoeeeRLcs2V2mMekA0tKF9FnB1HuQ2b8epF6WUo4KObaUBpz+FV3S?=
 =?us-ascii?Q?QxcEAVNREYQYX1j/mo9ikDHbOSjVQxsK0lvFcj6qNeWZznGR+ZenVSEjc1Kl?=
 =?us-ascii?Q?LIyY/SzmFdkknLGWadMlP01OoRxGnz5/Ts1NSaFzF3Gxwtq8tSh3kzfCO/TF?=
 =?us-ascii?Q?/WAVx53crPYuv4+LJY/sW1vIbcyxyV37ur+G7iiO5ohOTRxYip3g6t0Jyozi?=
 =?us-ascii?Q?Sv/cPt6lb2qV5/Q2N1Y3RYUk2qZlrrYJLVJk+cDog6/XnFTxu9ShgMhpaXjR?=
 =?us-ascii?Q?zskBtEk/0YRP37TbPFnIi3mGyJzSM9+2Bv5p++gamFoNBGbSFUEfW/huynNb?=
 =?us-ascii?Q?6PiaN7tfSVHtizvZ5vcS3pfPKD/c9OWg/97wSQa1U+ISVP0SwN+2fyLlLAYN?=
 =?us-ascii?Q?K4NHyId3wWWfoaZ7f5uqUFY9AHrqJGO0cAorgT9AKzRPOKkl0P1/G0UeN3kN?=
 =?us-ascii?Q?2SZQ6gp8fewl+es86v/iCy2IISSuhzjrYFFbUrGwzs2l+b+O8jU+kqjmQmKo?=
 =?us-ascii?Q?XfnoF+wMspgU6T1fzlYbN+gGdOJWqHnNLjjAn/TD/cinaNIBV3B9zMfRPPZY?=
 =?us-ascii?Q?7QPUHMFDD9B7PBJ3i1SBtHuCr+p5msAU3waBu4n9U+YBo2mz0DZToWoH0wOl?=
 =?us-ascii?Q?R5WThDEhxwS0W3Iu6gpnZOlCxaVE35fhxpCgtrF+BVDNbiMElbelD3P1YROt?=
 =?us-ascii?Q?5DTSiWEr03Vbl9H/S4dDlLidhsJfTRzCAXS3k+dR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2913.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74ae586f-afd9-4bd4-9cfd-08dc7a98c2dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2024 19:52:50.2096
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MYApKBn5+SSoRxt+5L+6cSDimNhAUHayajbtiPRAuI8lgTYUqpjwY3lNoTx8O2n/n3adRvwgkBDRv7htDLhBAZz0li3XZSkuHCbQsvlc8II=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8381

Hi Parthiban,

LED_SEL is configurable option by EEPROM which should be populated on
EVB-LAN8670-USB. I would suggest changing EEPROM configuration than
hard-coded in driver code.

Thanks.
Woojung

> -----Original Message-----
> From: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
> Sent: Wednesday, May 22, 2024 10:08 AM
> To: steve.glendinning@shawell.net; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com
> Cc: netdev@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; Parthiban Veerasooran - I17164
> <Parthiban.Veerasooran@microchip.com>
> Subject: [PATCH] net: usb: smsc95xx: configure external LEDs function for
> EVB-LAN8670-USB
>=20
> By default, LAN9500A configures the external LEDs to the below function.
> nSPD_LED -> Speed Indicator
> nLNKA_LED -> Link and Activity Indicator
> nFDX_LED -> Full Duplex Link Indicator
>=20
> But, EVB-LAN8670-USB uses the below external LEDs function which can be
> enabled by writing 1 to the LED Select (LED_SEL) bit in the LAN9500A.
> nSPD_LED -> Speed Indicator
> nLNKA_LED -> Link Indicator
> nFDX_LED -> Activity Indicator
>=20
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com=
>
> ---
>  drivers/net/usb/smsc95xx.c | 12 ++++++++++++
>  drivers/net/usb/smsc95xx.h |  1 +
>  2 files changed, 13 insertions(+)
>=20
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index cbea24666479..05975461bf10 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1006,6 +1006,18 @@ static int smsc95xx_reset(struct usbnet *dev)
>  	/* Configure GPIO pins as LED outputs */
>  	write_buf =3D LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
>  		LED_GPIO_CFG_FDX_LED;
> +
> +	/* Set LED Select (LED_SEL) bit for the external LED pins
> functionality
> +	 * in the Microchip's EVB-LAN8670-USB 10BASE-T1S Ethernet device which
> +	 * uses the below LED function.
> +	 * nSPD_LED -> Speed Indicator
> +	 * nLNKA_LED -> Link Indicator
> +	 * nFDX_LED -> Activity Indicator
> +	 */
> +	if (dev->udev->descriptor.idVendor =3D=3D 0x184F &&
> +	    dev->udev->descriptor.idProduct =3D=3D 0x0051)
> +		write_buf |=3D LED_GPIO_CFG_LED_SEL;
> +
>  	ret =3D smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
>  	if (ret < 0)
>  		return ret;
> diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
> index 013bf42e27f2..134f3c2fddd9 100644
> --- a/drivers/net/usb/smsc95xx.h
> +++ b/drivers/net/usb/smsc95xx.h
> @@ -114,6 +114,7 @@
>=20
>  /* LED General Purpose IO Configuration Register */
>  #define LED_GPIO_CFG		(0x24)
> +#define LED_GPIO_CFG_LED_SEL	BIT(31)		/* Separate Link/Act LEDs */
>  #define LED_GPIO_CFG_SPD_LED	(0x01000000)	/* GPIOz as Speed LED */
>  #define LED_GPIO_CFG_LNK_LED	(0x00100000)	/* GPIOy as Link LED */
>  #define LED_GPIO_CFG_FDX_LED	(0x00010000)	/* GPIOx as Full Duplex LED
> */
>=20
> base-commit: 4b377b4868ef17b040065bd468668c707d2477a5
> --
> 2.34.1