Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp592281lqp; Wed, 22 May 2024 13:25:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWxycprwliOy8fDQxBiYDjXCFEthV0wZFc6fPxP9JPg+EEBYqqvE5V+ZekUco8tqWlclYT699otlNKUmLOxZG7Tyv7KpdBmZVEGSyUxcA== X-Google-Smtp-Source: AGHT+IHUSYnRTQ2wNgNQm89kBtM3BIsruuvLWMzBhBdllYvgwwYTGwLKLgAhCxAr/GCKUfPxysxM X-Received: by 2002:a19:2d18:0:b0:51b:9254:91e7 with SMTP id 2adb3069b0e04-526c1215214mr2481680e87.61.1716409544597; Wed, 22 May 2024 13:25:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716409544; cv=pass; d=google.com; s=arc-20160816; b=Y/zH5YQjKbfPQ9ot5CTKF6HBCDiCrYlDqT3wuWSrvCtHA+wDeLU5vm5+ORGvEFamcY kpGloeGdLjB9jYqZ0iSWz1BXcUx+2+UzMWeWJJbwKt3qt2oWPFqYdFI7DDR87pspfgEq 1BkMP6AcHePOpagJi7EB8WNXryhE84blXEiA2VDCdhwv8qPVloj5uL45G1xK5hlfsWfZ LjkvfhonyFb/falHhDdXNErTX787XPNEACHMcS/bmDDDC5jFwdlXL8NFDjXSpSe/qL8g 9Cy5VLfchB+NOM9D4TJhRNAUgK5QwLzYxWDuUYF6PpqnhZc/nCetK0fYZR5BdeQiTR3e /UBQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:cc:from :content-language:subject:references:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=HkwD7TSpNFck9Pz42Pa/zrMVWZu+W0Oh5FLIwzj9QLg=; fh=ee8F69UZ9ti6wGK3FZ9GRI+0NgsfGLsLI5NjIRCiY3U=; b=hDO0dY9lLefkaxJtdbLQcVabHQLwXU/yKZWMBuauJAmSf7qUzw9v+OyuM+3V2JHU0Z Cc9njXvBTL1a5rbTCY1QTiPpIoxAwpMV9qs2XhHg8gvrp8PGoL6hjrvJIpnZZAUexBqz ihsr6mYRt8e8rgP255c9kbOB7F/ocpgStxr7xpMdtCR9OWSU7I1zYenZpyHz19hqCiyB Ub/slKJ4bOTNRmMDU8dQDoJs9rcVMckwP/Kw/bdbZ3gg/ByIcLcew4Q84GeTOTceMFCL VJs8u0KdGjE7cOUQknfJVp6oTs8aUVD66WqLuHCGvKXcMmL5FQXE6sfqqNOjjIMfqtvS FJug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=l6pyeiSJ; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-186690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186690-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17b21a5fsi563806366b.404.2024.05.22.13.25.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 13:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=l6pyeiSJ; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-186690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186690-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3E8851F21AAB for ; Wed, 22 May 2024 20:25:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 552C6146A84; Wed, 22 May 2024 20:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="l6pyeiSJ" Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D20C828F0; Wed, 22 May 2024 20:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716409533; cv=none; b=d/1B3H4trBfX7iA5ytkfW7NjDpzxa2Ant1hWj/4N590Wa6ViB4LUE1nI4KoG3eoLoa5axgVMEq5S2Rp3xcuXBH9RzCYLJiWKUtjEXoc5jevw+uuC9Ik7s3Q2HN1xIdE/RY4TxSAb0zDLmboGSTUc6itX8GSBvTcA5GXI5X5xjaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716409533; c=relaxed/simple; bh=i5YeBElyyeAgBzFvmLeCign/ZZTOXVpIXph9q9KRSNU=; h=Message-ID:Date:MIME-Version:To:References:Subject:From:Cc: In-Reply-To:Content-Type; b=BO8OFbjY7kVCEtuzkeqYwlT4AiDcZdno4ZLwkZTawNPOSwdUsZ3Y8CYG8bhvLIJtVDjXaFgBqNczIug7dXSEHTkA4GU1Au3SkHhc+uRUdKyNrhIgOk3sJp97mR5JlHkwIFUhHMaVx8mJi5twfrDrLVLExlWSDZv3Wo0rgRcE96Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=l6pyeiSJ; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716409520; x=1717014320; i=markus.elfring@web.de; bh=HkwD7TSpNFck9Pz42Pa/zrMVWZu+W0Oh5FLIwzj9QLg=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:References: Subject:From:Cc:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=l6pyeiSJrV1Szt1VVh7n6lgikHN6RLpaXjpXFxs41UzLOU5cZ3kCivjkKCAD/klM fthgmVJjSSrjneDGE8+ot7Aa1h3EqKmxtm1KukElsk/vaZ51kSkZCv1CWMA/MAUn0 RknIhrJ5n9F7//j9xJYBacAQ/Nm8CSznXoetiraxQWeD0mOKAtq4MHXisUvkpUEmi 5vXbySkZxwF6WTTDFdljaBoF54GTRkkkEuQYOAKsxVLFPhjZmWpX08YhEmlsrQVpq 62fqBdg0SkoaNGbotSvD1mqvUqlQHYQYnB8wkJlXg1HNBOjg7Z+vJaNM5cCfpw/2U O5yXxvYOV2kOrlQs2g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.82.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MmQYX-1ssK4s3ojB-00iK6Q; Wed, 22 May 2024 22:25:19 +0200 Message-ID: <5ed339a9-82cb-403d-92fd-fdcb18653f72@web.de> Date: Wed, 22 May 2024 22:25:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: John Keeping , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20240522100341.1650842-1-jkeeping@inmusicbrands.com> Subject: Re: [PATCH] Input: ili210x - fix ili251x_read_touch_data() return value Content-Language: en-GB From: Markus Elfring Cc: LKML , Dmitry Torokhov In-Reply-To: <20240522100341.1650842-1-jkeeping@inmusicbrands.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hCnH6YciGuPD/GgNskigEv6YNstG+WJ2woxlLKGBJXmNkJsC0ja rZ2LmOdFKo+44VhhVAW4pfU75My0zLSWzoGt6qAlKcyqILvKDwxiopEple6/pk55Es9fMiL eZE2DvGlVPxI+2I976W/O0Dt8VNQWjAuQwpBzckbFn+E6mkCFi6htpw0ot3rSsZZkQjzQIc P5ZfbOC9mHrftrDY2/heA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bEXtXTs4R90=;egPiOca3X35QYWaxy65sV6JrrHD bF1FNBgp0aY082IBCstnJrg0arJuqdYiV3/f0fc4wlqSYEnLKpIulQbfoiNnptFUWlplsIGTs 6qi7KMXZ5k9Iq1L4UzrG4NlHa0rifdci9MNKPagknLxagUfCoPajvQkpkNYrJUO56Ct77+p9+ YeBEzUvD0YBgHuGG7D7BunoXOaTS6iKY4E02r05wniJbaoUY0POTNg2FiDXzHuQYAHZ+ZZbyK NRxf5ngk5d9eQH2iwELHhtfVxFmRS8Qj3F378pj7xmJ7Bl1D0yDHHzr69qGc4S/msjWm5En1Q lfpkpfp1l9Y8JBuDcJlJSU3lGemZEGOa0bwAA5dfqPfS0+zaB/OAUDtbHE4kSnbrstnkhzZz1 xuLlGP7bQD+/yWDXzGpB0DuVHXoP1P1VS29v2XR0HsUHxFubdebuoyqJ3QEbR0QNypLHvsIvB NgkF3yS/62Q3P3LOjM5Xs7KW3yJhBs2lw4ix8p8ZSCfkwf7ymZnWOuAxvUBoAuG9V57+rz1xw wCWQccFYWVPfgq5ZBhWnTMQkXe8T0ISZm5UPoQUpx0NjxkIYOwrccZzKIdR5DXIBOl1AzQIR7 rNmfeV9Ayb2vM63Kz4as3kpO2Y2XuHFjWGOcjyQS2PUCthvgm7spLrDFvbdRKqFWHW4r3EhDI YNorHHp/6b6GzhV/cTrxqXC1XMoGuKxoVRJSSWnqtYmSL2CedadkzhboxGwuWgG+82KFFA36U 6yT0C9S3kBt+2pdWp+IFaLABYESPFpiWsN1fe9nNzwkFloyfbhTyMhsCGN0Ri0cJ3azMJ4zNl AH1Z4YOmLo2WtNqRJmGVdO16cjEuPGWdFBuaVYZUmtEco= =E2=80=A6 > This fixes touch reporting when there are more than 6 active touches. Does such information indicate a need for the tag =E2=80=9CFixes=E2=80=9D? =E2=80=A6 > +++ b/drivers/input/touchscreen/ili210x.c > @@ -255,14 +255,15 @@ static int ili251x_read_reg(struct i2c_client *cli= ent, > static int ili251x_read_touch_data(struct i2c_client *client, u8 *data) > { > int error; > + int ret; > > error =3D ili251x_read_reg_common(client, REG_TOUCHDATA, > data, ILI251X_DATA_SIZE1, 0); > if (!error && data[0] =3D=3D 2) { =E2=80=A6 I suggest to define the variable =E2=80=9Cret=E2=80=9D in the shown if bra= nch. Regards, Markus