Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp606392lqp; Wed, 22 May 2024 14:02:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWVEbjia3JSOUVkbg4le8M2xEosn+SR+sP9v118aFJTVcHxzR1HBB8K2GA+qSLG4oUoQqCxFIDG3oVhtbY4FpQ6onFXoQng7zhMtsbHew== X-Google-Smtp-Source: AGHT+IH+2qSdGt5v+B6nuNrpyqPfVnxorceTn/gftmW8Cdj6OAA6ZxHI5m85GYYIs7jRqK0D6cO6 X-Received: by 2002:a05:6a00:98b:b0:6f4:179a:fa5 with SMTP id d2e1a72fcca58-6f6d61b7db6mr3760486b3a.31.1716411740363; Wed, 22 May 2024 14:02:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716411740; cv=pass; d=google.com; s=arc-20160816; b=jhaRG7GFMumpXBT4VBNB66sfMh1b0jTPK8RhSmSTdNIIEIf+wMDZiXcnBs919bkVg6 J5QevynjqAhKasFl5dGZoOPawWqck4LL08iXIf2SjztJQg7EaBBe3N3vRIczcooJoS+0 Ypnu7bAMJimiiTCA0/eR3aF7h7XNXUSPNv1Zr+7sloD8Dzrow1PQ0E1qFfgCOr/3vsDB Fq5hdn5Au0WYed8YoY8b/eD+/a1E4jVu0ZfN7dmsPlERJhfD2F3TD4f7e9IWLcxsRpaD 6nloa/z2KawWJ2oJrumsu4CCKltaq9RxEbxHgmIeWm7hSXIKmZpG1cXutqqVv3yDiAz8 VCjg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Atjv96qq2OAJtNvHEuhpPZvHJqM/RL80by+9suRd8jY=; fh=YNxPuoUOryEQfdaUGREz+9NeHBtKwN4NlzBJcmi0D9U=; b=YqiRCNIvyOYj43Nr90FTq2IPCXArJMo/gxFHyCoOq84ustj8owzhhvPlBhIEP2pCcv qQ09vqmdugJaT13rKEy9UQZbvOQcp+YBsNGeDy1FfJ6eM5HRu1YS5AENUt8vbJzYaiQb +xj+DzOddSosvypdreqW2Dwsb6a1/t3pOBI2ECDQQFdQAVOCzJVeXk1EgjIqXYaIjalC mLeyNnXCH8FZoI6xldOfGhvUQkjCIvPVlkjrEswhYmzBOfTsIxwR2j3U2MJVZw6XS9r0 E3B7tuQ10ivJnuePtMow6ZekN9ogZrRgdRb0uWweBYS5+bGITI2t+Gx2R1gISVo79bBl RAbQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=dXWVEvto; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-186705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186705-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6340b2a0d08si25919059a12.205.2024.05.22.14.02.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 14:02:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-186705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=dXWVEvto; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-186705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-186705-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6DD9FB217BA for ; Wed, 22 May 2024 21:02:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 93923146A6F; Wed, 22 May 2024 21:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="dXWVEvto" Received: from 008.lax.mailroute.net (008.lax.mailroute.net [199.89.1.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FC1A1CAA6; Wed, 22 May 2024 21:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716411722; cv=none; b=CUbUiMgCfoFdbLxDEmnjwPPzO7SQM58kOz5viKbSu1lC7eA/qtoMY/t710LiMzeiHJN+zbSd7fC9n2C4AV8k+82TXi97zFxgGkeJlXBJQssB0p3LycsKrA8YNavMf29eNlftM2wnl3OTsaj1+3w2JT6tN4uY0A7WBVIcKLXoZnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716411722; c=relaxed/simple; bh=er7P36jIArk3ujM8x9Cy03xPyL1nefNS9QVEIwttV+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gIonnEh6LtKuSAOocxNSgZFX3NIMucr2Dx9PmLYCbBXRIrC00mV66gpinkhNrAtM2BMmONMZo28aiWvzxj2VjatR3k3pur4sD4Q7tDvXZP34w8zSWTBk7hIrQysQWqZJvn4n2bLLC8QgzRVTJHM5vPh1uYgIKY2aCIsszHPWgqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=dXWVEvto; arc=none smtp.client-ip=199.89.1.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 008.lax.mailroute.net (Postfix) with ESMTP id 4Vl3dh2jgnz6Cnk9V; Wed, 22 May 2024 21:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1716411715; x=1719003716; bh=Atjv96qq2OAJtNvHEuhpPZvH JqM/RL80by+9suRd8jY=; b=dXWVEvtowpQ/rT7tagj4HNILifmUfKkdishecPh+ MZxW074xv03njCj4qBGGmx1YkWMVGBQtEdFWKWofKAsDhLmBEvMAN8rWI3YFGwIA Mqu0FHc338dszAqlPs6ayXz7Sz6+UBQTbGb77FJwgHgvT8X/yNaH88IR7A6R/r47 ywyGHCk45eSBz9ZMVyvgg1+6rsrEpP4x8Qh6EAfoM9aLf2D+1XFU1EraKR1DIB23 6EpH69ahHuOtVpXP4Dj4FeDKtF2ZXu/LHtLjOdCW5SeTPaykIsXq3dgcXrJZbZ33 JYi5jljhi+70lM8JXqw7Y/CARw+rKZ5gn4Ju0h2crqSG1w== X-Virus-Scanned: by MailRoute Received: from 008.lax.mailroute.net ([127.0.0.1]) by localhost (008.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id D78-WJJWmQKg; Wed, 22 May 2024 21:01:55 +0000 (UTC) Received: from [100.96.154.26] (unknown [104.132.0.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 008.lax.mailroute.net (Postfix) with ESMTPSA id 4Vl3dW10Lrz6Cnk9B; Wed, 22 May 2024 21:01:50 +0000 (UTC) Message-ID: Date: Wed, 22 May 2024 14:01:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] scsi: ufs: qcom: Update the UIC Command Timeout To: "Bao D. Nguyen" , quic_cang@quicinc.com, quic_nitirawa@quicinc.com, avri.altman@wdc.com, beanhuo@micron.com, adrian.hunter@intel.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "open list:ARM/QUALCOMM SUPPORT" , open list References: <8e5593feaac75660ff132d67ee5d9130e628fefb.1716359578.git.quic_nguyenb@quicinc.com> <2ec8a7a6-c2cd-4861-9a43-8a4652e0f116@acm.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/22/24 13:56, Bao D. Nguyen wrote: > On 5/22/2024 11:18 AM, Bart Van Assche wrote: >> Since the described issue is only encountered during development, why to >> modify the UIC command timeout unconditionally? > > The vendors can enjoy the default 500ms UIC timeout if they prefer. > As long as they don't write to hba->uic_cmd_timeout in the vendor's initialization routine, the default value of 500ms will be used. Since this issue is not vendor specific, I think it would be better to modify the UFSHCI core driver only. Has it been considered to introduce a kernel module parameter for setting the UIC command timeout instead of the approach of this patch? As you probably know there are multiple mechanisms for specifying kernel module parameters, e.g. the bootargs parameter in the device tree. Thanks, Bart.