Received-SPF: pass (google.com: domain of linux-kernel+bounces-186724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7569db4a-9237-4158-99d1-775fc0854d59@intel.com>
Date: Wed, 22 May 2024 14:14:53 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v18 09/17] x86/resctrl: Add new fields to struct rmid_read
 for summation of domains
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
	"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>, Peter Newman
	<peternewman@google.com>, James Morse <james.morse@arm.com>, Babu Moger
	<babu.moger@amd.com>, Drew Fustini <dfustini@baylibre.com>, Dave Martin
	<Dave.Martin@arm.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
References: <20240515222326.74166-1-tony.luck@intel.com>
 <20240515222326.74166-10-tony.luck@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240515222326.74166-10-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDlaVDViZVY1dE9GRkk5TGtwS2JMSVJPWVhFNmhDWE5xalhKTmw4L3hTMWNy?=
 =?utf-8?B?REpqeWFpY0dTdmJ0Nm9kTy93Q2QyV21mY3g3SHF5bmI3ZmQxMVVFQUxhQzE1?=
 =?utf-8?B?bnNYK2p1VFlKeUhLUVJ1R3prbE5qRDdtWFA0ZXhqMXd0OFYwV3MxWG0xZytn?=
 =?utf-8?B?QktraWpJYWNoVSs0NjZTRWNRQXo3ajRIeDdRYVdDUStOWWkxdWczY3BqZng2?=
 =?utf-8?B?UUpPU25SR0pKclpZeTg2QjdnTTErU0l4S1BrakdVeitRcE5jUFNpdVBmNWpt?=
 =?utf-8?B?dmdJQW5HQWl3QWJnNEsrRjUxeHhKMUtyQ2NTWVUvQVdkdEpkL2tJS1lqdFlC?=
 =?utf-8?B?TjAwM2oxRGt0RmhhMGRRWjlNUUlKMTgwdGxVUk5mRFVpdHo1TzlLMm8xenh2?=
 =?utf-8?B?RnBmeE9NeS9XcDI4MC9VMFhPMnN3UmdqVExiMDd3c1pQcG1RQmp5bjJheUd0?=
 =?utf-8?B?MEx4cmZMSVJiRUtWTGRPd01JQmFQWjVOTS9NWEx0TjhndUh0VmMybk16SGpu?=
 =?utf-8?B?c0RqSm1UdUNZQ3RxZm9rbHRNVVFHeEhVS29ST0RSeDJxZXlNMEFwYTE0WlQ1?=
 =?utf-8?B?b0EvY0I0ZExtVFpOZ2UrT2hOaGF5S3J0aEhIdHZuSnNCZjJQdmp3L3cxOGR4?=
 =?utf-8?B?d2lxWndsRzVQbUk3MDMxaFBqczFUbEZnL3lyU2ZuMkhCQjFTRHliWWVUTUM3?=
 =?utf-8?B?SFdNZkNWS3NUN0RwR2hjQ2VCeHpCMWNoMFAycm1pK3JwMm0vTmlud2oxaHM4?=
 =?utf-8?B?YWFwWHdzQXZudkxYSWY0YS9VaVhkUDlENktVRCtMc1hKR0kwUzBYTGxCakZy?=
 =?utf-8?B?SDRnNGJQUFJhZEE1ZHdKcUhvSnBIK3FGNjIxZE1VV2JtaUFXb21xbXJzQzZp?=
 =?utf-8?B?ekJJOXhKL2NudzR6L3dmdC9jZTQwQzhSV29LdGUxc3NtTWN3Q0xQaFRhVCtX?=
 =?utf-8?B?UlVuYUN5RkwycktEYWs2alVtSlRDaHhqQ2U0ODRCRmVlelBHRTF0MTJScWRS?=
 =?utf-8?B?dGRQTHltemFaYk4vc0N2emFnamo4YU1PL0VhbXZQanA1WUhuUXNiMkNRYjNB?=
 =?utf-8?B?TVpkL1pIdTFDZEd6bHNFb3hsNWM3V0dQUGZsTVhaU1VFaCtMcWlRcHBaNWF3?=
 =?utf-8?B?d3hRcnJPR2duME44ampIcWcrTTlpanVJYWhic1RyNDB5NXZwK1hnRFRqMUZs?=
 =?utf-8?B?VGk4S1pGalNOZzBXNHh6T0hyVkxkbk5ZcTJjZFBXeWNPV2h6NGZGeTF3Q3ZP?=
 =?utf-8?B?Sjk0cTYxNVVObmRIZS9OMlpNelJpSldZSitadVRMSFNEUENVV0dNQUg5cU81?=
 =?utf-8?B?MlBzTG5XV1U2a1I0a0VYUU5SS2tNRkVNeUx6T01FMEdvbk4xRHg5Nk1ubWlM?=
 =?utf-8?B?bUNYUEsySW9LYVRSeTVMQ0xXZWZHK29IU0kyM2F0dWtDN2w4NmVYb01ZemdZ?=
 =?utf-8?B?U3BZdjFFUDVyMlYyU241UXB2enVBUVFRQUVUOGEzWTEwOVZPYjNPYk5ic3ZJ?=
 =?utf-8?B?YmZIVythckcwQTBvQ2pDck01UzRTa1hwMzUvelBkbnVGYTFYNWlYOFI2LzhC?=
 =?utf-8?B?U25oUXhaRWVrVERDSWNvL2F5bHFhaWlUeHZXS2ZocjUycTB4ek9sbnRqQjRF?=
 =?utf-8?B?elBTUmNIdTg0R0x5NDN6SU9lQlA1MkdjbkgyclgxODNSU1JzMWdKaGQ4K0lE?=
 =?utf-8?B?c1YxU3BIUW4xd0hnYjlMcUNHOW5VVk9HbENtOSs0SmNWY2FhYVhmQzRJTlpn?=
 =?utf-8?B?VFBJRWR5Q0E0L3p6TThacloyUytTN0F5bmlZZHkxdlpWL1h3QUQwbkFvZ05q?=
 =?utf-8?B?UmR6cHpMaXBjdDU4dlhGWkVqVDcxT3ZlZTZZOHVPRENCT2pqelhuVEl2ZFNL?=
 =?utf-8?B?VExqV3RHT3VBcWJkb1cxc2Q0SVZaelNnMURNeHVCOFhOelZ4eXhNTW4rdEIz?=
 =?utf-8?B?OUlndnRyR3I4c0czL1c3YWJ6SzMrYWc0QTl4TFRXTjlWeDRKNW9kZFA0MVFp?=
 =?utf-8?B?aHA3Wm1aTmEyUlpxcFVCSis0K0JnVTJvYndwNW9tRGsyV2FVb3pyRmNwT2JJ?=
 =?utf-8?B?dmtYVkFrN0VHdkJSYkJtYlk4TUJMazBzSE56TmswWHNWMVZLbU01QURMWnVI?=
 =?utf-8?B?dDduM0ROdDZOZzdzdU0zRDluMzBqMm1nalhzQ2RpMk5kUjBxdFlpMWxQempM?=
 =?utf-8?B?Y0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25117316-088e-44ea-5934-08dc7aa43a4f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 21:14:55.2498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ja/hpNDGMJdHuyAr014mXvVBW6UtutzXQVsad37TH5wktscHzE7PPuK6c0LMcZZJy/0ZLgB0KsBLGykGsmWAuAz0BHh6KfuUcSQknDjbqCo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7671
X-OriginatorOrg: intel.com

Hi Tony,

On 5/15/2024 3:23 PM, Tony Luck wrote:
> rdtgroup_mondata_show() calls mon_event_count() which packages up all

mon_event_count() -> mon_event_read()?


> the required details into an rmid_read structure passed across the
> smp_call*() infrastructure.
> 
> Legacy files reporting for a single domain pass that domain in the
> rmid_read structure. Files that need to sum multiple domains have
> meta data that provides the display_id for domains that must be
> summed.

( ... and also for convenience pass a domain in the rmid_read structure
 ... more later)

> 
> Add the sumdomains and display_id fields to the rmid_read structure.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 49440f194253..498c5d240c68 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -150,6 +150,8 @@ struct rmid_read {
>  	struct rdt_mon_domain	*d;
>  	enum resctrl_event_id	evtid;
>  	bool			first;
> +	bool			sumdomains;
> +	int			display_id;
>  	int			err;
>  	u64			val;
>  	void			*arch_mon_ctx;

These new members have enough obscurity to make this a good
point to document the members of struct rmid_read

Reinette