Received-SPF: pass (google.com: domain of linux-kernel+bounces-186727-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <7764b46c-85e7-4d5a-947d-87cf51c27bb2@intel.com>
Date: Wed, 22 May 2024 14:16:48 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v18 11/17] x86/resctrl: Allocate a new bit in union
 mon_data_bits
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
	"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>, Peter Newman
	<peternewman@google.com>, James Morse <james.morse@arm.com>, Babu Moger
	<babu.moger@amd.com>, Drew Fustini <dfustini@baylibre.com>, Dave Martin
	<Dave.Martin@arm.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
References: <20240515222326.74166-1-tony.luck@intel.com>
 <20240515222326.74166-12-tony.luck@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240515222326.74166-12-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEZmcGpyRmVPNTlUTnRyVGNhcVZGcVhvZVB6Q3BCSXQ2ejVZc1pVVVZFMTVU?=
 =?utf-8?B?cXBmR0ZrMjJqdFRWbDY2L0RLU1VUaWo1K2dIb0JaWDVSS1VJcXRvMkdTZlJy?=
 =?utf-8?B?UGt6cW5IU0NvRHBHajBpdzI2WTVGQ0tFYXFkMkZCcDdHZVJ3U2F3UGdVY1lR?=
 =?utf-8?B?bFNCZTIxVUJwK0pSNHExMjZvQm4xVy9RNFJVaCtVbG1SRE9COUJ3V2R4L0Z3?=
 =?utf-8?B?SEY0TnZUZXBTVXN2SVF2NS94TnhoNElTdlZlS2dIcU15bDF6ZFZnY3EwZGl0?=
 =?utf-8?B?WldqTXRNR2JnaVJHSjhFMVNHbWlaSjY1MVF2c2pKdC80ZmJqRkFPcHFXUENK?=
 =?utf-8?B?cHBJSUVvMXBnSjNJYjZlRG9SOE9ybkNEQ1kya3AwZTRhZ0cxOFJjUHhWUDFU?=
 =?utf-8?B?S1hUYVZmSHYvWjU4U05NdWpsS256QVJPeFRYRXZLcFpPV2pjYjlXb2VXRk54?=
 =?utf-8?B?U3lHbE5pbk5VNjZyVnU0bk9EMmkrTDBYWkQvd3hrQmltMmdGbStBZTU5VDFO?=
 =?utf-8?B?SXk2WGVqeXhRcU95UmJSUmFjZGM1Y0Y0VmxFZFJxeUtLYi9ERnpBME5PY1Mz?=
 =?utf-8?B?TzBFYzJHTEM4aU9ELzB2UzhQZGwzNlpWaGkvWmlhMlpGYW5SNkF4aVNBUit5?=
 =?utf-8?B?MmJTblZ2WDhSQWU2WUV3NHU2Q2crK21PQTNTdStHYjVDdW0vSXd6WFVwR2pE?=
 =?utf-8?B?NEExT2VKaHlXSjRLRDFwRjF3WElTTk1Icnh0VVM4WWhjTTBMMHUzNEh3M3Bo?=
 =?utf-8?B?aDRKYklZSG9hZlVHZDZFM2VMZHF6SngxVCtmQ1NKamJIdk1lNUFmRk16WDZh?=
 =?utf-8?B?N0ZCVXdEcU5WL2tBRGc1cTFCeUNFM001bEdsK2puUzFuZjlLZDZpeVdaZ2FX?=
 =?utf-8?B?QXFUZHR4STdQY0RzUndWMURHd3lUTVdOY0p5RDJESDZmbWNFQnV1ZzJIVkoy?=
 =?utf-8?B?NTFsL0pENElJNU81YnRIYmFGQkNpT2dwVWsyTXcvcWxJUnZDa2JDTnhYNzQ2?=
 =?utf-8?B?Mkk2VkZocHd6UzhwQmtQOHRQY3FUcStCRk5kZ2k4NnpGRmx2ZTV3UlVleWFE?=
 =?utf-8?B?K0g4WmpQQXkrZmdXK2VsUk9yZ05NS09TOEx4THBhV2U4bTVyUEwvQ2hhNi9G?=
 =?utf-8?B?VTFRR01iUGczMzJoSXpJU0N4d2RtU2Z2NnJYRHo4U2JsTWhoTVhJRVV1dEsw?=
 =?utf-8?B?TTBHVDduZEZJbEE1TWl0aHFhYWtYM1pOY2hlWmtxcnJoZWxpRyttcHBHbWRJ?=
 =?utf-8?B?NUlNWTBHVTFqZzhYMkVyaFRjaGpZdXg4L2lFcFk5QlROZDc2YnFGTThrMGlE?=
 =?utf-8?B?RUwwYkN0MzFKbTFzWEdhTW9Pcm1iRTNrTW9EMWxLa1V6UkJhZmxPVHVTVEQ4?=
 =?utf-8?B?T2FKeDljSWFlOU9kb2lFSTBCSkloN1p2OW95UGpHU2NBcG45TDFmTlYyR3Iw?=
 =?utf-8?B?K0wzTGhIZXBydktKM1lLYndaQlFYMzdLUkNXVDFhNFFVRmw3WU82Ung1VUdO?=
 =?utf-8?B?RWlScjBYOVFYOWF5K1RqdUFDRGVsVityajBHU1V1cTBZUGtkVjV6Vk15WENR?=
 =?utf-8?B?eGt2S1FvRVY5eE5aeDBsTFp5WEhTRDhhOHRTbWphanQzdlBNcHlacmw1SElR?=
 =?utf-8?B?d084encwbmNFd2FpMkU4dTBMRytNdUpQRUNIMm1jNEtOZVk2MjFQOUJ3b3lq?=
 =?utf-8?B?UHozSExpWUovV0N6M2ZOL292WkFtemM1ZFU3YlBxQUhxWnNOVUFma1Y0bVor?=
 =?utf-8?B?a1JjMHU2emw1akMvaGVjQVBVOTJTenZCUExmNjBENmNQN3UzZmpRMFNHbjBH?=
 =?utf-8?B?MEwvdkRZWmtpSkRDQUtnbGt2VFdka2w1VnR1THRtdVdvVGRLN1JkNXU4UktD?=
 =?utf-8?B?WmdkSzJkS3FaUm9GenBPZXJRcmhyZXZ2eEYrbnYvNkp6c21Wb3RPVTNQUFkr?=
 =?utf-8?B?QzZ3ZlUrdXlyQ3VuNi8yVGRxUXNJd0JhQUJZTXkrekNNLzFkb1BkVDhlZ1pV?=
 =?utf-8?B?d3hXVndrbUdWZGd1eDVoQUlzeUZLNklUcTduYSsrLzcyZWJmY3g2N3dzc2hp?=
 =?utf-8?B?SktkWFp0OE1ibGpiREp1Z2RvUmdURFFhaU9QR0U3TXpQaTgvTll1ZFdzeUt0?=
 =?utf-8?B?aHBrRUF2cTNpa0VnTlNDbnpJNVhYcmhlaU5aZ09WVnBIUU5HTndLOWZYK1Vy?=
 =?utf-8?B?UEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bb621e1-e9c5-4284-ce82-08dc7aa47ef0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 21:16:50.3893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R2U1nBtQF0wgFxLKRZIh2SqHtueSr3Py2nKCGFZTXxTJ/EqSMGXtAfCjhXAUijX7wa4hvWaoGn6BsWcDgKprMI6m5G+qtGoRDNppl+6RY/M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5887
X-OriginatorOrg: intel.com

Hi Tony,

On 5/15/2024 3:23 PM, Tony Luck wrote:
> When Sub-NUMA (SNC) mode is enabled the legacy monitor reporting files

Sub-NUMA Cluster (SNC)? (I'll stop pointing these out.)

> must report the sum of the data from all of the SNC nodes that share the
> L3 cache that is referenced by the monitor file.
> 
> Resctrl squeezes all the attributes of these files into 32-bits so they
> can be stored in the "priv" field of struct kernfs_node.
> 
> Steal one bit from the "evtid" field (currently 8 bits, but only three
> events supported by Intel) to create a new "sum" field that indicates

This is filesystem code so should surely not be just about what us supported
by Intel.

> this file must sum across SNC nodes. This bit also indicates that the
> domid field is the display_id to match to find which domains must be
> summed.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 498c5d240c68..c54ad12ff2b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -132,14 +132,19 @@ struct mon_evt {
>   *                     as kernfs private data
>   * @rid:               Resource id associated with the event file
>   * @evtid:             Event id associated with the event file
> - * @domid:             The domain to which the event file belongs
> + * @sum:               Set when event must be summed across multiple
> + *                     domains.
> + * @domid:             When @sum is zero this is the domain to which
> + *                     the event file belongs. When sum is one this

sum -> @sum to be consistent with previous sentence?

> + *                     is the display_id of all domains to be summed

"is the monitoring display scope id shared with other monitoring
domains to be summed"?

>   * @u:                 Name of the bit fields struct
>   */
>  union mon_data_bits {
>  	void *priv;
>  	struct {
>  		unsigned int rid		: 10;
> -		enum resctrl_event_id evtid	: 8;
> +		enum resctrl_event_id evtid	: 7;
> +		unsigned int sum		: 1;
>  		unsigned int domid		: 14;
>  	} u;
>  };

Reinette