Received-SPF: pass (google.com: domain of linux-kernel+bounces-186733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <61e89a48-d1f4-49f2-8893-950e7e6ba7fe@intel.com>
Date: Wed, 22 May 2024 14:25:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v18 15/17] x86/resctrl: Fix RMID reading sanity check for
 Sub-NUMA (SNC) mode
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Maciej
 Wieczor-Retman <maciej.wieczor-retman@intel.com>, Peter Newman
	<peternewman@google.com>, James Morse <james.morse@arm.com>, Babu Moger
	<babu.moger@amd.com>, Drew Fustini <dfustini@baylibre.com>, Dave Martin
	<Dave.Martin@arm.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
References: <20240515222326.74166-1-tony.luck@intel.com>
 <20240515222326.74166-16-tony.luck@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240515222326.74166-16-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a21TVHZ6QmYyTklXQmpERGlpYXAvOVZjcVNLUnJHVlF6d0JZeUMzWHFjaTUv?=
 =?utf-8?B?YkJ5cjFRWmxXOHd3S2FudnllQVIzMlNUN3hLdnkrZXd4WUJTeG9WdmgzTTBS?=
 =?utf-8?B?VkZnOWd2YnVIWFNKc2tzL215M0JlUytiaDhMYlpxTk9ZYzdSbTY0bEYweXFM?=
 =?utf-8?B?dGkvcW0ycFJQb0lJQVlZNFFwNUJTdXBDOHNjT3BKYlJ1OTJtK29FTG5rczJV?=
 =?utf-8?B?REltNFJZMml4NXdYczBkRU1nMTNHMmdPTjdDNERpZEhRSmRlbXpMdm5zbTFG?=
 =?utf-8?B?aUpiL29jRUpQaEFVTGtOaG0xNWxTUEZUdnhnZzJCN0dGUCtwYzhLTE1KM1Y0?=
 =?utf-8?B?MWFhc0V5SFFhYUFQZnl5K3J3YW1lZjlzNG85ek93ZjdPc1NHeHZHa0RnUlVV?=
 =?utf-8?B?eS9LVDFNdS80dndjWXFmVnJBd3c3RnZSdFJnMkhnYTlRRVE5SEFBTkFUMWhE?=
 =?utf-8?B?RzY0WFE3dXZwQ2ZrbmFlbHUxb1h5bVF6cDA0byt6SEJwTXNVMVdpZE9WcEFr?=
 =?utf-8?B?dk9kdUZBdG1NdXVaZFBQY0hVbUl2T0d1cEZBWjQ2UGNpd0NxN2JIK2IwQVhN?=
 =?utf-8?B?aWFlMlVsMXltN3B1VWw4WURHSGhNUWM2R0kwK0pHdWJGM2RyVkZuSy90ZE9E?=
 =?utf-8?B?T3Zoc2svOC9ZTEhWY3NXamUzZjFzdGNtQ015ZXJYVHFCWmVJUjlGeWFjTWdY?=
 =?utf-8?B?NHZVUXFWUkNwUFJQRDVSWENTS0R5RUZPSmpZVUlPS0xHK0w0MC95MXEzdG0v?=
 =?utf-8?B?OCt3c3J6S2drc2xjNHVTemFiQWMxK3ZHWExEZU4vdFYrTCtoN0hlYVB3UTVi?=
 =?utf-8?B?eWVLYjZ6b1VVbDIxc2w4R1YxUUYyTlVLTm9VMm5HWVZXWG9adWhMMHFoZEh1?=
 =?utf-8?B?QW42c3ZrMXdrZkNCSDNBRzlxWnlzeWdJdmtoZ0tsMGdvMGVIUFh2VHM5TXVL?=
 =?utf-8?B?RjVwMVpQY3pOdzQ4ai8xdWVVUjJ6aWZldEl6NHZwenU0Y3dhNVlBcHRUelZS?=
 =?utf-8?B?N3hkaUs1b3JiQ1o5U3BveGtJSDhiMFpydXVrV0RRMVc4aHFncUdTTEIyVmVk?=
 =?utf-8?B?eEJNTkJ3aWxJRmpnSWs5Z2N2ZWRsTi9LWlVES0JDbkY0K0dVazF0dEgrbWJQ?=
 =?utf-8?B?WnUyZzZmeThLdzVGN1ZQTHJTVUVtdWVXcmhrYzI3MU1kZHIva1ZUdE1QdE5s?=
 =?utf-8?B?RXF5UFlmc05qQWtmTjZGWHJ1K2IwOFRDOXU0VWNORWo2V01xZkpyVnNhSDVJ?=
 =?utf-8?B?M1Rrc3dZM1U0SzNzUW12VWR3WklmZm9GQTJpaCtsYjErQ2JOS1Rnc3FhMzV3?=
 =?utf-8?B?MUhXUCs0UE1HWHJtVTZGUEY4TDg0NnVDZVl4SjdRa2toUkx4eFZ2bmNpalRF?=
 =?utf-8?B?QTJ4eWw3UXNjZGhDS25QOWpCSFh6cW5RVmZqK3dRV0dNaFNRRFZsdG5hdTV5?=
 =?utf-8?B?bVlDenorUEdjSlo2eTRTK0NiaVlpc2l2Wi96NkNsOHdjdUpXZEd4V0xHMGdx?=
 =?utf-8?B?RTA5ajRIUzEzYlRSU2dqdHg0K0IvcGN3QW9SeTZpRmlCMGFiVGVkNGtyWFc4?=
 =?utf-8?B?T3JPRDJHa3VzRXpYcnBxQm9PbFBTNy9rbTlVYXBVUFRlbTREaEF0dnpmTmZq?=
 =?utf-8?B?OWhzNVI0QjJPRi9MbjR2bG9Ob0xCU2FoMkRhQkVwSUN2K2lEU1hSa05iYTRH?=
 =?utf-8?B?QVQxN3ppSUhLaXF6VVY5cU9HQldsek55YWw4dVh5YnRLZVNPc3liVXBDcm5Y?=
 =?utf-8?B?UGkvQ3Y3UEZRSnRUZWFNaFpjSEFwR05LQjVaVkxCV0hIZFgzUlA0d21rOEQ2?=
 =?utf-8?B?MkdseEZPbHZINlhJVlNkRVQzTjBPZmt0Rjl0bklBNHFQMi9pdmptS3ZjN2VE?=
 =?utf-8?B?Ym5qVm9BaDQ2cHlyaHJOakFONEM1YXZKZlgzMU1pNUxvN3hNdUpNL1N4a2ln?=
 =?utf-8?B?MHN6clBnNE1BaUUzb2I3bEdjTCtyUUdtMmpBYmZUZ0krV2RwSHNnUlFpaWQv?=
 =?utf-8?B?WTBZelVZRENpNTVMM3FxbmhXaEM5L2ROTS9rT1NORVFsbHlTcWwwT1VkNEpU?=
 =?utf-8?B?eXdtZ0VqVjY1VnB5ZDN0OWd3TS8zd1B0amlySHYrbjJzb2lseEM1ZGlNTlFL?=
 =?utf-8?B?S0NMbWpoejd4aXpHeUEyMjUwRlpTZjdNM1EzN3BlWlJaZ2JFL3J4ZDhhaUNU?=
 =?utf-8?B?cHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 80bf74d3-8fe3-4e4d-fa4f-08dc7aa5b200
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 21:25:25.5377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y3h80vvWsAPiYOmVhucpHdojLQnQNDBWYALdztNwY/hjLYJoBa60ao/0G67E045MptFt/FMwp0y/IoZhuRHzcNM+R/VURcfP6PElpgeGcgA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7056
X-OriginatorOrg: intel.com

Hi Tony,

A "Fix" in a shortlog of a kernel commit has quite a specific meaning
that I do not believe applies here. It fixes something introduced by this
patch series so "Fix" is surely suspect.

On 5/15/2024 3:23 PM, Tony Luck wrote:
> The sanity check that RMIDs are being read from a CPU listed in the
> the cpu_mask for the domain is incorrect when summing across multiple
> SNC domains. It is safe to read the RMID from any CPU that shares the
> same L3 cache instance.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/kernel/cpu/resctrl/monitor.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index 668d2fdf58cd..e4b92c7af71d 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -15,6 +15,7 @@
>   * Software Developer Manual June 2016, volume 3, section 17.17.
>   */
>  
> +#include <linux/cacheinfo.h>
>  #include <linux/cpu.h>
>  #include <linux/module.h>
>  #include <linux/sizes.h>
> @@ -281,8 +282,18 @@ int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_mon_domain *d,
>  
>  	resctrl_arch_rmid_read_context_check();
>  
> -	if (!cpumask_test_cpu(smp_processor_id(), &d->hdr.cpu_mask))
> -		return -EINVAL;
> +	if (r->mon_scope == r->mon_display_scope) {
> +		if (!cpumask_test_cpu(smp_processor_id(), &d->hdr.cpu_mask))
> +			return -EINVAL;
> +	} else {
> +		/*
> +		 * SNC: OK to read events on any CPU sharing same L3
> +		 * cache instance.
> +		 */
> +		if (d->display_id != get_cpu_cacheinfo_id(smp_processor_id(),
> +							  r->mon_display_scope))

By hardcoding that mon_display_scope is a cache instead of using get_domain_id_from_scope()
it seems that all pretending about being generic has just been abandoned at this point.

> +			return -EINVAL;
> +	}
>  
>  	ret = __rmid_read(rmid, eventid, &msr_val);
>  	if (ret)

Reinette