Received-SPF: pass (google.com: domain of linux-kernel+bounces-186735-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <84195d22-c056-43be-a40c-9db5944862d1@intel.com>
Date: Wed, 22 May 2024 14:27:32 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v18 17/17] x86/resctrl: Update documentation with Sub-NUMA
 cluster changes
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Maciej
 Wieczor-Retman <maciej.wieczor-retman@intel.com>, Peter Newman
	<peternewman@google.com>, James Morse <james.morse@arm.com>, Babu Moger
	<babu.moger@amd.com>, Drew Fustini <dfustini@baylibre.com>, Dave Martin
	<Dave.Martin@arm.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
References: <20240515222326.74166-1-tony.luck@intel.com>
 <20240515222326.74166-18-tony.luck@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240515222326.74166-18-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THI3NGRMaS9UR0ZaY0gyRG94Y0NKYjNhc3hoUDRzckRzVGQ5RFp4OC9tb0dC?=
 =?utf-8?B?OTloUmlrNkx4N2p6WHRmZUVsQUxOS0dtUkoyZTN5aVRhUWhiTENDSXJ1WTh2?=
 =?utf-8?B?Z1FnWnFER1ZrOTIwOWRWa2RwUEJaOG11L2VFSUN5QWhBUXVHKzQwSTZsTjlu?=
 =?utf-8?B?WmRtUkJCWVQyNSthYlRobnZjb3V0emE0cFcwZFc5TEpMQVFSQWdCYzBMR092?=
 =?utf-8?B?NlhhM1diOXRaemNGeUlQeFhkSzRwYmlNRGNRTEluWElScjBMS2IrSktSUHMy?=
 =?utf-8?B?UmQ1d25LUjFHcUF1eXNRM0Z0eSthYlVBOHBaVW45Unp5eXVsRlRYRTJ3S3Jn?=
 =?utf-8?B?QzNVbWJLT2t5UHlyQlpqWFJBa0VEb2ZITFc2cTB5ZlV3RFVqYjZYZWs4YlJ3?=
 =?utf-8?B?bTNZUElYclBSMlhHeWQ2UG9xK2c3TThoZHI2Tm1OR1cvL3FSVW5NMVBta0RT?=
 =?utf-8?B?Tm9DeGs4UXdHNUNMbW9OeHhYTVo2dFdpbzB1cVprUk4zeXg5QUl6SDk1UE02?=
 =?utf-8?B?YlZocVJEM0hneVV5aHdBRE9qdTFjMG5IN3gvY3R1VzdWaitmdlRTbUJ2L0xq?=
 =?utf-8?B?T01DUmpSakdKU1NjN01ZWVg4RHdGeVJOclIrSGx6dnVYWjBTNEtjSEkySmda?=
 =?utf-8?B?NFFLYTYvYng3bXcxR0Qvai9nUXMzM1JUV1BYK0thWVVDT3Azcm9yU081aVdu?=
 =?utf-8?B?dUJ1RlNUQUFSeUloMnl4L1VjYmVtRVB4OVgrMVJWc29qZEdySWtxeFNCcFBQ?=
 =?utf-8?B?YkJ0cXcrL3VHb1ZzRDBOYUpOREZva1N5NGlxMWthdElrV1gyNVZsL3ZyNlZT?=
 =?utf-8?B?OXJpaEc0dVBIVjhad08rTFdIRnRwaWRLUzUvSG9UMnRySzF5MHh0L0JuWUtv?=
 =?utf-8?B?NmV4Qm92UU9CVm9sZzlNdTc2dkVNQVQ1Z2RyY2Q3YkgvdEwvWFhJZHprUFJN?=
 =?utf-8?B?NEsrdEtyLzBGb3R6VVJvakk3NlFEM2pMTnJiNWlRMzhlVERGOWxYVHhza1pl?=
 =?utf-8?B?enVNWFN4U1dIUUxpRE1iRlMyaUw2WENpYWxjWit0N3NIN1ZCclBseFI4c1I4?=
 =?utf-8?B?Rndvc1dGT3FCS0pBSkdFZzRMK1ZTa25YWTRWSW93T0c0eWlNNG5BczF5M1ZS?=
 =?utf-8?B?dXdidDFwdUF3MThoeHNRSnBURytvZTk2ZDNqSVUxUFJ5MVdzejYrdDQ0b3NZ?=
 =?utf-8?B?NjJkTTNpTEgvdG56Ymw3eHFFKzg4RndhNkh3T1o0dTMvM0lMR3djUXJKNWJB?=
 =?utf-8?B?Yk5KN0ZvN1hzdVpsUHRmMEFmWXV5RVJzZTVXQm1WcE1lL2Vvd2RpN2pVOTNG?=
 =?utf-8?B?L1ROMm1PQ1JlMzBHUGlJMUY0ekd1bTBJQi84bXcxdDVFYXFBRmRzSUhhSWR4?=
 =?utf-8?B?cG13b0F1eEtPMHVKRFdweG1pcE12RklnaG5hTHJIZEZvb0JjTFo4WmdoTWhC?=
 =?utf-8?B?MXN5N0pHditkZnhMZm1uWGRUV3dpclRFY0QvL3A4bWZnUTJ3UytyMzAzUzdO?=
 =?utf-8?B?bEI0Y1MrV2JsMksvVHJpSmw1Z0NsMUcrY3I4bzhDMkVHUDIzVDRxTjQ3dG1u?=
 =?utf-8?B?Y3RlSVJSMjBobHFER2JuMExUUUNub2xBSHQwc2d0clpWWU42Y3hZd1pYcStV?=
 =?utf-8?B?M1k0U2FYUjdPTUN6aGFTVm15Ymx2eW5MZCtueWhQSnZjOXdidytxNlA3MXVR?=
 =?utf-8?B?TkxxRGNQT25aUFZWVjFTLytzdU5xNkNRUFptdnk5eXp5Z2pUQXgwZXd3MXIz?=
 =?utf-8?B?ZzN2ZDlpb29IZHRpdENMaHdiWDA5OHJJWFRUOFpvcVRkcFhGVDJjWTVUVm8z?=
 =?utf-8?B?TGRSZ09sSDQzbER5R1Jua242ZDBVdEFGdDhRaXFsQ2JsU1hNYUZ0dmd6NEt3?=
 =?utf-8?B?RitySktqS0VOUk41WUtQN1hSVGx3dk9IL3Z6Z1p6OUk0VEllVGFiVGl2WHBn?=
 =?utf-8?B?aXltQ3doanJ4ZXZXaHQ0OFZwcVN0cDdGTEhuWTVKTFNrT0ZtSEJ0Vzh4QnF0?=
 =?utf-8?B?aVRTancwUVh0cXZJb0tYV2pBU0Z2NVJUVENITnVQYVczMTljdUNrYll0V1hM?=
 =?utf-8?B?aDJSd1BzTCs2ellGTzRQSHUzWHpTWWZ5MFZYdHgrcWlQQ3lWQ29sUTl1c0h3?=
 =?utf-8?B?U3d0NTFwU0k5NmFPTzFYNkREenBrWlFxaC9paFhFUUU4dkE5Qjcxbld5dWlI?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ddcf9a90-6cf6-4361-2a00-08dc7aa5fea6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 21:27:34.1361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LuiyU2yiA92eBcs+WPZv1a4bapvEj715m+5f4EaeyEnrTEUnRf+jwG+DjfY6xNJsLEIpFFFndgTBQ3CZjOkV88gm12gEptDXaZLX2nH5tqE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6031
X-OriginatorOrg: intel.com

Hi Tony,

On 5/15/2024 3:23 PM, Tony Luck wrote:
> *** This patch needs updating for new files for monitoring ***
> 
> With Sub-NUMA Cluster mode enabled the scope of monitoring resources is
> per-NODE instead of per-L3 cache. Suffixes of directories with "L3" in
> their name refer to Sub-NUMA nodes instead of L3 cache ids.

Out of date?

> 
> Users should be aware that SNC mode also affects the amount of L3 cache
> available for allocation within each SNC node.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  Documentation/arch/x86/resctrl.rst | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
> index 627e23869bca..401f6bfb4a3c 100644
> --- a/Documentation/arch/x86/resctrl.rst
> +++ b/Documentation/arch/x86/resctrl.rst
> @@ -375,6 +375,10 @@ When monitoring is enabled all MON groups will also contain:
>  	all tasks in the group. In CTRL_MON groups these files provide
>  	the sum for all tasks in the CTRL_MON group and all tasks in
>  	MON groups. Please see example section for more details on usage.
> +	On systems with Sub-NUMA (SNC) cluster enabled there are extra

"Sub-NUMA (SNC) cluster" -> "Sub-NUMA Cluster (SNC)"?

> +	directories for each node (located within the "mon_L3_XX" directory
> +	for the L3 cache they occupy). These are named "mon_sub_L3_YY"
> +	where "YY" is the node number.
>  
>  "mon_hw_id":
>  	Available only with debug option. The identifier used by hardware
> @@ -484,6 +488,19 @@ if non-contiguous 1s value is supported. On a system with a 20-bit mask
>  each bit represents 5% of the capacity of the cache. You could partition
>  the cache into four equal parts with masks: 0x1f, 0x3e0, 0x7c00, 0xf8000.
>  
> +Notes on Sub-NUMA Cluster mode
> +==============================
> +When SNC mode is enabled, Linux may load balance tasks between Sub-NUMA
> +nodes much more readily than between regular NUMA nodes since the CPUs
> +on Sub-NUMA nodes share the same L3 cache and the system may report
> +the NUMA distance between Sub-NUMA nodes with a lower value than used
> +for regular NUMA nodes.
> +The top-level monitoring files in each "mon_L3_XX" directory provide
> +the sum of data across all SNC nodes sharing an L3 cache instance.
> +Users who bind tasks to the CPUs of a specific Sub-NUMA node can read
> +the "llc_occupancy", "mbm_total_bytes", and "mbm_local_bytes" in the
> +"mon_sub_L3_YY" directories to get node local data.
> +
>  Memory bandwidth Allocation and monitoring
>  ==========================================
>  

Reinette