Received-SPF: pass (google.com: domain of linux-kernel+bounces-186783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5df7b14f-9108-4aa1-b343-aebcb7e13a96@intel.com>
Date: Thu, 23 May 2024 10:34:41 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/6] KVM: Rename functions related to enabling
 virtualization hardware
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini
	<pbonzini@redhat.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Chao Gao
	<chao.gao@intel.com>
References: <20240522022827.1690416-1-seanjc@google.com>
 <20240522022827.1690416-3-seanjc@google.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240522022827.1690416-3-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlBvRGxIU2M2cGIyWXc1eUdZQ282bFc0ZlF1cms3NXJlM0paQVdRZFFvWkVP?=
 =?utf-8?B?bmFKUmQzQlVyekU2anNlcHpmcVFXM2lCWktzVEtXTkRtM1lGbjJhbjJrQ0RX?=
 =?utf-8?B?RUxDTkh6bFdEeW4wTUNHVzJrMmRUMmV2QTUybEI4M002Rm1rbTVFd09KMEpR?=
 =?utf-8?B?QndZd1JYSXRBZmVSTGFIYmZieENVZlRGRHZaQWhxTGJXYVNnbFhRWGkwL3Y2?=
 =?utf-8?B?YVdUQ1JUSk5CV1F5dVQwVm5CWXJjbE1tL0lRVm1ydVNwV2h5M1lRL3dEWENF?=
 =?utf-8?B?bVlLdFFOQ1hEWjZiejZIdjFYTC91TFFvazM0OTVWamJxdXloT1JYKzZsNHM3?=
 =?utf-8?B?YkcxMnVldHFLdldyN0xVQXZLUnJ6dkFaOHNGbmhTcy9IMG9UdnhZUWs1Qno2?=
 =?utf-8?B?QnVRbThWT0kvc0ZXR2xnVGRmQTlKU1djM2Z4YjZFQ0ZVeGQzL21ONHlmU01D?=
 =?utf-8?B?WTZMcW9wd2ZmRlc0UTZKaVVrc1MweitTQndRZUNZVVRxV1ZwbzNIVkJhQUZo?=
 =?utf-8?B?cDBaRGpWbGg5YTRaaFNHY21hN1FiWG9RbVkzUXN5eUc4TXBSeGI5Zk52Tll0?=
 =?utf-8?B?TGlTcFhISE80bktUbVpTRjk4bnVPMEZuUnF4TnVKSVZTaTh6QkZML1kxazRm?=
 =?utf-8?B?YU4yM2pseWwwbVZKY1NabjlnNXV2cWtvdUpFZXM2ejJ2T200R0hWNkprWjlz?=
 =?utf-8?B?azgzdW5mcmpWUFYvYTNCRGVIdlZtOW9tbXZoWjh5cFJQcGhCWmNFRitIdVA2?=
 =?utf-8?B?bXRvL1pxVU94M1pwMEtxdTRLK3BDSnRQRC9ZKzdRUGEzK1YrWEpEZ3d6bkI0?=
 =?utf-8?B?S093aFpvamYvVEQ3Y2JqTElQN05LZ1hNTEZ0ZFVCN0ZMYmxyMjd6d1YwQ3lY?=
 =?utf-8?B?U0xCMmt5MjlMMS91U2ZQMEptTXh2ZHpaaTdHQlN3a05ycjFGV2JRWmhyMytM?=
 =?utf-8?B?a1p1ZVVXZ1ZYQ0hNc1krMlJpa05RL2lmWjRZM1dRb0pJRkNYSGlMK2Q2K090?=
 =?utf-8?B?NDhaWlMybW5YVnlnbEZjUFdEMTVUZVgwOGx5ak5BTUNLc0VLL2x0Mk9YUW0x?=
 =?utf-8?B?WUxtTVlQMTNVdTkySmNPaW1sY0pFdXB3VE1GRk5QV1dTUkFFUlVRR1E3Wmxs?=
 =?utf-8?B?K1hBOFQra3NLTkRkQVJ6ZlJ0R2hLbEdmaDJrVndqMFIxeTc5NXRzT2Rtekox?=
 =?utf-8?B?MUlBcnVweTBGeFFuQjJjMEFzWitoT01ZY1M2aHFqSWUwYWtwT3JZakhzREc5?=
 =?utf-8?B?Ymd1YTBOYXM3VGFlU2hVRGFZSEcrV01NM2pRQnlIakNiQTV6Qi83Z2dSMEF1?=
 =?utf-8?B?dTUyYmlIeXROTXJWOXR1RFFZdnJCR28wV0R1ZGVPYzdmdm0zNVVHYkZZY1dq?=
 =?utf-8?B?K3hmT0IwUnpoOVdQOFFzYkJ4eVpEQ2M4UjJFUHZ5SVdVcUlEdlZGOE5Sait3?=
 =?utf-8?B?akF2bndhMVl0RVIra0plUGVzUysySklTMDZPVDFHN3pRWkg4elR6enhNMTVa?=
 =?utf-8?B?TlI0VkxkZ051cXk5em43SVRXUGpSZHVpczFRai96S1BUOUZvc0hQVXQySmxh?=
 =?utf-8?B?T0ZvekdaeXRKTTFXc1IrRGk0RWZTdHNkR2NHeWRGcGtsUGw2eTBZNTd5NUdy?=
 =?utf-8?B?Vm5ZdVl2aVViaEpadjArMzN1WUo4YSs1Ym1tbzlBS1BUUWxhejNDUW9FVGV1?=
 =?utf-8?B?WmRrUmpHMWVRdURXTmRDaDhHSzlXY1U0d20rSE5valJzSUVhQ0s1OUlQUDZI?=
 =?utf-8?B?QVRkNk9wbmExVjAwby9uVTZkM0JMNVBxdS9RZUxXbkFrUVRqL1luc1FSdWE0?=
 =?utf-8?B?UncxVDdXQ3R2MnBjRU5SNVVtZlJRM2NFZ3JIRktJWWtYM3dscU1yVjlzZ3Z3?=
 =?utf-8?B?L1JUSzV3TTdTdnpPNTlIUWVlMzZMdVNZWEk1U1NLN2lvQlFMZU8yakdjMm0z?=
 =?utf-8?B?YWE2Uk1tZ1RlUk1SZXlUMFJENHlmUFRvNGhEZnBSb21WcFNIZmFrY1N3S2JJ?=
 =?utf-8?B?MmZ4bXhIQWU0Q2xsMWNybU4vdmNZbWQxOEl2d1MrNjFQWHpFeVFhTzJmQ04y?=
 =?utf-8?B?d3lNSkd1TmFwTkhjRVZTMEpCaGRqS2JLQTVSUlRFa1FjTWVLWEFNTlE0a2ln?=
 =?utf-8?Q?LjppMP9RoRRU4+vdEWCQOtZTW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a1be155-2952-484c-fd1e-08dc7aaf62e6
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 22:34:47.8678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dh7f19E9eICibPLJ3t3EBpUKGWzEmMr4HVjDi8tDnMQGXavWlgs2c0Lrv9olr3nI2Fqj8kOOh/6N7DIBTjBwvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8015
X-OriginatorOrg: intel.com


On 22/05/2024 2:28 pm, Sean Christopherson wrote:
> Rename the various functions that enable virtualization to prepare for
> upcoming changes, and to clean up artifacts of KVM's previous behavior,
> which required manually juggling locks around kvm_usage_count.
> 
> Drop the "nolock" qualifier from per-CPU functions now that there are no
> "nolock" implementations of the "all" variants, i.e. now that calling a
> non-nolock function from a nolock function isn't confusing (unlike this
> sentence).
> 
> Drop "all" from the outer helpers as they no longer manually iterate
> over all CPUs, and because it might not be obvious what "all" refers to.
> Instead, use double-underscores to communicate that the per-CPU functions
> are helpers to the outer APIs.
> 
> Opportunistically prepend "kvm" to all functions to help make it clear
> that they are KVM helpers, but mostly there's no reason not to.
> 
> Lastly, use "virtualization" instead of "hardware", because while the
> functions do enable virtualization in hardware, there are a _lot_ of
> things that KVM enables in hardware.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---

Reviewed-by: Kai Huang <kai.huang@intel.com>