Received-SPF: pass (google.com: domain of linux-kernel+bounces-186785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <4b39f27c-bfb7-412b-85b7-e05b0d27c320@intel.com>
Date: Thu, 23 May 2024 10:37:51 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 6/6] KVM: x86: Register "emergency disable" callbacks
 when virt is enabled
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini
	<pbonzini@redhat.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Chao Gao
	<chao.gao@intel.com>
References: <20240522022827.1690416-1-seanjc@google.com>
 <20240522022827.1690416-7-seanjc@google.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240522022827.1690416-7-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aldEUjRQTTB4cmxLRXBxTS9NVjRIWnBnbTJGcE56eEJESm5uME1OeWpzcmlY?=
 =?utf-8?B?dDVEZzY0TllTeFNGYlhnbzhCUHREQjhJQkU1dnh0VldHN3BtRkhWdTZDcWkw?=
 =?utf-8?B?Y05CdTBrRGVQWE80cVdicTdUZU9iN1VVWTgvam5yL3k2c0xMMGJzZUprWXcw?=
 =?utf-8?B?UXJhaGZCaVA0WTk1K3g1bUJTR2YwSEZGcmxLM3pYUzdBM3g0R3drRDVSY21Z?=
 =?utf-8?B?bGdtbE1XMXlNRW9ydm5WYWYxLzhnQW45cjcvUmNEdFcwalZGOUpWS2o2RUR0?=
 =?utf-8?B?RFhueWo2c3kvc2sxQ0wva3Y4cElHVUJBR3NwSXkzSGl1dk1LUDkvWm51MzU5?=
 =?utf-8?B?U3k1d0ZRMFpRTXVOeDhtNGdBT1N4Y3FxMXg1WFhzSnhtb2pVQWU2ZTBkMUxp?=
 =?utf-8?B?V1dCVmk2WEpkVHllcHlrWDdmdHlsbzhsL01WNHBmTWlLampYd0xlbGw1L2xE?=
 =?utf-8?B?cDB5R0dvbEJqTCt4R1V0bXdtOW5udStZSkMwSzJUNG1MWmZhRTcwT0o0UzdV?=
 =?utf-8?B?SHlvM0tYeTJmNWw2S1c3WEs3SVROdHV3M3QzSXZyU0R6eEE5YnlOMk81amJT?=
 =?utf-8?B?UmpOTTd2UjI1aWVybTV0VWdWMklrcFN1ZGIvak1jSVljUTVCcUVmd0VidVp1?=
 =?utf-8?B?NXVwNjVqNGRXYldQUmtmVmZpUEwvYURaVUNybGJ2TXRDVGlvdElkZnpsekVE?=
 =?utf-8?B?ak1vdU9ENVdsSmpnTEw4RGpqUU95cUZScG10cGxiWVQvblNCZS83MnhpOU13?=
 =?utf-8?B?RjZGK0NxM01DTlFndmtJMmhDdjZtcXFVR0phVWMrSzN4bGJvenZ3ZzNqSEMz?=
 =?utf-8?B?U3FWODhZWHlGUDFQbEt2Y3FSMys3Zm5uc1EzdEdlUGNjSURyYTNFN1RGdFov?=
 =?utf-8?B?eDBaTkg5Tlg5VGNqb1g2N0RjRVNYNDJlc2FrbVhwK2hIYkwrSkhTeExXZmlW?=
 =?utf-8?B?VmRyQTdYbmlqNnZBRTd6Tm9wOEdFVlM3UGV3TE9QakIydnlYd3RhM2tuWFp6?=
 =?utf-8?B?OVRxd2hjbTU4RGpEN01KWGh1RVQrNkczU09MVzIvVlBPdUNyRWlFaERPWnY4?=
 =?utf-8?B?Vmo5eWY0ME1WYldWNHZCUm5vazBkYUtKbDRNTERsbGMyMEY3K3pxTVYxbk5m?=
 =?utf-8?B?T3I5SUZUQldpMCtHMHVDd2hNM1Nma1ZkSkliSldsWjIyRmJDeGswZzRsaFBW?=
 =?utf-8?B?dVBvekJUcEpTYS8rdCtWTm1BOHV3dXpmRlc4S25yMTBUSExUc0h0aEM2OFB0?=
 =?utf-8?B?UCtmV0RnRlZVazZSWnh5ZjNtS2c4cmhoR25sem5mNDNZaUdISW0xS2QzdUt3?=
 =?utf-8?B?dlgyYlpKZGpyU1BmS0c5OUdqMXE5THR0OUI5bmRtQllQMGxDdFUzVHJBV21o?=
 =?utf-8?B?alV6eXI3VThUSE1yRFd6UmRhNGhVdzhiNFhvMjJXRFZnUENyR3lWa1pUSUho?=
 =?utf-8?B?dGh3QVpiNmZrKzVFRG40clI5T1VRRnB0bytwSVpOME1jMlgxUm95TXBPcHJF?=
 =?utf-8?B?RXpwTnZIQmcvemo4c0xGSGhibUM3YVd6bmhoUGF4TEJUN0QvVVVsTjFhUHY0?=
 =?utf-8?B?QW5yTVJsWk5JNlhJaTJ5clE3NmdHNE82cUJkcHdvNUkyUkJ4a0h1U1FrSWVt?=
 =?utf-8?B?dHY5ekl4SmxmemJXaXFWMnFtVXRhM2V4c0lidktkQU05dU5LMk5kZ0FFVnpK?=
 =?utf-8?B?R3dmOGppRFl1Z0RJeHY5SDRsN2U5bHl3Z05XbURKNHlhenhRcVVvTGVGS1h2?=
 =?utf-8?B?UjdhMWE5ZjljNlV5ZzFzN3JxU05wdmdKNDV3TzBrbHBTSHVsOCtQeUg4enQ2?=
 =?utf-8?B?QVhOMXVUSzVHT00xTEgxL3JCcFdkZFd4cjhjc0V0b1BvbGNGNC9Zd0lLYkVa?=
 =?utf-8?B?ZncvL3U2aDdib0kwRWlDelRHQ2t5aUVHb0ErSmV3anRtTUkrbkdrcXdyWFho?=
 =?utf-8?B?clJVT2s3RmJ0Vy9pTjQ0akVZdUkrd1V0YlBHanVWa2doSURmMUtTMXp1QmdZ?=
 =?utf-8?B?WnkxNmdEbDR0M05HakFtcFl6K3YyUmVXZFVVRERaQk9VaEVGYnVETGpMODAv?=
 =?utf-8?B?OTh5NC91SFJ1NHBmclhYY0JaeGhkaUlxa2IrbEVUeUJVLzBwMmtzQjYrYW4z?=
 =?utf-8?Q?gs0F0S9mDwqId60B3Mtlxwq/g?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 783a40a0-5258-4a2e-07a0-08dc7aafd3e1
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 22:37:57.3925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kEqssyWa2mlMMXhZ3HaQiXhwNUdcPW2YLd64EUIHn9BC2urzMiA9qpA2cpuuDe1FEC0NymvClGxPQH/3ljnIEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4581
X-OriginatorOrg: intel.com


On 22/05/2024 2:28 pm, Sean Christopherson wrote:
> Register the "disable virtualization in an emergency" callback just
> before KVM enables virtualization in hardware, as there is no functional
> need to keep the callbacks registered while KVM happens to be loaded, but
> is inactive, i.e. if KVM hasn't enabled virtualization.
> 
> Note, unregistering the callback every time the last VM is destroyed could
> have measurable latency due to the synchronize_rcu() needed to ensure all
> references to the callback are dropped before KVM is unloaded.  But the
> latency should be a small fraction of the total latency of disabling
> virtualization across all CPUs, and userspace can set enable_virt_at_load
> to completely eliminate the runtime overhead.
> 
> Add a pointer in kvm_x86_ops to allow vendor code to provide its callback.
> There is no reason to force vendor code to do the registration, and either
> way KVM would need a new kvm_x86_ops hook.
> 
> Suggested-by: Kai Huang <kai.huang@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---

Reviewed-by: Kai Huang <kai.huang@intel.com>