Received-SPF: pass (google.com: domain of linux-kernel+bounces-186894-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Nas Chung <nas.chung@chipsnmedia.com>
To: Michael Tretter <m.tretter@pengutronix.de>
CC: "mchehab@kernel.org" <mchehab@kernel.org>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Sebastian Fricke
	<sebastian.fricke@collabora.com>
Subject: RE: [PATCH] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE condition
Thread-Topic: [PATCH] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE condition
Thread-Index: AQHaqD+OBWQuNlhl8EqlSzXRSkJlr7Gi6hIAgAEnynA=
Date: Thu, 23 May 2024 01:48:34 +0000
Message-ID:
 <SL2P216MB12467C08314BA4B314A8EED6FBF42@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
References: <20240517094940.1169-1-nas.chung@chipsnmedia.com>
 <Zk2kunIzL0ylxHiH@pengutronix.de>
In-Reply-To: <Zk2kunIzL0ylxHiH@pengutronix.de>
Accept-Language: ko-KR, en-US
Content-Language: ko-KR
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?s5Z5zK76voRgwtR1Cxs7Vek2RkvBzcmut7unzVCYLZ1ErV5e5beRJ9yOjpbF?=
 =?us-ascii?Q?TDkIppRqpGlnO+wSyb3pF/0uOb4oR/CWBBoIwSeYIqOOMXDthmwAU8/eyyeL?=
 =?us-ascii?Q?i/C4N4eoggOAVpwhY1qhllTcnF2yeX2h6QS/S+UogQNkk/T5g4isEspOAhjM?=
 =?us-ascii?Q?gmoQh23biTLAMUVzjdmly7nyXkpyPCu0e4wWyC3Jn+oeyWXxVd0UP0d/a+WQ?=
 =?us-ascii?Q?pj/Zg6RIbPJPkFaTLKxv6TTdNWnBO7ArqrEOHkErk4C4JRHrE+d2i9IZk5xK?=
 =?us-ascii?Q?z58HuxDTjLjLuaWTWCfG56ypycNCrF20omAPH2uMo0UiUcWJDcflVueVl1CQ?=
 =?us-ascii?Q?92Et/yBFheutShkaDkxpDPjJYV68X37okQ2kVMotFl+B/8707+8xK8qu9bnB?=
 =?us-ascii?Q?peVSdqVYinRhVoLskwvfX/+PiKVlevMgxVFXHcjA5r72rEVT6PZcy/7PuVHF?=
 =?us-ascii?Q?8jHfaGZUbcAQaPKFuM4H8HefLJN37AXGsJHwIA4h7g74JBcPCZOc6W05erMR?=
 =?us-ascii?Q?x1s8JZ7P5XEJ3FooClq/ws6646O1pGxyKIYW5csjSy34jABOMXD/kZKhihR9?=
 =?us-ascii?Q?ca1SoQfT21mWokk49cD5PSWe4DVtYFDsSu1XBA4S/rkVeilwMtQW5itrcfdI?=
 =?us-ascii?Q?UOu8NYxLg0NkArIU8fQgHRYs6RQkV6FAHdfc3R/npIhczuF9iybepCF4XNBk?=
 =?us-ascii?Q?0YpN7RYNsRiMpxWYzit1R5Rff+FhaekN0k/AToQiym5nX7lirDxPrDXHHBy3?=
 =?us-ascii?Q?KBhtOrv3kBL00V1YD4ERd3ElY7gJl09UoelKzpGSkjFrmA67lPEOve92/QJP?=
 =?us-ascii?Q?MW7MHqw7HM1m1VMkAJLJ08QetwQObBMGXXa1Y3FEfwg0IHgrwGxI24bcyxJn?=
 =?us-ascii?Q?19kgv0RKWzJdRyfYDjnYbBjps5d3Z6WRTy0IrOLhJhtFEwaHYuBAPND59KmT?=
 =?us-ascii?Q?KgNRODZP4GPC1YOT1TmhGObRPEyqNGmXKOKez8OIkxL6WY75MWoRiV2vRc/s?=
 =?us-ascii?Q?bQ/vNC/g0wmRzqlQY594q8KzeDphLmjVyGpCh94q3T9WZyvfS3ijniykRLO9?=
 =?us-ascii?Q?sczd7VydmNu1mRgV3En1W0jiJIO+LYHdw/L9r9zbmE94rNwYZ3J7yHkmPgXi?=
 =?us-ascii?Q?8uaU56ENjNWrw9r7U4XdmMPnVPOIzCe4dArKO+gxu8qGs1lCx1qRjQy7iR9O?=
 =?us-ascii?Q?dtsIInYTu8DniIz1oluNzrcqqSu4NIAK92ihU9X4JPyo+VZ1ckYwJpLCaPVq?=
 =?us-ascii?Q?S+j/q/6llATqAzujpftzLiI1/iaScoWVTdzqjmQ/KYEj0ByJPCayk1z2dwei?=
 =?us-ascii?Q?lAdRppKzJ4mbvXJPcGA7p51O3PcEsrNH5LzHpKyh9G8BS9IzQcivpz+/a8Ze?=
 =?us-ascii?Q?6LIyLkUlwZ5aHAGraaHU55EmchBF5siNWx9BkSexPTjMpWdRGfMAhBn3hjIR?=
 =?us-ascii?Q?EFMs1O6Zd8rpTvhKwNGHOvENjWsaaSgwc54QmgVA7FrH7qKVcsVd5Z2XZLaX?=
 =?us-ascii?Q?KEq+8qA0SDb+QIXxnMbMiAmfxUyOT49niq5bjNi2mBoP946lz07frmwEauQ2?=
 =?us-ascii?Q?rOnNeRYqMe23jmXKxGSbHMYOdIJbUYunq2vN05fY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: chipsnmedia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SL2P216MB1246.KORP216.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: d6d1e5b2-ff66-474f-cdbe-08dc7aca7542
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 01:48:34.8700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4d70c8e9-142b-4389-b7f2-fa8a3c68c467
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z3R+eKDRojeCJTnDHRB98Q7vzHZ5PRNQuALNp5JniCrmD3KRidRk73a+5md8N0LfDCSJ4J3TyRBex70WXJiCz1T26byljfebuZqgf0P1GNQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE1P216MB2190

Hi, Michael.

Thank you for the feedback.

>-----Original Message-----
>From: Michael Tretter <m.tretter@pengutronix.de>
>Sent: Wednesday, May 22, 2024 4:55 PM
>To: Nas Chung <nas.chung@chipsnmedia.com>
>Cc: mchehab@kernel.org; linux-media@vger.kernel.org; linux-
>kernel@vger.kernel.org; Sebastian Fricke <sebastian.fricke@collabora.com>
>Subject: Re: [PATCH] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
>condition
>
>On Fri, 17 May 2024 18:49:40 +0900, Nas Chung wrote:
>> We expect V4L2_TYPE_IS_CAPTURE() macro allow only CAPTURE type.
>> But, Inverting OUTPUT type can allow undefined v4l2_buf_type.
>> Check CAPTURE type directly instead of inverting OUTPUT type.
>>
>> Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
>> ---
>>  include/uapi/linux/videodev2.h | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/videodev2.h
>b/include/uapi/linux/videodev2.h
>> index fe6b67e83751..32b10e2b7695 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -171,7 +171,13 @@ enum v4l2_buf_type {
>>  	 || (type) =3D=3D V4L2_BUF_TYPE_SDR_OUTPUT			\
>>  	 || (type) =3D=3D V4L2_BUF_TYPE_META_OUTPUT)
>>
>> -#define V4L2_TYPE_IS_CAPTURE(type) (!V4L2_TYPE_IS_OUTPUT(type))
>> +#define V4L2_TYPE_IS_CAPTURE(type)				\
>> +	((type) =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE			\
>> +	 || (type) =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE	\
>> +	 || (type) =3D=3D V4L2_BUF_TYPE_VBI_CAPTURE			\
>> +	 || (type) =3D=3D V4L2_BUF_TYPE_SLICED_VBI_CAPTURE		\
>> +	 || (type) =3D=3D V4L2_BUF_TYPE_SDR_CAPTURE			\
>> +	 || (type) =3D=3D V4L2_BUF_TYPE_META_CAPTURE)
>
>Maybe adding a V4L2_TYPE_IS_VALID(type) macro would be helpful to define
>TYPE_IS_CAPTURE as all valid types that are not OUTPUT:
>
>	#define V4L2_TYPE_IS_VALID(type) \
>		((type) >=3D V4L2_BUF_TYPE_VIDEO_CAPTURE \
>		&& (type) <=3D V4L2_BUF_TYPE_META_OUTPUT)
>
>	#define V4L2_TYPE_IS_CAPTURE(type) \
>		(V4L2_TYPE_IS_VALID(type) && !V4L2_TYPE_IS_OUTPUT(type))
>
>This would avoid keeping the two explicit lists of OUTPUT and CAPTURE
>types.

I agree that it's better to add a V4L2_TYPE_IS_VALID(type) macro.
I will address this in V2.

Thanks.
Nas.

>
>Michael
>
>>
>>  enum v4l2_tuner_type {
>>  	V4L2_TUNER_RADIO	     =3D 1,
>> --
>> 2.25.1
>>
>>
>>