Received-SPF: pass (google.com: domain of linux-kernel+bounces-186896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 22 May 2024 18:56:34 -0700
From: Elliot Berman <quic_eberman@quicinc.com>
To: Xiong Nandi <xndchn@gmail.com>
CC: <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
        <quic_bjorande@quicinc.com>, <cmllamas@google.com>
Subject: Re: [PATCH v2 1/2] scripts/decode_stacktrace.sh: wrap nm with
 UTIL_PREFIX and UTIL_SUFFIX
Message-ID: <20240522185039245-0700.eberman@hu-eberman-lv.qualcomm.com>
References: <20240521194010043-0700.eberman@hu-eberman-lv.qualcomm.com>
 <20240523010318.12934-1-xndchn@gmail.com>
 <20240523010318.12934-2-xndchn@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240523010318.12934-2-xndchn@gmail.com>

On Thu, May 23, 2024 at 09:03:17AM +0800, Xiong Nandi wrote:
> Since System.map is generated by cross-compile nm tool, we should use it here
> too. Otherwise host nm may not recognize ARM Thumb-2 instruction address well.
> 
> Signed-off-by: Xiong Nandi <xndchn@gmail.com>

Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>

> ---
>  scripts/decode_stacktrace.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index fa5be6f57b00..2bc3a54ffba5 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -30,6 +30,7 @@ fi
>  
>  READELF=${UTIL_PREFIX}readelf${UTIL_SUFFIX}
>  ADDR2LINE=${UTIL_PREFIX}addr2line${UTIL_SUFFIX}
> +NM=${UTIL_PREFIX}nm${UTIL_SUFFIX}
>  
>  if [[ $1 == "-r" ]] ; then
>  	vmlinux=""
> @@ -158,7 +159,7 @@ parse_symbol() {
>  	if [[ $aarray_support == true && "${cache[$module,$name]+isset}" == "isset" ]]; then
>  		local base_addr=${cache[$module,$name]}
>  	else
> -		local base_addr=$(nm "$objfile" 2>/dev/null | awk '$3 == "'$name'" && ($2 == "t" || $2 == "T") {print $1; exit}')
> +		local base_addr=$(${NM} "$objfile" 2>/dev/null | awk '$3 == "'$name'" && ($2 == "t" || $2 == "T") {print $1; exit}')
>  		if [[ $base_addr == "" ]] ; then
>  			# address not found
>  			return
> -- 
> 2.25.1
>