Received-SPF: pass (google.com: domain of linux-kernel+bounces-186969-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240522184953.28531-3-palmer@rivosinc.com>
In-Reply-To: <20240522184953.28531-3-palmer@rivosinc.com>
From: Anup Patel <anup@brainfault.org>
Date: Thu, 23 May 2024 09:51:01 +0530
Message-ID: <CAAhSdy2UFh+BYX=gMVPZRJivLxhatZOqBpOuKef0cc0OvrSAGA@mail.gmail.com>
Subject: Re: [PATCH] irqchip: riscv-imsic: Fixup riscv_ipi_set_virq_range() conflict
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: tglx@linutronix.de, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, 
	linux-kernel@vger.kernel.org, Tomasz Jeznach <tjeznach@rivosinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 23, 2024 at 12:26=E2=80=AFAM Palmer Dabbelt <palmer@rivosinc.co=
m> wrote:
>
> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> There was a semantic conflict between 21a8f8a0eb35 ("irqchip: Add RISC-V
> incoming MSI controller early driver") and dc892fb44322 ("riscv: Use
> IPIs for remote cache/TLB flushes by default") due to an API change.
> This manifests as a build failure post-merge.
>
> Reported-by: Tomasz Jeznach <tjeznach@rivosinc.com>
> Link: https://lore.kernel.org/all/mhng-10b71228-cf3e-42ca-9abf-5464b15093=
f1@palmer-ri-x1c9/
> Fixes: 0bfbc914d943 ("Merge tag 'riscv-for-linus-6.10-mw1' of git://git.k=
ernel.org/pub/scm/linux/kernel/git/riscv/linux")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

LGTM.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
> Sorry I wasn't clear about this one, but looks like it got dropped as
> part of the merge.  I'm happy to pick this up via the RISC-V tree if
> folks want, but I'll keep it stashed off to the side for now as it's
> just touching irqchip.  I'm planning on sending some more stuff on
> Friday morning, so just LMK.
> ---
>  drivers/irqchip/irq-riscv-imsic-early.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-riscv-imsic-early.c b/drivers/irqchip/ir=
q-riscv-imsic-early.c
> index 886418ec06cb..4fbb37074d29 100644
> --- a/drivers/irqchip/irq-riscv-imsic-early.c
> +++ b/drivers/irqchip/irq-riscv-imsic-early.c
> @@ -49,7 +49,7 @@ static int __init imsic_ipi_domain_init(void)
>                 return virq < 0 ? virq : -ENOMEM;
>
>         /* Set vIRQ range */
> -       riscv_ipi_set_virq_range(virq, IMSIC_NR_IPI, true);
> +       riscv_ipi_set_virq_range(virq, IMSIC_NR_IPI);
>
>         /* Announce that IMSIC is providing IPIs */
>         pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->fwno=
de, IMSIC_IPI_ID);
> --
> 2.45.0
>