Received-SPF: pass (google.com: domain of linux-kernel+bounces-187006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240522023918.7613-1-ki.chiang65@gmail.com> <20240522023918.7613-2-ki.chiang65@gmail.com>
 <2024052204-freehand-say-198c@gregkh>
In-Reply-To: <2024052204-freehand-say-198c@gregkh>
From: =?UTF-8?B?6JSj5YWJ55uK?= <ki.chiang65@gmail.com>
Date: Thu, 23 May 2024 13:33:00 +0800
Message-ID: <CAHN5xi30GpA8Kco4+EFpvOU2wdgW8dpeBjE=Bs1ffbFVbjo-EA@mail.gmail.com>
Subject: Re: [PATCH 1/2] xhci: Apply reset resume quirk to Etron EJ188 xHCI host
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Greg,

Greg KH <gregkh@linuxfoundation.org> =E6=96=BC 2024=E5=B9=B45=E6=9C=8822=E6=
=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=8812:36=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> On Wed, May 22, 2024 at 10:39:18AM +0800, Kuangyi Chiang wrote:
> > As described in commit c877b3b2ad5c ("xhci: Add reset on resume quirk f=
or
> > asrock p67 host"), EJ188 have the same issue as EJ168, where completely
> > dies on resume. So apply XHCI_RESET_ON_RESUME quirk to EJ188 as well.
> >
> > Signed-off-by: Kuangyi Chiang <ki.chiang65@gmail.com>
> > ---
> >  drivers/usb/host/xhci-pci.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index ef513c2..a0beb41 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -31,6 +31,7 @@
> >
> >  #define PCI_VENDOR_ID_ETRON          0x1b6f
> >  #define PCI_DEVICE_ID_EJ168          0x7023
> > +#define PCI_DEVICE_ID_EJ188          0x7052
> >
> >  #define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI   0x8c31
> >  #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI        0x9c31
> > @@ -238,6 +239,10 @@ static void xhci_pci_quirks(struct device *dev, st=
ruct xhci_hcd *xhci)
> >               xhci->quirks |=3D XHCI_TRUST_TX_LENGTH;
> >               xhci->quirks |=3D XHCI_BROKEN_STREAMS;
> >       }
> > +     if (pdev->vendor =3D=3D PCI_VENDOR_ID_ETRON &&
> > +                     pdev->device =3D=3D PCI_DEVICE_ID_EJ188) {
> > +             xhci->quirks |=3D XHCI_RESET_ON_RESUME;
> > +     }
>
> Same question as on other patch, should this be backported to older
> kernels too?
>
> thanks,
>
> greg k-h

Sorry, I'm new to this.
These patches have been tested in the stable 4.19 kernel, so they
should be backported to stable kernels as old as 4.19, right?

Thanks,
Kuangyi Chiang