Received-SPF: pass (google.com: domain of linux-kernel+bounces-187012-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 23 May 2024 13:41:11 +0800
From: Chao Gao <chao.gao@intel.com>
To: Sean Christopherson <seanjc@google.com>
CC: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Kai Huang <kai.huang@intel.com>
Subject: Re: [PATCH v2 5/6] x86/reboot: Unconditionally define
 cpu_emergency_virt_cb typedef
Message-ID: <Zk7W9yoWG1of1m07@chao-email>
References: <20240522022827.1690416-1-seanjc@google.com>
 <20240522022827.1690416-6-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240522022827.1690416-6-seanjc@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X0adaMx+FRrHZ2OuOwy2B6DESlfVGgqzfP3PqqQlaFLfaBUX/+HEZhIJIKCu?=
 =?us-ascii?Q?tW4yUf49dsBYlnGL+LA46PEnR70DpcLZDXoRQoxqw5O0/ySpFPq+LHUw47/G?=
 =?us-ascii?Q?G5e6O5obuARxf6qgVIKc4+flJutSvp3+pQ3cH5n/6oci5BxV6smRC0C66BY2?=
 =?us-ascii?Q?kDFhLuQVNKykqwpLn+4CuDC9Qxfw/ccXOcpQWkRlpo0SNGrRvIBHBRBqcfrg?=
 =?us-ascii?Q?5b6Bi6GNhTY7m68zxdcVDXJzT8L77+z8qLSUC+jwvtL05UOlOC1q2bWRWjD5?=
 =?us-ascii?Q?t4JVAXsffbKiCQN2n1egStqFbvBMKLUsdgLzsZ6ZZbSY9/fs1W5Z/wkQQcsU?=
 =?us-ascii?Q?8JBgrtEE+fmEz9Wy1q6y1JDyHm5sN6bOTw3UPeGFDqjw7CWke4zpeXoTl9zs?=
 =?us-ascii?Q?dAxlG3D3auLbq9rlyh4j+J6zufISfneAOkdvG/IJjuY2Qg1INhlKKeUcati1?=
 =?us-ascii?Q?d70Wlj5ljg+FusfNVNfXtICiJQdjeRh27Cy/rMYNUewLSwyZ0M4nJAQ3W5TJ?=
 =?us-ascii?Q?5WD2iNQo1Af7VEHPB7+MJHypTekGTVGToreON7k4bkijWVEZy+OkjDm2itVA?=
 =?us-ascii?Q?aslfJGfTrZSTI+SXPnkD9CNqOeh0aNLgku78IL/k6Wja5Jc+Z2H0g93n3/ZU?=
 =?us-ascii?Q?epbWYSq8hbjRPQ+emK5PaoLN5oa/k6wUlT5+F72fdvcehZxr5lviP7ccY0RU?=
 =?us-ascii?Q?ET6MeAiWnjQOMwgmUIsWueI2lTu8DdTqm//VofAgbd+khhX8uWRRxa/bXrmt?=
 =?us-ascii?Q?XvGinfhyqYEeJpbZvW4E8wlmNinmKmN6QX/4XTyZJc/9gV0lLpq75JawZgiN?=
 =?us-ascii?Q?Fdpx24jJnmKpyNgre9up1//OwR4NXLoNdndI8nFyXu1F9L3wn411i+zY52pr?=
 =?us-ascii?Q?6LSRT1LD9iZ7uHMo7mlcxyt6248thjvcde2nHcXxoaMo+oe1xsKTRPZ/wfe6?=
 =?us-ascii?Q?P7zgFp2FpNZV5iPosy8UPqh04P+oFzV0i65o6oyvYvLEkmBu/LI9f/nZsM37?=
 =?us-ascii?Q?EdMIcmqP8ACKH3XVF5YGbybbvkZP6OWiBfW6mGfNzlSyvqU7Vkj1smGRgRK9?=
 =?us-ascii?Q?ZSrXrndmfkvtVg2/ly03ibgVeH0sNWiOLEiftqXNSq1ZeV/+vOJEnQprVwYb?=
 =?us-ascii?Q?tSUzId2+dQ3qr1MOINBRrSGSo3K/r/lUTR7B4OgRMXUpxkopNDvKPNd2gRt/?=
 =?us-ascii?Q?2KdOv4J+xa/MQbPkWVn10QJWwlHUvsoicpKNmRhDpA84BC1TMSfpCOERLRMs?=
 =?us-ascii?Q?DXRGcXewA5Hsycbn6qyaMxm4QIdpwRRmyh7gbAj43om4QzKxEUb9EvRxGwjz?=
 =?us-ascii?Q?w4zCLc1AIM1pZM/on0NWX01HExw2yb6BOtmBamBKqKGhwoCPz2C6JW/Suo+I?=
 =?us-ascii?Q?q7RfvbqK/Xl9r1Tww0+SlSmzB+DnKPHWUsLovFy4ELMBixJCpuAril0lKmH7?=
 =?us-ascii?Q?ZSIubvcPFRFSI7WzJaVEAxrED8jKDClskge2rV3jP+M9EOFBxR4O7bMG6K5/?=
 =?us-ascii?Q?klAkmchgXQvX+4H0TqVuYicVnpr4ouBP/HESCP1Jn3mbVFxe/hTHw7v4dL08?=
 =?us-ascii?Q?J8GlI9CFEaUfu7fn9yjvDy/h9sq6W3Bc0mmFE1Ye?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d538bbd-83ee-487c-ffdc-08dc7aeaf7d4
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 05:41:18.0088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YL2Cm/lNegk4MGaWTJsc8UUAHD5mc6+yn77n0UToB0/430PHzLyIS2ZbvI3xaeCsWU+sR4Df/8O/AvzhhGW6bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8197
X-OriginatorOrg: intel.com

On Tue, May 21, 2024 at 07:28:26PM -0700, Sean Christopherson wrote:
>Define cpu_emergency_virt_cb even if the kernel is being built without KVM
>support so that KVM can reference the typedef in asm/kvm_host.h without
>needing yet more #ifdefs.
>
>No functional change intended.
>
>Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>

Perhaps x86 maintainers need to be CC'ed.

>---
> arch/x86/include/asm/reboot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/include/asm/reboot.h b/arch/x86/include/asm/reboot.h
>index 6536873f8fc0..d0ef2a678d66 100644
>--- a/arch/x86/include/asm/reboot.h
>+++ b/arch/x86/include/asm/reboot.h
>@@ -25,8 +25,8 @@ void __noreturn machine_real_restart(unsigned int type);
> #define MRR_BIOS	0
> #define MRR_APM		1
> 
>-#if IS_ENABLED(CONFIG_KVM_INTEL) || IS_ENABLED(CONFIG_KVM_AMD)
> typedef void (cpu_emergency_virt_cb)(void);
>+#if IS_ENABLED(CONFIG_KVM_INTEL) || IS_ENABLED(CONFIG_KVM_AMD)
> void cpu_emergency_register_virt_callback(cpu_emergency_virt_cb *callback);
> void cpu_emergency_unregister_virt_callback(cpu_emergency_virt_cb *callback);
> void cpu_emergency_disable_virtualization(void);
>-- 
>2.45.0.215.g3402c0e53f-goog
>