Received-SPF: pass (google.com: domain of linux-kernel+bounces-187017-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <eb24b250-6654-4f2a-ba03-3eca2cfa543b@gmail.com>
Date: Thu, 23 May 2024 08:50:22 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] iio: light: rohm-bu27034: remove unused struct
 'bu27034_result'
To: linux@treblig.org, jic23@kernel.org, lars@metafoo.de,
 marius.cristea@microchip.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240522230457.478156-1-linux@treblig.org>
 <20240522230457.478156-4-linux@treblig.org>
Content-Language: en-US, en-GB
From: Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <20240522230457.478156-4-linux@treblig.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Thanks David!

On 5/23/24 02:04, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'bu27034_result' is unused since the original
> commit e52afbd61039 ("iio: light: ROHM BU27034 Ambient Light Sensor").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

As I wrote earlier, this driver in it's current form is pretty much 
useless. The BU27034NUC was cancelled and, as far as I know, never 
produced "en masse". The replacement, BU27034ANUC, has undergone 
somewhat meaningful changes like removal of one of the data channels - 
so this driver is not producing correct results on that IC.

I have promised to rework this driver to support the new variant, and I 
have this new HW on my table - but I am currently negotiating to be able 
to provide an open-source Lux calculation formula in the driver... This 
is causing some slight delay.

So, I think applying this patch is still worth :)

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   drivers/iio/light/rohm-bu27034.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27034.c
> index bf3de853a811..4937bf6fa046 100644
> --- a/drivers/iio/light/rohm-bu27034.c
> +++ b/drivers/iio/light/rohm-bu27034.c
> @@ -223,12 +223,6 @@ struct bu27034_data {
>   	} scan;
>   };
>   
> -struct bu27034_result {
> -	u16 ch0;
> -	u16 ch1;
> -	u16 ch2;
> -};
> -
>   static const struct regmap_range bu27034_volatile_ranges[] = {
>   	{
>   		.range_min = BU27034_REG_SYSTEM_CONTROL,

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~