Received-SPF: pass (google.com: domain of linux-kernel+bounces-187067-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Nicolin Chen <nicolinc@nvidia.com>
CC: "will@kernel.org" <will@kernel.org>, "robin.murphy@arm.com"
	<robin.murphy@arm.com>, "suravee.suthikulpanit@amd.com"
	<suravee.suthikulpanit@amd.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>, "vasant.hegde@amd.com"
	<vasant.hegde@amd.com>, "jon.grimm@amd.com" <jon.grimm@amd.com>,
	"santosh.shukla@amd.com" <santosh.shukla@amd.com>, "Dhaval.Giani@amd.com"
	<Dhaval.Giani@amd.com>, "shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>
Subject: RE: [PATCH RFCv1 12/14] iommufd: Add IOMMUFD_OBJ_VQUEUE and
 IOMMUFD_CMD_VQUEUE_ALLOC
Thread-Topic: [PATCH RFCv1 12/14] iommufd: Add IOMMUFD_OBJ_VQUEUE and
 IOMMUFD_CMD_VQUEUE_ALLOC
Thread-Index: AQHajVVtTIyOrzFsYEOvw2C4tndA2rGT4ByAgBDBXkA=
Date: Thu, 23 May 2024 06:57:15 +0000
Message-ID: <BN9PR11MB527668B2398FE65771A429D08CF42@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <b0ee53af3f59602834e67ddf86c748ca304da175.1712978213.git.nicolinc@nvidia.com>
 <ZkDZ/YO0jqZOlRtA@nvidia.com>
In-Reply-To: <ZkDZ/YO0jqZOlRtA@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3tB77eh7LmpNRBaC7Z6Z9X1SW016EyQMgwQXrrquJr3TrCpNJr8nNiEu8zG7?=
 =?us-ascii?Q?q/PP5hH0+NVV+G6VuNqtUwTsETkto3G9G3f0RPdWPIE0dz0HqQmqs85BR7M/?=
 =?us-ascii?Q?Il9FIqLB4LkLcbZc1kKqG92GigPGecxicIQuO3jbb/kNOdpoQeb2GGQ0XBpk?=
 =?us-ascii?Q?+YDb6wumfSjPreUiyYX1TKJMEuFCwn80/r0eVlgGa7PyZORMUzkZig8dry9L?=
 =?us-ascii?Q?CeaVyQubyf5v6R0P8nt5YGCdwyG0/YX4DT4uSoLHbKsnwFnIGqPym1NdiskV?=
 =?us-ascii?Q?DjEVz4dFrxjrOBRwqqYo8m5IJoLQvgiGOMo8ddqbiRpHUghog4gWXE+KLeW3?=
 =?us-ascii?Q?vog/ik/hfB8bmYX4vFqtAJJi0AdTjIm4+m/CvKRzm+mRyGvKlkm9mSCHOIKF?=
 =?us-ascii?Q?DuQNTsfSbe0G9NZgO0pIDcqCwATA8HZ5nmOYg4FL9qtcxJHV8xrGfqAI5ZZ2?=
 =?us-ascii?Q?amK67/x8/z+2Kpxe4Mw3cArCdcD/BbjzLyh3sg/fCaTYDHV4+3Pj433RQt3C?=
 =?us-ascii?Q?NLw16mrOUWAFrVIu6omsYlYhwDMOU0M6fX2w5b1Z03NIuhV+NhWdryJJqKyD?=
 =?us-ascii?Q?+66zT+CI/FKOku23MRzBU6BjKgdBqzrlOxS7EebgPqPtIJ5alDXgeX+hLGwj?=
 =?us-ascii?Q?cX4knoKi4lvbpdCVOrWxB/skpof36ziTPemSQA6itdGHKnwxjnNr60G6Bkqa?=
 =?us-ascii?Q?lB5vSZTANYe0sjIclX94Q/0rLsAQH7IIzJ4/HKOUYatsGSixVDRIRDPCKbG1?=
 =?us-ascii?Q?o4sxbLR5YmR/Opiw4ew3l5oGo4so+2sFLjfqUE3lZ1HYUZHK0aDaryBIWck1?=
 =?us-ascii?Q?PqwP7boFOqkdakg5LjCs7TnevjQ022Tk4REJm5yfPmvmlzgc2sMACSAuww7u?=
 =?us-ascii?Q?G5AmvY5SwVGMvzugy3qaNJ0ySjdiBzZk92vx0YJ8orsPduPzcKrUDLYccOtD?=
 =?us-ascii?Q?rK3ZyCw0Ua7PiqYKWvz9trZ1MRXgy6scHVcejjjEkmjjNM7ByZRczU2QDO7b?=
 =?us-ascii?Q?vVRX6pgjPmfTrWCJZTX0JQgWbsQsDHU0UDWWoQW5islgRARXJqEiacUXsnyg?=
 =?us-ascii?Q?StrtOQGIamRCrfF8dqJkK3Av8kMyhrIluDpV0XGKRKivGsZp/k7wL/r2lkDs?=
 =?us-ascii?Q?tIxVypi2d+Ka7MJp9a9mw0Kq9OrZ4KQKQwL/NIwlLWzQq190gdnDhlPAx49r?=
 =?us-ascii?Q?Hck5u/19S3cwE80K0HDEjmkdt8tad09oeRtMg54eDT/8p+MPXmiYeeyZgays?=
 =?us-ascii?Q?Z93hifv7Rw9ut4Qyp9ns6U8G3L+jfaFO6gbXYReTpeEm6AYyMIPahQYtW61v?=
 =?us-ascii?Q?KmArT7D/+pbwZEbyzgspaxKI3iawQlc11896DSRUjza8JLLPhB/LFc3UoMr/?=
 =?us-ascii?Q?dfnv1WpriCfszbTy8P3ebAP0bNpx5OfzuzaZD6UX6jPLYPW0SMQPuj+IuRdk?=
 =?us-ascii?Q?VPaPGtpOxh9LnocqcC64FTJvV5ebIPAa6WT7tUcBU+COz5KRHsEFxLSIZAgS?=
 =?us-ascii?Q?+bilAGmlkUWWHnYYQ/uaPSwjNKZuWeB8tMqnixmbzzcbzG7AThTXJlfx/EhH?=
 =?us-ascii?Q?3eAz6uSzxsuQK7wJHybOTMHyffLa/aO9PSTOvefA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b61c6c3a-cb46-45c0-98f1-08dc7af59496
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 06:57:15.7786
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5A/F9/X8VsoS6AczaSXoj2nfk8H2713x+kJPjdUdtyMZqBtFyKtzuHcY8UwQNnrcX7GMtZ/DZDytUGCM+ebZMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6991
X-OriginatorOrg: intel.com

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Sunday, May 12, 2024 11:02 PM
>=20
> On Fri, Apr 12, 2024 at 08:47:09PM -0700, Nicolin Chen wrote:
>=20
> > +/**
> > + * struct iommu_vqueue_alloc - ioctl(IOMMU_VQUEUE_ALLOC)
> > + * @size: sizeof(struct iommu_vqueue_alloc)
> > + * @flags: Must be 0
> > + * @viommu_id: viommu ID to associate the virtual queue with
> > + * @out_vqueue_id: The ID of the new virtual queue
> > + * @data_type: One of enum iommu_vqueue_data_type
> > + * @data_len: Length of the type specific data
> > + * @data_uptr: User pointer to the type specific data
> > + *
> > + * Allocate an virtual queue object for driver-specific HW-accelerated
> queue
> > + */
> > +
> > +struct iommu_vqueue_alloc {
> > +	__u32 size;
> > +	__u32 flags;
> > +	__u32 viommu_id;
> > +	__u32 out_vqueue_id;
> > +	__u32 data_type;
> > +	__u32 data_len;
> > +	__aligned_u64 data_uptr;
>=20
> Some of the iommus will want an IPA here not a user pointer. I think
> it is fine API wise, we'd just add a flag to indicate data_uptr is an
> IPA.
>=20

Presumably each driver will create its own type data which can
include any IPA field as vcmdq_base in this patch?