Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp816993lqp; Thu, 23 May 2024 00:13:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWBu2OJ/Vn/qrLtGaA9GUghZw4yOE5rtl6nlUD3s24P7IybRWUeB37B/3/Q1pYilnIjg1nE59jyFcnABSWxQI+obC620toUdEGAHmOchg== X-Google-Smtp-Source: AGHT+IHr+mXdaULl6qKkvKKmQSiQ0Gy2u2Zk/jk4uO0Kfj81xOpRDrHuBJYlvU0+SfO4yngaujek X-Received: by 2002:a05:620a:5685:b0:792:d9f0:5572 with SMTP id af79cd13be357-7949944438dmr483978585a.20.1716448408003; Thu, 23 May 2024 00:13:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716448407; cv=pass; d=google.com; s=arc-20160816; b=kC31IFDUQSGhcSkIJ8z8qlGzUFueEFJJBR3/2FayA8WT0JUpYLb5eN1ev3E2qhFqGH Y2e/NU0RF5t4cYc8vDCHVMfuqgVneVxIWUHJqQXixkY9kGF7dbPG3Kp/nGxrtqPly8FF JM0cVEgsXugovUvuRhA3OXrtTL6LVU3NJRkjK1deWxxtinnrpE64uFvgRk0Cf6Kmr7Ei odEcJ5CfCepYv9LZawh7iRotCY+oxZfUW2fyWPn3ngcsQWCTWZhcXiXOu3Kh9z4u0Iqb lx7WHAbric592+lX7IFQDS1RxicHA8MjaIOSFqJvAa0/sUsrRyypFKrnhTtK660mhZRP sUPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=JXOtGvFtyCkfORI9zpElNcz31zki5Fhp5OY6+p/fT4s=; fh=paBIJIMHZeW5+NOssQ40xooTxBYsaITvEraVPI3iRqc=; b=D9QgZtLt8J8AiW1STsMvy+KJ/JA4ocpQa8XADQSq4nqeGfeoL6Q9pQgDcIu6m29ZuI WNR6QabsBkSIZVuO32VA5sCrVWX1f4v458Gtr4B8ZrPsa0CVVq2tzsyeBy9pI5ViYsfP qA9Nr0/LCTFrlhqDc2V54gpmzhGreQ1kB9bgr85QUdQQHgTvwOtJR2jeZsMH+mWi/F0c MUC+YGTw23mbwuBCa3G4+EoJCRM6j4ra4VvDDUL32RWHDNndQzoiDSwS6P5G7ViAKRGO H7gipjZe3TVF7VVxA5UxusG8a05yplwfHEHn47JwnhAr0AswBYOtnR6suNmiUz0SzlAR JfxA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=haK6yGjX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-187075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-792bf33b1b9si3162777685a.457.2024.05.23.00.13.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 00:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-187075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=haK6yGjX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-187075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AA7151C21246 for ; Thu, 23 May 2024 07:13:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B60B713C9D2; Thu, 23 May 2024 07:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="haK6yGjX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E0613C9B8; Thu, 23 May 2024 07:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448400; cv=none; b=GVDFrC5IyBHL0xvbrsEvIsaxJ5rNC8mLw2A0xZv8l8acrY6IRkdp7iSmILhBNGC6ln39LyRker+tVSRTYmOj9PijFb4Gh3vX0Qd+coZd17m0dLD841KyK3EsSOj+fgr0ZTpmrXOo9xv9JjSROeZHpPOZVTuXKZCSRMZrs20y93s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448400; c=relaxed/simple; bh=V5fpkw5MoJMisyLwPZD0LVjS/3RBe+LMYioTy8e3Sr8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ihJ/rXrCc4gOchZs6t58lbN465+Yg52imJ4WSzfZ+0vYq4puw7lBykHFw8RUNlR7/b9AMHLWeJWcvGN/N7FAHijoOaN8zq6v+sBhDLzIHvRwuU29lBzz9/EYHietgxm0jGyecCUnQh4xurIJI9Rm0cJEsMywy6HwrLHWhPM/9SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=haK6yGjX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C672CC2BD10; Thu, 23 May 2024 07:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716448399; bh=V5fpkw5MoJMisyLwPZD0LVjS/3RBe+LMYioTy8e3Sr8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=haK6yGjXXIsOZ4l9kzSMv/R06Gkhybm8oFGB3aIN8rrrXCeAn3vr7fA2F9gyxyVL2 Vx6bV9m43Pynhxga+j75gSyCODUM6kiW4KYnjvWT2ZI5nwDuosmK/LTzHf+NYfGtKc 6c8llG/2HIJNo+8uNQNr8Wk646q2FaNWQV/E7ob/SR6D55BYgrK3avntCOymJ1gYYZ TClcD83tOlsLaJEYPqNZhEB01j2n4tIXjq4JUf44bvAapO6m8ioKmF/KWXpcZJw9xQ yqk/nUccIjX9SAOt4jfuE8+Tp4l8qrUcNJ7uZ9NeUI6ebqvLi3Z8xrwENJcTgv+6dQ B6Gt0r/QBWCrg== Message-ID: <735594c5-5f50-49b0-b84c-e41efbb834b0@kernel.org> Date: Thu, 23 May 2024 09:13:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/17] Add conf.h To: Kalle Valo Cc: michael.nemanov@ti.com, Johannes Berg , Breno Leitao , Justin Stitt , Kees Cook , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sabeeh Khan References: <20240521171841.884576-1-michael.nemanov@ti.com> <20240521171841.884576-14-michael.nemanov@ti.com> <9ba9d156-ce38-47ba-b0fb-63e6174c3094@kernel.org> <87r0dtattp.fsf@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <87r0dtattp.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/05/2024 09:08, Kalle Valo wrote: > Krzysztof Kozlowski writes: > >> On 21/05/2024 19:18, michael.nemanov@ti.com wrote: >>> From: Michael Nemanov >>> >>> Various HW / FW / Driver controls unique for the CC33xx that >>> can be set by OEMs. >>> >>> Signed-off-by: Michael Nemanov >>> --- >>> drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++ >> >> So you are adding one file by another? This does not help review. >> >> Add logical chunks, e.g. users of header after the header. Or all >> headers together. Or some features incrementally, like basic working >> driver and then feature foo and bar. > > For new wireless drivers my recommendation has been to submit for review > one file per patch but the final driver to be commited would be just one > patch: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver Understood. Best regards, Krzysztof