Received-SPF: pass (google.com: domain of linux-kernel+bounces-187078-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d225dac2-501b-40de-b9d9-305a9ebfff51@prevas.dk>
Date: Thu, 23 May 2024 09:16:49 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH workqueue/for-6.10-fixes] workqueue: Refactor worker ID
 formatting and make wq_worker_comm() use full ID string
To: Linus Torvalds <torvalds@linux-foundation.org>,
 Yafang Shao <laoar.shao@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Jan Engelhardt <jengelh@inai.de>,
 Craig Small <csmall@enc.com.au>, linux-kernel@vger.kernel.org,
 Lai Jiangshan <jiangshanlai@gmail.com>
References: <o89373n4-3oq5-25qr-op7n-55p9657r96o8@vanv.qr>
 <CAHk-=wjxdtkFMB8BPYpU3JedjAsva3XXuzwxtzKoMwQ2e8zRzw@mail.gmail.com>
 <ZkvO-h7AsWnj4gaZ@slm.duckdns.org>
 <CALOAHbCYpV1ubO3Z3hjMWCQnSmGd9-KYARY29p9OnZxMhXKs4g@mail.gmail.com>
 <CAHk-=wj9gFa31JiMhwN6aw7gtwpkbAJ76fYvT5wLL_tMfRF77g@mail.gmail.com>
Content-Language: en-US, da
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <CAHk-=wj9gFa31JiMhwN6aw7gtwpkbAJ76fYvT5wLL_tMfRF77g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S1ozS2s3OW1XMHByVHpSN0drUVIweEpaaS9sWlE3My9NV2NpOHV2UnplQysr?=
 =?utf-8?B?Vk9SVFlPWUwrMWJBZlM0YXV2QnlXc2ZzTjN3aE0zeitIdXprbnU1QzlTY0tI?=
 =?utf-8?B?V29xQ0hRb3pXcHVsckYwVzNEOGdYdEFPWDl2UlNRWVNmVm1aWnI2WURUT2sw?=
 =?utf-8?B?aFRQU09aODRJY2NQRk1xQWpnS01lR2dNbzBkY1AwVDlaNlMyUG14WFFwQU5k?=
 =?utf-8?B?cDg0Z0xNN3d3dE1UeTlveEMvd2pKcWFXeEEwZzRpNjlMRmNYWnZhOE9MaGR0?=
 =?utf-8?B?c3BIL0EySlU0dWJlNisvWDRFNnFLWktLczBnVTlhMWplcXM1dGVVMllWYVFh?=
 =?utf-8?B?QldJd1JKOHgzby9kdjRHZjhMZlN2cU1oTGZkUHU4Qm1NWHNvZ21LQXZ0ZlJu?=
 =?utf-8?B?Tm1UWENXZW11b3ZybTF5NTJXWnFodHlZMXBpOWVxNlRpTTQrV09FWTZFd0pr?=
 =?utf-8?B?aWtIdmJVT3FMb2JtYTd4ZGF1RmZxNWR4djBuWXBxSHc1T1NCOGh1akFtQ1Na?=
 =?utf-8?B?THEvOTN3UU1VKzdJNXR4b25jeWFFcjZab3dPZ0c1S1ZiSVhhUVEzdCs0YUFy?=
 =?utf-8?B?dmxMbzlWbmx3L1g1b0duYU1hdWVtZkVMNEVUOVlWVlFZQ1JxTVlxZFNZT1U2?=
 =?utf-8?B?SFhsVjZGenpSM1BQaU5XcWUwNlphVERYR0VrMzlBcjhHKzE3SUQxdnVoZmFJ?=
 =?utf-8?B?R2V0cDVOV1U4VTd4d05mRGhaQUd0clcyTGZpb1NINE9SUzFWR0hjUjhUdW5M?=
 =?utf-8?B?WCtTKzc5bVF2Y3d5ZUlrVXVwTHR0NGkyZVh4MklwbjZOcmZSc3o4eFRRTDhE?=
 =?utf-8?B?RUE0OFQyN3lTajNsaFNwS0NYcTc1RmlrU2svVGZ4SGZDZXYraVR4SUtkSklY?=
 =?utf-8?B?dG95Z2RRR1VUbzdJTmRmU0I0Vk9hUnFDZDhCYUZjaEUyWjh2UW9zLzd5Q0xU?=
 =?utf-8?B?aSs0T2NFM21FM1lFWHBzdGhjREk2aDhQYXlhS3FNaFVxSnpla0pqdkgza2xH?=
 =?utf-8?B?dFhHS05DcnRtWER0Nkl4dkJMeHFQNHhtRnBMWEVIcCtHRWFaS3ZPOXJKTkJT?=
 =?utf-8?B?TmhSRElaZzZpMFZyVUdTY2kvdzFZb2Q2NUNwY2JUcWdJSXN3TmJVd2M3aFg1?=
 =?utf-8?B?Mnk0ZU9TaWxRaHNHOXZoSzlseHNIUXFVVmhYYzg0NlNCNHdWbUxpZWhlRWJk?=
 =?utf-8?B?dkJWWTZaQTNVVVhXVnpnYUN1eStGaXJBcTdRSXdKNXoraU9PSzJRMUgrTk5u?=
 =?utf-8?B?STVqSDQ5Q1RFTDhRbFBWOHRNTXpKQ3BvSGg2aENRanM3U0ZBS0RNdnVWWkhG?=
 =?utf-8?B?dVlJTHZlalgyampTZ2hVVlhGZGFLcGJuSGJTTHJia1B6SHJwY2JwdlZxWHg4?=
 =?utf-8?B?N3REYzJCVFhmVGlkZmhuOUtoRmo3cnJsWTFLRkpPcFFjbFBZS2ZjTjRLY0Jx?=
 =?utf-8?B?cnhnd3Z1b0EwSUJXUzBnTFIwN24xOHZzZTM2NkNZYS9pLzN0Lzlmd2oyYmpy?=
 =?utf-8?B?dDJQdXQzYmhMSkpPT3ZVMkdWNkVvUUtyamREWHhraGFEVkJqQ3lwWjNKeEFX?=
 =?utf-8?B?MWlKWHlNOTNJVTdkUTNJbDJqODlYdG9KM1VUQ2ZIOGovcXJuWTNocWdVRmVk?=
 =?utf-8?B?STBUNTZBNDEzeVlPRGREL1ZaVk16em9hTEFuU204NzA4M1UwV3dhTEp2R09m?=
 =?utf-8?B?K1VPMGhwakZiREY1aVN4QzkwcmV3Q0N1T0xrYi9KeWtsZ3o4Q0RLYXRFa3Fv?=
 =?utf-8?B?VjBrNVdkWW1TaDBaQWJETjVoeEtJZGFJdUhrOTNWc3psRlY5a2Vsci9QSXc4?=
 =?utf-8?B?ZlFuZW1hdkIvdkxwSzExMW83NkdYdVpXYlhJNEZPcUppSGV0RUZZeE5OQkJ2?=
 =?utf-8?B?NFlvd0IvcWkzUmlQMWZ5NW5sT1R3QWpzTEFiUVZxalY4ZlVYMkt2QlpHNXZY?=
 =?utf-8?B?ZHFkK3lJTkFRUEZCa3I1OHpTRTJ3RFpRRTd0NEsrcW83T01IRkNNYTZ6MkFn?=
 =?utf-8?B?UUtkTGt4emtiY1puMFFvWlhCZ2puRnNMK1BSazRIajYxNGszKzlaUzdnYXV5?=
 =?utf-8?B?OEl0S052WXBNSnB1SFdublE5SUc3YlZaMkhJUHg2WjA2NVQ1TmVBbnpOWkFw?=
 =?utf-8?B?UXM3Q3l0K1k0ckNtcE12RFk3clI4aU9JREZzdElQb21Kc1NJMEJkcURuNFRU?=
 =?utf-8?B?akE9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: f52dbf51-6563-47a4-c628-08dc7af851df
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 07:16:53.4832
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oQ2jF0mvUcnC8846LtBqvcA8Z7XtCNWi8E7rKs5q2vdkPPfEVMcpDdiMNCPDSF6okZTAh7NJWJLCvHf4i/3KV+Isl6+fPApeUgnPeZ2et9s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB7951

On 21/05/2024 20.05, Linus Torvalds wrote:
> On Mon, 20 May 2024 at 19:34, Yafang Shao <laoar.shao@gmail.com> wrote:
>>
>> We discussed extending it to 24 characters several years ago [0], but
>> some userspace tools might break.
> 
> Well, the fact that we already expose names longer than 16 bytes in
> /proc means that at least *that* side of it could use an extended
> comm[] array.
> 
> Yes, some other interfaces might want to still use a 16-byte limit as
> the length for the buffers they use (tracing?) but I suspect we could
> make the comm[] array easily bigger.
> 
> But what I suspect we should do *first* is to try to get rid of a lot
> of the "current->comm" users. One of the most common uses is purely
> for printing, and we could actually just add a new '%p' pointer for
> printing the current name. That would allow our vsprintf() code to not
> just use tsk->comm, but to use the full_name for threads etc.
> 
> So instead of
> 
>    printf("%s ..", tsk->comm..);
> 
> we could have something like
> 
>    printf("%pc ..", tsk);

The alphabet is running out of letters, so if somebody goes and
implement this, I'd suggest making this %pc thing take extra modifiers,
so one could also get the pid or whatever else one might want to print
from a task. I.e. %pcN, %pcP, ... We could of course have %pc with no
following letter mean ->comm (or "real name" for kernel threads) if that
is the most common thing, which it very well might be.

Rasmus