Received-SPF: pass (google.com: domain of linux-kernel+bounces-187107-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i12284293:Fastmail
Date: Thu, 23 May 2024 09:43:27 +0200
From: Alyssa Ross <hi@alyssa.is>
To: Xuewei Niu <niuxuewei97@gmail.com>
Cc: stefanha@redhat.com, sgarzare@redhat.com, mst@redhat.com, 
	davem@davemloft.net, kvm@vger.kernel.org, virtualization@lists.linux.dev, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Xuewei Niu <niuxuewei.nxw@antgroup.com>, virtio-comment@lists.linux.dev
Subject: Re: [RFC PATCH 1/5] vsock/virtio: Extend virtio-vsock spec with an
 "order" field
Message-ID: <4hmduhgue6g7rnuaqtakvgigaiu2dwgm2cm7wwusm7wa2xfdtr@eav5ltj4lqsd>
References: <20240517144607.2595798-1-niuxuewei.nxw@antgroup.com>
 <20240517144607.2595798-2-niuxuewei.nxw@antgroup.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ymwyv3un5agbox3r"
Content-Disposition: inline
In-Reply-To: <20240517144607.2595798-2-niuxuewei.nxw@antgroup.com>


--ymwyv3un5agbox3r
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

(CCing virtio-comment, since this proposes adding a field to a struct
that is standardized[1] in the VIRTIO spec, so changes to the Linux
implementation should presumably be coordinated with changes to the
spec.)

[1]: https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01=
=2Ehtml#x1-4780004

On Fri, May 17, 2024 at 10:46:03PM +0800, Xuewei Niu wrote:
> The "order" field determines the location of the device in the linked lis=
t,
> the device with CID 4, having a smallest order, is in the first place, and
> so forth.
>
> Rules:
>
> * It doesn=E2=80=99t have to be continuous;
> * It cannot exist conflicts;
> * It is optional for the mode of a single device, but is required for the
>   mode of multiple devices.
>
> Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
> ---
>  include/uapi/linux/virtio_vsock.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virti=
o_vsock.h
> index 64738838bee5..b62ec7d2ab1e 100644
> --- a/include/uapi/linux/virtio_vsock.h
> +++ b/include/uapi/linux/virtio_vsock.h
> @@ -43,6 +43,7 @@
>
>  struct virtio_vsock_config {
>  	__le64 guest_cid;
> +	__le64 order;
>  } __attribute__((packed));
>
>  enum virtio_vsock_event_id {
> --
> 2.34.1
>

--ymwyv3un5agbox3r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmZO85wACgkQ+dvtSFmy
ccDRVg/+J2b4Yt4KmcQzq0DfhbUZU5xta4K5cBOzSruvTYlBmO0SFOoBRnLERz7g
J5/1nYCE6vxMPymbTLkvaP+npnZfnr9Vdtf9f+jJ2NtBEcxVYV2ITZ2wb3a9+ffT
VPE78h3xVPFA6cGRTQomS4xaThvLtngicfBWwoZT1LrC2Jt5U14fYxO8u0FOCd1w
X7eEfmnz1rieoUKOf6g1ELIpNTSI6OcWxZafKXFtqX2IZo9e22Ln4yft8F4CS0fc
3Pczp2OVHIZEkUz6hfaGQlwpavm0Asrf4M+StL4nyQJ5rTJF3/pVBDEsK+v4IlDP
TQCZyd436QhXZG5NV9Fb6cry9Rh3vmhPkuE/NljpWn3SI0WyOsbITmxoGmgpJkYq
RIjIcGM8EIqUwik8KtdUqkkA0opseaZOp90MpieUBFzDAPJr8b7Afa7oaDmUdkak
6Q+29Bpvy5exSzuCNjQjksaBUgwAyd5SvZTyaxQCKxKEjM+FROvARo/cLQUYpDuf
r3EPH9gMwx99mewVLhnxE5AxmfcGgElextGjBBc0OZ+KglvFziVx/l0EBmvwxoLP
FDiJ8+wfSc0a68wqKmGsrphRu8fxIkOnHy80VGKm+sdeljH+qRETwqBo1S7rtYWs
tZlgDBEtc7DjSlo8G0GxBeIW9yWsfsg1nLMbd8UCQ8rR/pjn0bE=
=n1+2
-----END PGP SIGNATURE-----

--ymwyv3un5agbox3r--