Received-SPF: pass (google.com: domain of linux-kernel+bounces-187130-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3e4bbd0f0fe9f57fd7555a3775e8d71031c0d6c5.camel@gmail.com>
Subject: Re: [PATCH 1/3] tpm: Disable TCG_TPM2_HMAC by default
From: Vitor Soares <ivitro@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, James Bottomley
	 <James.Bottomley@HansenPartnership.com>, linux-integrity@vger.kernel.org
Cc: keyrings@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>, Jason
 Gunthorpe <jgg@ziepe.ca>, Mimi Zohar <zohar@linux.ibm.com>, David Howells
 <dhowells@redhat.com>, Paul Moore <paul@paul-moore.com>, James Morris
 <jmorris@namei.org>, "Serge E. Hallyn" <serge@hallyn.com>, 
 linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Date: Thu, 23 May 2024 08:59:26 +0100
In-Reply-To: <D1GAZSIOZVWW.2UZBFHASIG21U@kernel.org>
References: <20240519235122.3380-1-jarkko@kernel.org>
	 <20240519235122.3380-2-jarkko@kernel.org>
	 <850862655008f84ef0b6ecd99750e8dc395304d1.camel@gmail.com>
	 <D1F4V8NMSUNZ.2VCTEKHZZ0LB@kernel.org>
	 <17dc838120b56ce342c34611596c7b46dcd9ab5a.camel@HansenPartnership.com>
	 <2dd8d49516ec9c7cb8c1182b5b8537b1e82d7067.camel@gmail.com>
	 <17a5dcd7aceb356587ef7c8f45b0f6359b2d2a91.camel@HansenPartnership.com>
	 <D1G8HOCIDWTC.2ERVA0CYHLY0B@kernel.org>
	 <0c12c9ea10aa97e246230fc33e6b35c571102b48.camel@gmail.com>
	 <D1GAZSIOZVWW.2UZBFHASIG21U@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-05-22 at 19:11 +0300, Jarkko Sakkinen wrote:
> On Wed May 22, 2024 at 5:58 PM EEST, Vitor Soares wrote:
> > I did run with ftrace, but need some more time to go through it.
> >=20
> > Here the step I did:
> > kernel config:
> > =C2=A0 CONFIG_FUNCTION_TRACER
> > =C2=A0 CONFIG_FUNCTION_GRAPH_TRACER
> >=20
> > ftrace:
> > =C2=A0 # set filters
> > =C2=A0 echo tpm* > set_ftrace_filter
> >=20
> > =C2=A0 # set tracer
> > =C2=A0 echo function_graph > current_tracer
> >=20
> > =C2=A0 # take the sample
> > =C2=A0 echo 1 > tracing_on; time modprobe tpm_tis_spi; echo 0 > tracing=
_on
> >=20
> > regards,
> > Vitor Soares
>=20
> I'm now compiling distro kernel (OpenSUSE) for NUC7 with v6.10 contents.
>=20
> After I have that setup, I'll develop a perf test either with perf or
> bpftrace. I'll come back with the possible CONFIG_* that should be in
> place in your kernel. Might take up until next week as I have some
> conference stuff to prepare but I try to have stuff ready early next
> week.
>=20
> No need to rush with this as long as possible patches go to rc2 or rc3.
> Let's do a proper analysis instead.
>=20
> In the meantime you could check if you get perf and/or bpftrace to=20
> your image that use to boot up your device. Preferably both but
> please inform about this.
>=20

I already have perf running, for the bpftrace I might not be able to help.

Regards,
Vitor Soares

> Fair enough?
>=20
> BR, Jarkko