Received-SPF: pass (google.com: domain of linux-kernel+bounces-187266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 23 May 2024 11:29:20 +0200
From: Alexey Gladkov <legion@kernel.org>
To: "Dmitry V. Levin" <ldv@strace.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: linux/kd.h: include missing header
Message-ID: <Zk8McCtAhKtMTt2n@example.org>
References: <20240523092310.GA31777@altlinux.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240523092310.GA31777@altlinux.org>

On Thu, May 23, 2024 at 12:23:10PM +0300, Dmitry V. Levin wrote:
> Given that linux/kd.h now uses macros defined in linux/ioctl.h,
> do not rely on that header being already included by linux/kd.h users
> and include linux/ioctl.h explicitly.
> 
> This bug was found by strace CI.
> 
> Fixes: 8c467f330059 ("VT: Use macros to define ioctls")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>

Acked-by: Alexey Gladkov <legion@kernel.org>

> ---
>  include/uapi/linux/kd.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
> index 8ddb2219a84b..8fcce939ba25 100644
> --- a/include/uapi/linux/kd.h
> +++ b/include/uapi/linux/kd.h
> @@ -3,6 +3,7 @@
>  #define _UAPI_LINUX_KD_H
>  #include <linux/types.h>
>  #include <linux/compiler.h>
> +#include <linux/ioctl.h>
>  
>  /* 0x4B is 'K', to avoid collision with termios and vt */
>  #define KD_IOCTL_BASE	'K'
> -- 
> ldv
> 

-- 
Rgrds, legion