Received-SPF: pass (google.com: domain of linux-kernel+bounces-187272-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 23 May 2024 11:32:11 +0200
From: "Steinar H. Gunderson" <sesse@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, irogers@google.com
Subject: Re: [PATCH v4 1/3] perf report: Support LLVM for addr2line()
Message-ID: <Zk8NG10oHcQ0T6EQ@google.com>
References: <20240520083048.322863-1-sesse@google.com>
 <CAM9d7cgBZVfur8S3QC2woUA2C6O3Dme0YHP8PbFcwc_o0k-dWg@mail.gmail.com>
 <Zk5Mi7SliDOd8uO4@google.com>
 <CAM9d7cjjH63CC8r-z33P4SCWw3x4NMxuSC1CovVHqpp-zXSf6g@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7cjjH63CC8r-z33P4SCWw3x4NMxuSC1CovVHqpp-zXSf6g@mail.gmail.com>

On Wed, May 22, 2024 at 01:46:35PM -0700, Namhyung Kim wrote:
> Great!  Personally I found libbfd is hard to read (and use).  Hope
> that libllvm is better in that pov.  I'm not sure if we all want to
> remove the libbfd dependency but at least we can select one of
> them at build time.  Maybe the same for libelf and libdw(fl) too.

I've never used either before, but I found libllvm pretty
straightforward. The C/C++ interop is a bit painful, though.
(The disassembler has a C interface, but addr2line does not,
from what I could see.)

> Having symbol enumeration and demangling with LLVM would
> be nice but not required to merge this work.  I'll take a deeper
> look next week.  Please post v5.

Posted.

/* Steinar */