Received-SPF: pass (google.com: domain of linux-kernel+bounces-187294-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <24d0579a-1c8d-42ea-afa5-dcd0ab3fa193@ti.com>
Date: Thu, 23 May 2024 15:24:43 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable
To: Bhavya Kapoor <b-kapoor@ti.com>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <conor+dt@kernel.org>,
        <krzk+dt@kernel.org>, <robh@kernel.org>, <kristo@kernel.org>,
        <jm@ti.com>, <nm@ti.com>
References: <20240522083631.1015198-1-b-kapoor@ti.com>
From: Vignesh Raghavendra <vigneshr@ti.com>
Content-Language: en-US
In-Reply-To: <20240522083631.1015198-1-b-kapoor@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 22/05/24 14:06, Bhavya Kapoor wrote:
> Mark the eMMC module on J722S as non removable since it
> is always present on the evm.

Nit s/evm/EVM

> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---

This needs a Fixes tag?

>  arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index bf3c246d13d1..fe810e32cb7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -369,6 +369,7 @@ partition@3fc0000 {
>  &sdhci0 {
>  	disable-wp;
>  	bootph-all;
> +	non-removable;
>  	ti,driver-strength-ohm = <50>;
>  	status = "okay";
>  };


-- 
Regards
Vignesh